Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[Solved]Item loss

Naiten

By Naiten
in Modder Support

 Share

Recommended Posts

Naiten Diamond Finder

Naiten

Posted
Posted

I have an item, and it tends to get lost after i save/load. What's wrong?

package net.obscuracraft.item;

import java.util.Random;

import net.minecraft.client.Minecraft;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemMapBase;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import net.minecraft.world.storage.MapData;
import net.obscuracraft.ObscuraCraft;
import net.obscuracraft.camera.BlockObscura;

public class ItemPhotoEmpty extends ItemMapBase
{
    public ItemPhotoEmpty(int par1){
        super(par1);
        this.setMaxDamage(0);
        this.maxStackSize = 1;
        this.hasSubtypes = true;
        setUnlocalizedName("obscuracraft:positive");
        setCreativeTab(CreativeTabs.tabRedstone);
    }
@Override
public ItemStack onItemRightClick(ItemStack item, World world, EntityPlayer player){
	ItemStack item1 = new ItemStack(ObscuraCraft.iphoto, 1, world.getUniqueDataId("photo"));
	item1.attemptDamageItem(1, new Random());
        String s = "photo_" + item1.getItemDamage();
        MapData mapdata = new MapData(s);
        mapdata.colors = BlockObscura.lastColors;
        world.setItemData(s, mapdata);
        mapdata.markDirty();
        item1.setItemName("Photo #" + item1.getItemDamage());
        item.stackSize--;
        return item1;
    }
}

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites
SanAndreaP World Shaper

SanAndreaP

Posted
Posted

I have an item, and it tends to get lost after i save/load. What's wrong?

package net.obscuracraft.item;

import java.util.Random;

import net.minecraft.client.Minecraft;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemMapBase;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import net.minecraft.world.storage.MapData;
import net.obscuracraft.ObscuraCraft;
import net.obscuracraft.camera.BlockObscura;

public class ItemPhotoEmpty extends ItemMapBase
{
    public ItemPhotoEmpty(int par1){
        super(par1);
        this.setMaxDamage(0);
        this.maxStackSize = 1;
        this.hasSubtypes = true;
        setUnlocalizedName("obscuracraft:positive");
        setCreativeTab(CreativeTabs.tabRedstone);
    }
@Override
public ItemStack onItemRightClick(ItemStack item, World world, EntityPlayer player){
	ItemStack item1 = new ItemStack(ObscuraCraft.iphoto, 1, world.getUniqueDataId("photo"));
	item1.attemptDamageItem(1, new Random());
        String s = "photo_" + item1.getItemDamage();
        MapData mapdata = new MapData(s);
        mapdata.colors = BlockObscura.lastColors;
        world.setItemData(s, mapdata);
        mapdata.markDirty();
        item1.setItemName("Photo #" + item1.getItemDamage());
        item.stackSize--;
        return item1;
    }
}

 

get lost in which way? Disappearing or data isn't saved or what?

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites
Naiten Diamond Finder

Naiten

Posted
  • Author
Posted

I've made several items in this mod and they don't get lost.

Also, as i remember, no spetial registration is needed so far...

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites
Naiten Diamond Finder

Naiten

Posted
  • Author
Posted

Oh, i got it. It's in

mineCraft.thePlayer.inventory.setCurrentItem(ObscuraCraft.icamera.itemID, 0, false, true);

How do i do that in right way?

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites
Zetal Creeper Killer

Zetal

Posted
Posted

You should use this instead:

 

    	this.inventory.addItemStackToInventory(YOURITEMSTACKHERE);

 

The code that you're using is designed to change which item a player has 'selected' at the time. The above will actually add it to the inventory. In order to use it, you'll need to create a new ItemStack object using whatever parameters you need. An inventory object only ever takes 'ItemStack' objects into it's slots, not items.

Have a modding question? PM me and hopefully I'll be able to help. Good at 2d Pixel Art? We need your help!  http://www.minecraftforum.net/topic/1806355-looking-for-2d-pixel-artist/

Link to comment
Share on other sites
Naiten Diamond Finder

Naiten

Posted
  • Author
Posted 
public class BlockObscura extends BlockContainer{
blablabla;
//called from other place
public static void takePhoto(){
	blablabla;
	Minecraft mineCraft = Minecraft.getMinecraft();
	mineCraft.thePlayer.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));
	//mineCraft.thePlayer.inventory.setCurrentItem(ObscuraCraft.icamera.itemID, 0, false, true);
	blablabla;
}
}

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites
Zetal Creeper Killer

Zetal

Posted
Posted

Try replacing 

  mineCraft.thePlayer.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));

 

with this instead;

 

player.inventory.addItemStackToInventory(item1);

I /think/ that's what you're looking for. Let me know.

Have a modding question? PM me and hopefully I'll be able to help. Good at 2d Pixel Art? We need your help!  http://www.minecraftforum.net/topic/1806355-looking-for-2d-pixel-artist/

Link to comment
Share on other sites
Naiten Diamond Finder

Naiten

Posted
  • Author
Posted

There's public boolean onItemUse(ItemStack item, EntityPlayer player, World world, int x, int y, int z, int side, float xOffset, float yOffset, float zOffSet)

And i can't use onItemRightClick, because i need clicked block coordinates.

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites
Naiten Diamond Finder

Naiten

Posted
  • Author
Posted 
@Override
    public boolean onItemUse(ItemStack item, EntityPlayer player, World world, int x, int y, int z, int side, float xOffset, float yOffset, float zOffSet){
        if (!world.isRemote && item.getItemDamage() == 0){
        	if(world.getBlockId(x, y, z) == ObscuraCraft.camera.blockID){
        		if(world.getBlockMetadata(x, y, z) == 4){
        			y--;
        		}
        		int meta = world.getBlockMetadata(x, y, z);
        		world.setBlockMetadataWithNotify(x, y, z, 4, 0x02);
        		world.setBlockMetadataWithNotify(x, y, z, meta, 0x02);
        		TileEntityObscura tl = (TileEntityObscura)world.getBlockTileEntity(x, y, z);
        		tl.filled = true;
        		BlockObscura.takePhoto(player);
            	if (!player.capabilities.isCreativeMode){--item.stackSize;}
            	player.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));
            	return true;
        	}
	}
        return false;
    }

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites
SanAndreaP World Shaper

SanAndreaP

Posted
Posted 

@Override
    public boolean onItemUse(ItemStack item, EntityPlayer player, World world, int x, int y, int z, int side, float xOffset, float yOffset, float zOffSet){
        if (!world.isRemote && item.getItemDamage() == 0){
        	if(world.getBlockId(x, y, z) == ObscuraCraft.camera.blockID){
        		if(world.getBlockMetadata(x, y, z) == 4){
        			y--;
        		}
        		int meta = world.getBlockMetadata(x, y, z);
        		world.setBlockMetadataWithNotify(x, y, z, 4, 0x02);
        		world.setBlockMetadataWithNotify(x, y, z, meta, 0x02);
        		TileEntityObscura tl = (TileEntityObscura)world.getBlockTileEntity(x, y, z);
        		tl.filled = true;
        		BlockObscura.takePhoto(player);
            	if (!player.capabilities.isCreativeMode){--item.stackSize;}
            	player.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));
            	return true;
        	}
	}
        return false;
    }

 

after

player.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));

use this:

player.inventoryContainer.detectAndSendChanges();

 

It sends the changes you made in the players inventory on the server to the client.

 

Also you should define a quantity in your ItemStack like this: new ItemStack(ObscuraCraft.icamera, 1)

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites
Naiten Diamond Finder

Naiten

Posted
  • Author
Posted
use this:

player.inventoryContainer.detectAndSendChanges();

It sends the changes you made in the players inventory on the server to the client.

Also you should define a quantity in your ItemStack like this: new ItemStack(ObscuraCraft.icamera, 1)

Thanks.

And, i actually should not. ItemStack has a constructor without quantity that automatically sets it to 1.

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites
SanAndreaP World Shaper

SanAndreaP

Posted
Posted

use this:

player.inventoryContainer.detectAndSendChanges();

It sends the changes you made in the players inventory on the server to the client.

Also you should define a quantity in your ItemStack like this: new ItemStack(ObscuraCraft.icamera, 1)

Thanks.

And, i actually should not. ItemStack has a constructor without quantity that automatically sets it to 1.

 

Oh, didn't know that. Well then not :P

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • DroidCrafter23
      How do I make a drink item?

      By DroidCrafter23 · Posted

      I have done this now but have got the error:   'food(net.minecraft.world.food.FoodProperties)' in 'net.minecraft.world.item.Item.Properties' cannot be applied to                '(net.minecraftforge.registries.RegistryObject<net.minecraft.world.item.Item>)' public static final RegistryObject<Item> LEMON_JUICE = ITEMS.register( "lemon_juice", () -> new Item( new HoneyBottleItem.Properties().stacksTo(1).food( (new FoodProperties.Builder()) .nutrition(3) .saturationMod(0.25F) .effect(() -> new MobEffectInstance(MobEffects.DAMAGE_RESISTANCE, 1500), 0.01f ) .build() ) )); The code above is from the ModFoods class, the one below from the ModItems class. public static final RegistryObject<Item> LEMON_JUICE = ITEMS.register("lemon_juice", () -> new Item(new Item.Properties().food(ModFoods.LEMON_JUICE)));   I shall keep going between them to try and figure out the cause. I am sorry if this is too much for you to help with, though I thank you greatly for your patience and all the effort you have put in to help me.
    • DroidCrafter23
      How do I make a drink item?

      By DroidCrafter23 · Posted

      I have been following these exact tutorials for quite a while, I must agree that they are amazing and easy to follow. I have registered the item in the ModFoods class, I tried to do it in ModItems (Where all the items should be registered) but got errors, I think I may need to revert this and figure it out from there. Once again, thank you for your help! 👍 Just looking back, I have noticed in your code you added ITEMS.register, which I am guessing means that they are being registered in ModFoods, I shall go through the process of trial and error to figure this out.
    • Orladodgreat
      𓅓+2349027025197𓅓 I WANT TO JOIN SECRET SOCIETY FOR MONEY RITUAL {¶}

      By Orladodgreat · Posted

      ♈+2349027025197ஜ Are you a pastor, business man or woman, politician, civil engineer, civil servant, security officer, entrepreneur, Job seeker, poor or rich Seeking how to join a brotherhood for protection and wealth here’s is your opportunity, but you should know there’s no ritual without repercussions but with the right guidance and support from this great temple your destiny is certain to be changed for the better and equally protected depending if you’re destined for greatness Call now for enquiry +2349027025197☎+2349027025197₩™ I want to join ILLUMINATI occult without human sacrificeGREATORLDRADO BROTHERHOOD OCCULT , Is The Club of the Riches and Famous; is the world oldest and largest fraternity made up of 3 Millions Members. We are one Family under one father who is the Supreme Being. In Greatorldrado BROTHERHOOD we believe that we were born in paradise and no member should struggle in this world. Hence all our new members are given Money Rewards once they join in order to upgrade their lifestyle.; interested viewers should contact us; on. +2349027025197 ۝ஐℰ+2349027025197 ₩Greatorldrado BROTHERHOOD OCCULT IS A SACRED FRATERNITY WITH A GRAND LODGE TEMPLE SITUATED IN G.R.A PHASE 1 PORT HARCOURT NIGERIA, OUR NUMBER ONE OBLIGATION IS TO MAKE EVERY INITIATE MEMBER HERE RICH AND FAMOUS IN OTHER RISE THE POWERS OF GUARDIANS OF AGE+. +2349027025197   SEARCHING ON HOW TO JOIN THE Greatorldrado BROTHERHOOD MONEY RITUAL OCCULT IS NOT THE PROBLEM BUT MAKE SURE YOU'VE THOUGHT ABOUT IT VERY WELL BEFORE REACHING US HERE BECAUSE NOT EVERYONE HAS THE HEART TO DO WHAT IT TAKES TO BECOME ONE OF US HERE, BUT IF YOU THINK YOU'RE SERIOUS MINDED AND READY TO RUN THE SPIRITUAL RACE OF LIFE IN OTHER TO ACQUIRE ALL YOU NEED HERE ON EARTH CONTACT SPIRITUAL GRANDMASTER NOW FOR INQUIRY +2349027025197   +2349027025197 Are you a pastor, business man or woman, politician, civil engineer, civil servant, security officer, entrepreneur, Job seeker, poor or rich Seeking how to join
    • KeBaB95
      Mod Pack hooror

      By KeBaB95 · Posted

      hi bitch
    • ANtonYL
      Caused by: java.lang.IllegalStateException: Duplicate recipe compressed:compressed_diamond

      By ANtonYL · Posted

      Hi, I'm trying to use datagen to create json files in my own mod. This is my ModRecipeProvider class. public class ModRecipeProvider extends RecipeProvider implements IConditionBuilder { public ModRecipeProvider(PackOutput pOutput) { super(pOutput); } @Override protected void buildRecipes(Consumer<FinishedRecipe> pWriter) { ShapedRecipeBuilder.shaped(RecipeCategory.MISC, ModBlocks.COMPRESSED_DIAMOND_BLOCK.get()) .pattern("SSS") .pattern("SSS") .pattern("SSS") .define('S', ModItems.COMPRESSED_DIAMOND.get()) .unlockedBy(getHasName(ModItems.COMPRESSED_DIAMOND.get()), has(ModItems.COMPRESSED_DIAMOND.get())) .save(pWriter); ShapelessRecipeBuilder.shapeless(RecipeCategory.MISC, ModItems.COMPRESSED_DIAMOND.get(),9) .requires(ModBlocks.COMPRESSED_DIAMOND_BLOCK.get()) .unlockedBy(getHasName(ModBlocks.COMPRESSED_DIAMOND_BLOCK.get()), has(ModBlocks.COMPRESSED_DIAMOND_BLOCK.get())) .save(pWriter); ShapedRecipeBuilder.shaped(RecipeCategory.MISC, ModItems.COMPRESSED_DIAMOND.get()) .pattern("SSS") .pattern("SSS") .pattern("SSS") .define('S', Blocks.DIAMOND_BLOCK) .unlockedBy(getHasName(ModItems.COMPRESSED_DIAMOND.get()), has(ModItems.COMPRESSED_DIAMOND.get())) .save(pWriter); } } When I try to run the runData client, it shows an error:  Caused by: java.lang.IllegalStateException: Duplicate recipe compressed:compressed_diamond I know that it's caused by the fact that there are two recipes for the ModItems.COMPRESSED_DIAMOND. But I need both of these recipes, because I need a way to craft ModItems.COMPRESSED_DIAMOND_BLOCK and restore 9 diamond blocks from ModItems.COMPRESSED_DIAMOND. Is there a way to solve this?

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept