Jump to content

[Solved]Item loss


Naiten

Recommended Posts

I have an item, and it tends to get lost after i save/load. What's wrong?

package net.obscuracraft.item;

import java.util.Random;

import net.minecraft.client.Minecraft;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemMapBase;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import net.minecraft.world.storage.MapData;
import net.obscuracraft.ObscuraCraft;
import net.obscuracraft.camera.BlockObscura;

public class ItemPhotoEmpty extends ItemMapBase
{
    public ItemPhotoEmpty(int par1){
        super(par1);
        this.setMaxDamage(0);
        this.maxStackSize = 1;
        this.hasSubtypes = true;
        setUnlocalizedName("obscuracraft:positive");
        setCreativeTab(CreativeTabs.tabRedstone);
    }
@Override
public ItemStack onItemRightClick(ItemStack item, World world, EntityPlayer player){
	ItemStack item1 = new ItemStack(ObscuraCraft.iphoto, 1, world.getUniqueDataId("photo"));
	item1.attemptDamageItem(1, new Random());
        String s = "photo_" + item1.getItemDamage();
        MapData mapdata = new MapData(s);
        mapdata.colors = BlockObscura.lastColors;
        world.setItemData(s, mapdata);
        mapdata.markDirty();
        item1.setItemName("Photo #" + item1.getItemDamage());
        item.stackSize--;
        return item1;
    }
}

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites

I have an item, and it tends to get lost after i save/load. What's wrong?

package net.obscuracraft.item;

import java.util.Random;

import net.minecraft.client.Minecraft;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemMapBase;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import net.minecraft.world.storage.MapData;
import net.obscuracraft.ObscuraCraft;
import net.obscuracraft.camera.BlockObscura;

public class ItemPhotoEmpty extends ItemMapBase
{
    public ItemPhotoEmpty(int par1){
        super(par1);
        this.setMaxDamage(0);
        this.maxStackSize = 1;
        this.hasSubtypes = true;
        setUnlocalizedName("obscuracraft:positive");
        setCreativeTab(CreativeTabs.tabRedstone);
    }
@Override
public ItemStack onItemRightClick(ItemStack item, World world, EntityPlayer player){
	ItemStack item1 = new ItemStack(ObscuraCraft.iphoto, 1, world.getUniqueDataId("photo"));
	item1.attemptDamageItem(1, new Random());
        String s = "photo_" + item1.getItemDamage();
        MapData mapdata = new MapData(s);
        mapdata.colors = BlockObscura.lastColors;
        world.setItemData(s, mapdata);
        mapdata.markDirty();
        item1.setItemName("Photo #" + item1.getItemDamage());
        item.stackSize--;
        return item1;
    }
}

 

get lost in which way? Disappearing or data isn't saved or what?

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

I've made several items in this mod and they don't get lost.

Also, as i remember, no spetial registration is needed so far...

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites

Oh, i got it. It's in

mineCraft.thePlayer.inventory.setCurrentItem(ObscuraCraft.icamera.itemID, 0, false, true);

How do i do that in right way?

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites

You should use this instead:

 

    	this.inventory.addItemStackToInventory(YOURITEMSTACKHERE);

 

The code that you're using is designed to change which item a player has 'selected' at the time. The above will actually add it to the inventory. In order to use it, you'll need to create a new ItemStack object using whatever parameters you need. An inventory object only ever takes 'ItemStack' objects into it's slots, not items.

Have a modding question? PM me and hopefully I'll be able to help. Good at 2d Pixel Art? We need your help!  http://www.minecraftforum.net/topic/1806355-looking-for-2d-pixel-artist/

Link to comment
Share on other sites

public class BlockObscura extends BlockContainer{
blablabla;
//called from other place
public static void takePhoto(){
	blablabla;
	Minecraft mineCraft = Minecraft.getMinecraft();
	mineCraft.thePlayer.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));
	//mineCraft.thePlayer.inventory.setCurrentItem(ObscuraCraft.icamera.itemID, 0, false, true);
	blablabla;
}
}

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites

Try replacing

  mineCraft.thePlayer.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));

 

with this instead;

 

player.inventory.addItemStackToInventory(item1);

I /think/ that's what you're looking for. Let me know.

Have a modding question? PM me and hopefully I'll be able to help. Good at 2d Pixel Art? We need your help!  http://www.minecraftforum.net/topic/1806355-looking-for-2d-pixel-artist/

Link to comment
Share on other sites

There's public boolean onItemUse(ItemStack item, EntityPlayer player, World world, int x, int y, int z, int side, float xOffset, float yOffset, float zOffSet)

And i can't use onItemRightClick, because i need clicked block coordinates.

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites

@Override
    public boolean onItemUse(ItemStack item, EntityPlayer player, World world, int x, int y, int z, int side, float xOffset, float yOffset, float zOffSet){
        if (!world.isRemote && item.getItemDamage() == 0){
        	if(world.getBlockId(x, y, z) == ObscuraCraft.camera.blockID){
        		if(world.getBlockMetadata(x, y, z) == 4){
        			y--;
        		}
        		int meta = world.getBlockMetadata(x, y, z);
        		world.setBlockMetadataWithNotify(x, y, z, 4, 0x02);
        		world.setBlockMetadataWithNotify(x, y, z, meta, 0x02);
        		TileEntityObscura tl = (TileEntityObscura)world.getBlockTileEntity(x, y, z);
        		tl.filled = true;
        		BlockObscura.takePhoto(player);
            	if (!player.capabilities.isCreativeMode){--item.stackSize;}
            	player.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));
            	return true;
        	}
	}
        return false;
    }

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites

@Override
    public boolean onItemUse(ItemStack item, EntityPlayer player, World world, int x, int y, int z, int side, float xOffset, float yOffset, float zOffSet){
        if (!world.isRemote && item.getItemDamage() == 0){
        	if(world.getBlockId(x, y, z) == ObscuraCraft.camera.blockID){
        		if(world.getBlockMetadata(x, y, z) == 4){
        			y--;
        		}
        		int meta = world.getBlockMetadata(x, y, z);
        		world.setBlockMetadataWithNotify(x, y, z, 4, 0x02);
        		world.setBlockMetadataWithNotify(x, y, z, meta, 0x02);
        		TileEntityObscura tl = (TileEntityObscura)world.getBlockTileEntity(x, y, z);
        		tl.filled = true;
        		BlockObscura.takePhoto(player);
            	if (!player.capabilities.isCreativeMode){--item.stackSize;}
            	player.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));
            	return true;
        	}
	}
        return false;
    }

 

after

player.inventory.addItemStackToInventory(new ItemStack(ObscuraCraft.icamera));

use this:

player.inventoryContainer.detectAndSendChanges();

 

It sends the changes you made in the players inventory on the server to the client.

 

Also you should define a quantity in your ItemStack like this: new ItemStack(ObscuraCraft.icamera, 1)

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

use this:

player.inventoryContainer.detectAndSendChanges();

It sends the changes you made in the players inventory on the server to the client.

Also you should define a quantity in your ItemStack like this: new ItemStack(ObscuraCraft.icamera, 1)

Thanks.

And, i actually should not. ItemStack has a constructor without quantity that automatically sets it to 1.

If i helped you, don't forget pressing "Thank You" button. Thanks for your time.

Link to comment
Share on other sites

use this:

player.inventoryContainer.detectAndSendChanges();

It sends the changes you made in the players inventory on the server to the client.

Also you should define a quantity in your ItemStack like this: new ItemStack(ObscuraCraft.icamera, 1)

Thanks.

And, i actually should not. ItemStack has a constructor without quantity that automatically sets it to 1.

 

Oh, didn't know that. Well then not :P

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.