Jump to content

[1.14] Right-clicking mod block with off-hand


chirptheboy

Recommended Posts

When I right-click my mod block with torches in my off-hand, it tries to place the torch on the block--briefly emitting light--then consumes the torch (count decreases by one), and finally still opens up the GUI. Then, if I exit to the menu and then return, I have all my torches back.

 

When right-clicking my mod block with any placeable block, the animation of placing the block appears before opening the GUI. These blocks remain in the hotbar when this happens.

 

Instead of pasting huge codeblocks--unless that is preferable--here are links to my code:

 

Any and all help is appreciated!

Link to comment
Share on other sites

Take a look at your disenchanter block class:

@Override
public boolean onBlockActivated(BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, BlockRayTraceResult result) {
  if (!world.isRemote) {
    TileEntity tileEntity = world.getTileEntity(pos);
    if (tileEntity instanceof INamedContainerProvider){
       NetworkHooks.openGui((ServerPlayerEntity) player, (INamedContainerProvider) tileEntity, tileEntity.getPos());
    } else {
       throw new IllegalStateException("Our named container provider is missing.");
    }
    return true;
  }
  return super.onBlockActivated(state, world, pos, player, hand, result);
}

If you follow the control flow, the client-side block will always return super.onBlockActivated(state, world, pos, player, hand, result);

The effects you are describing seem to be caused by the client and server following different paths here, the server returning true after opening the gui, and the client returning super.onBlockActivated, which I'm pretty sure defaults to false.

  • Like 2

Have you ever want the new operator to return a type that you didn't ask for? Well, now you can!

Link to comment
Share on other sites

Thanks for the info, I'll take a look into that.

 

Edit: I made modifications to that method since there were items that should have fired independently of which world it was in.

 

@Override
    public boolean onBlockActivated(BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, BlockRayTraceResult result) {
        TileEntity tileEntity = world.getTileEntity(pos);
            if (tileEntity instanceof INamedContainerProvider){
                if (!world.isRemote) {
                    NetworkHooks.openGui((ServerPlayerEntity) player, (INamedContainerProvider) tileEntity, tileEntity.getPos());
                }
            } else {
                throw new IllegalStateException("Our named container provider is missing.");
            }
            return true;
        //return super.onBlockActivated(state, world, pos, player, hand, result);
    }

 

Edited by chirptheboy
Added fix
Link to comment
Share on other sites

On 1/22/2020 at 1:47 AM, chirptheboy said:

I made modifications to that method since there were items that should have fired independently of which world it was in.

Um... You still only do stuff on the server.

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.