Jump to content

Override error in custom entity


Flub_Tubs

Recommended Posts

I created a custom entity model with Tabula and updated it to 1.14 but at the bottom of the code there's an error stating 

"The method render(Entity, float, float, float, float, float, float) of type BreadlingModel must override or implement a supertype method"

the provided solution is to remove the @Override from the code, but doing this results in the error

"Name clash: The method render(Entity, float, float, float, float, float, float) of type BreadlingModel has the same erasure as render(T, float, float, float, float, float, float) of type EntityModel<T> but does not override it"

I've looked everywhere but no solution I've found has worked. what should I do? 

package twat.entities.models;

import net.minecraft.client.renderer.entity.model.EntityModel;
import net.minecraft.client.renderer.entity.model.RendererModel;
import net.minecraft.entity.CreatureEntity;
import net.minecraft.entity.Entity;

/**
 * Breadling - twat
 * Created using Tabula 7.1.0
 */
public class BreadlingModel extends EntityModel<CreatureEntity> {
    public RendererModel Leg_L_1;
    public RendererModel Leg_L_2;
    public RendererModel Leg_L_3;
    public RendererModel Leg_R_1;
    public RendererModel Leg_R_2;
    public RendererModel Leg_R_3;
    public RendererModel body_main;
    public RendererModel body_top;

    public BreadlingModel() {
        this.textureWidth = 47;
        this.textureHeight = 24;
        this.Leg_L_2 = new RendererModel(this, 0, 0);
        this.Leg_L_2.setRotationPoint(0.0F, 22.0F, 2.5F);
        this.Leg_L_2.addBox(-0.5F, 0.0F, -0.5F, 1, 2, 1, 0.0F);
        this.Leg_R_1 = new RendererModel(this, 0, 0);
        this.Leg_R_1.setRotationPoint(2.5F, 22.0F, -2.5F);
        this.Leg_R_1.addBox(-0.5F, 0.0F, -0.5F, 1, 2, 1, 0.0F);
        this.Leg_L_1 = new RendererModel(this, 0, 0);
        this.Leg_L_1.setRotationPoint(2.5F, 22.0F, 2.5F);
        this.Leg_L_1.addBox(-0.5F, 0.0F, -0.5F, 1, 2, 1, 0.0F);
        this.body_top = new RendererModel(this, 0, 13);
        this.body_top.setRotationPoint(0.0F, -2.0F, -0.5F);
        this.body_top.addBox(-4.0F, 0.0F, -3.0F, 8, 3, 8, 0.0F);
        this.Leg_R_3 = new RendererModel(this, 0, 0);
        this.Leg_R_3.setRotationPoint(-2.5F, 22.0F, -2.5F);
        this.Leg_R_3.addBox(-0.5F, 0.0F, -0.5F, 1, 2, 1, 0.0F);
        this.body_main = new RendererModel(this, 17, 0);
        this.body_main.setRotationPoint(0.0F, 17.1F, -0.5F);
        this.body_main.addBox(-4.0F, 0.0F, -3.0F, 8, 5, 7, 0.0F);
        this.Leg_L_3 = new RendererModel(this, 0, 0);
        this.Leg_L_3.setRotationPoint(-2.5F, 22.0F, 2.5F);
        this.Leg_L_3.addBox(-0.5F, 0.0F, -0.5F, 1, 2, 1, 0.0F);
        this.Leg_R_2 = new RendererModel(this, 0, 0);
        this.Leg_R_2.setRotationPoint(0.0F, 22.0F, -2.5F);
        this.Leg_R_2.addBox(-0.5F, 0.0F, -0.5F, 1, 2, 1, 0.0F);
        this.body_main.addChild(this.body_top);
    }

    @Overide
    public void render(Entity entity, float f, float f1, float f2, float f3, float f4, float f5) { 
        this.Leg_L_2.render(f5);
        this.Leg_R_1.render(f5);
        this.Leg_L_1.render(f5);
        this.Leg_R_3.render(f5);
        this.body_main.render(f5);
        this.Leg_L_3.render(f5);
        this.Leg_R_2.render(f5);
    }

    /**
     * This is a helper function from Tabula to set the rotation of model parts
     */
    public void setRotateAngle(RendererModel modelRenderer, float x, float y, float z) {
        modelRenderer.rotateAngleX = x;
        modelRenderer.rotateAngleY = y;
        modelRenderer.rotateAngleZ = z;
    }
}
Link to comment
Share on other sites

6 hours ago, diesieben07 said:

look at the actual superclass you are extending and the method you are trying to override and it should be obvious what needs to be done.

I've looked everywhere but i cant find the superclass. Any ideas where i should look?

 

P.S i know what overriding does, both by knowing the meaning of the word, and it being the first thing i looked up when i was having these issues.

Edited by Flub_Tubs
Link to comment
Share on other sites

12 hours ago, Flub_Tubs said:

extends EntityModel<CreatureEntity>

That is your superclass...

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

20 minutes ago, Cadiboo said:

That is your superclass...

oh, okay, so i'm assuming I've made an error with that. What should it be?

 

 

I've changed it to the name of my creature but i'm still getting the errors.

 

Edited by Flub_Tubs
Link to comment
Share on other sites

13 hours ago, Flub_Tubs said:

public void render(Entity entity, float f, float f1, float f2, float f3, float f4, float f5) {

Problem with this line.

Hint: the type of the first parameter is wrong. Check the render method in the superclass.

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

I'm not sure what the exact error is, but since rendering and entities have changed since tabula was made I assume you've got a small issue to do with an incorrect override. You'll want to use your IDE to automatically generate overrides for you.

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

Fine then. Replace

16 hours ago, Flub_Tubs said:

public void render(Entity entity, float f, float f1, float f2, float f3, float f4, float f5) {

with

public void render(Breadling entity, float f, float f1, float f2, float f3, float f4, float f5) {

.

The signature (parameters, etc) of the overriding method must match the method it is overriding.

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

package twat.entities.models;

import net.minecraft.client.renderer.entity.model.EntityModel;
import net.minecraft.client.renderer.entity.model.RendererModel;
import net.minecraft.client.renderer.model.ModelBox;
import net.minecraft.entity.Entity;
import twat.entities.Breadling;

public class BreadlingModelClass extends EntityModel<Breadling> {
	private final RendererModel bb_main;

	public BreadlingModelClass() {
		textureWidth = 32;
		textureHeight = 24;

		bb_main = new RendererModel(this);
		bb_main.setRotationPoint(0.0F, 24.0F, 0.0F);
		
		//legs
		
		bb_main.cubeList.add(new ModelBox(bb_main, 0, 0, -3.0F, -2.0F, 2.0F, 1, 2, 1, 0.0F, false));
		bb_main.cubeList.add(new ModelBox(bb_main, 0, 0, -3.0F, -2.0F, -0.5F, 1, 2, 1, 0.0F, false));
		bb_main.cubeList.add(new ModelBox(bb_main, 0, 0, -3.0F, -2.0F, -3.0F, 1, 2, 1, 0.0F, false));
		bb_main.cubeList.add(new ModelBox(bb_main, 0, 0, 2.0F, -2.0F, -3.0F, 1, 2, 1, 0.0F, false));
		bb_main.cubeList.add(new ModelBox(bb_main, 0, 0, 2.0F, -2.0F, -0.5F, 1, 2, 1, 0.0F, false));
		bb_main.cubeList.add(new ModelBox(bb_main, 0, 0, 2.0F, -2.0F, 2.0F, 1, 2, 1, 0.0F, false));
		
		//body
		
		bb_main.cubeList.add(new ModelBox(bb_main, 0, 0, -3.5F, -6.5F, -4.0F, 7, 5, 8, 0.0F, false));
		bb_main.cubeList.add(new ModelBox(bb_main, 0, 13, -4.0F, -8.5F, -4.0F, 8, 3, 8, 0.0F, false));
	}

	
	@Override
	public void render(Breadling entity, float f, float f1, float f2, float f3, float f4, float f5) {
		bb_main.render(f5);
	};
	
	public void setRotationAngle(RendererModel RendererModel, float x, float y, float z) {
		RendererModel.rotateAngleX = x;
		RendererModel.rotateAngleY = y;
		RendererModel.rotateAngleZ = z;
	}
}

i tweaked the model a bit but everything else is the same

Link to comment
Share on other sites

package twat.client.render;

import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.api.distmarker.OnlyIn;
import net.minecraftforge.fml.client.registry.RenderingRegistry;
import twat.entities.Breadling;


@OnlyIn(Dist.CLIENT)
public class RenderRegistry {

	public static void registryEntityRenders()
	{
		RenderingRegistry.registerEntityRenderingHandler(Breadling.class, new BreadlingRender.RenderFactory());
	}
	
}
package twat.client.models;

import net.minecraft.client.renderer.entity.model.EntityModel;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.api.distmarker.OnlyIn;
import twat.entities.Breadling;


@OnlyIn(Dist.CLIENT)
public class BreadlingModel extends EntityModel<Breadling>{

	
}
package twat.client.render;

import net.minecraft.client.renderer.entity.EntityRenderer;
import net.minecraft.client.renderer.entity.EntityRendererManager;
import net.minecraft.client.renderer.entity.LivingRenderer;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.api.distmarker.OnlyIn;
import net.minecraftforge.fml.client.registry.IRenderFactory;
import twat.client.models.BreadlingModel;
import twat.entities.Breadling;


@OnlyIn(Dist.CLIENT)

public class BreadlingRender extends LivingRenderer<Breadling, BreadlingModel>
{

	public BreadlingRender(EntityRendererManager manager)
	{
		super(manager, new BreadlingModel(), 0f);
	}

	@Override
	protected ResourceLocation getEntityTexture(Breadling entity) {
		return new ResourceLocation("breadplus","textures/entity/breadling.png");
	}

	public static class RenderFactory implements IRenderFactory<Breadling>{

		@Override
		public EntityRenderer<? super Breadling> createRenderFor(EntityRendererManager manager) {
			return new BreadlingRender(manager);
		}
	}
}
package twat.entities;

import net.minecraft.entity.CreatureEntity;
import net.minecraft.entity.EntityType;
import net.minecraft.entity.SharedMonsterAttributes;
import net.minecraft.entity.ai.goal.JumpGoal;
import net.minecraft.entity.ai.goal.LookRandomlyGoal;
import net.minecraft.entity.ai.goal.SwimGoal;
import net.minecraft.entity.ai.goal.WaterAvoidingRandomWalkingGoal;
import net.minecraft.world.World;
import twat.lists.EntityList;

public class Breadling extends CreatureEntity {

	@SuppressWarnings("unchecked")
	public Breadling(EntityType<? extends CreatureEntity> p_i48575_1_, World p_i48575_2_) {
		super((EntityType<? extends CreatureEntity>) EntityList.breadling, p_i48575_2_);
	}
	
	@Override
	protected void registerGoals() {
		// TODO Auto-generated method stub
		this.goalSelector.addGoal(0, new SwimGoal(this));
		//this.goalSelector.addGoal(1, new BreedGoal(this, ));
		this.goalSelector.addGoal(1, new WaterAvoidingRandomWalkingGoal(this, 1.2d));
		this.goalSelector.addGoal(3, new LookRandomlyGoal(this));
		this.goalSelector.addGoal(4, new JumpGoal() {
			
			@Override
			public boolean shouldExecute() {
				
				return false;
			}
		});
	
	//	this.goalSelector.addGoal(5, new TargetGoal(null, canPickUpLoot) {
	//		
	//		@Override
	//		public boolean shouldExecute() {
	//			
	//			return false;
	//		}
	//	});

			

	}
	
	
	@Override
	protected void registerAttributes() {

		super.registerAttributes();
		this.getAttribute(SharedMonsterAttributes.MAX_HEALTH).setBaseValue(2.0d);
		this.getAttribute(SharedMonsterAttributes.MOVEMENT_SPEED).setBaseValue(1.0d);
		this.getAttribute(SharedMonsterAttributes.FOLLOW_RANGE).setBaseValue(15.0d);
	
	
	}

}

i added all code relating to the entity

Edited by Flub_Tubs
adding more code
Link to comment
Share on other sites

4 minutes ago, diesieben07 said:

Where / When is this called?

package twat.breadmod;

import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.entity.EntityType;
import net.minecraft.item.BlockItem;
import net.minecraft.item.Item;
import net.minecraft.item.ItemGroup;
import net.minecraft.util.ResourceLocation;
import net.minecraft.world.WorldType;
import net.minecraft.world.biome.Biome;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent;
import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent;
import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;
import twat.client.render.RenderRegistry;
import twat.lists.BlockList;
import twat.lists.BreadBiomes;
import twat.lists.EntityList;
import twat.lists.FoodList;
import twat.lists.ItemList;
import twat.world.biomes.BreadBiome;
import twat.world.biomes.BreadWorldType;



@Mod("breadplus")
public class main {
	
	public static main instance;
	public static final String modid = "breadplus";
	private static final Logger logger = LogManager.getLogger(modid);
	public static final ItemGroup bread = new BreadItemGroup();
	public static final WorldType bread_world = new BreadWorldType();
	
	public main() {
		
		instance = this;
		
		FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setup);
		FMLJavaModLoadingContext.get().getModEventBus().addListener(this::clientRegistries);
		
		MinecraftForge.EVENT_BUS.register(this);
	}
	
	
	
	private void setup(final FMLCommonSetupEvent event) {

	}
	
	private void clientRegistries(final FMLClientSetupEvent event) {

		RenderRegistry.registryEntityRenders();                                                     // <-------Here-------------
		
	}
	@Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
	public static class RegistryEvents {
		
		@SubscribeEvent
		public static void registerItems(final RegistryEvent.Register<Item> event) {
			
			event.getRegistry().registerAll
			(
					
					
					ItemList.bread_ball = new Item(new Item.Properties().group(bread).food(FoodList.breadFood)).setRegistryName(location("bread_ball")),
					
					ItemList.test_block = new BlockItem(BlockList.test_block, new Item.Properties().group(bread)).setRegistryName(BlockList.test_block.getRegistryName()),
					ItemList.bread_portal_frame = new BlockItem(BlockList.bread_portal_frame, new Item.Properties().group(bread)).setRegistryName(BlockList.bread_portal_frame.getRegistryName()),
			
					ItemList.bread_dirt = new BlockItem(BlockList.bread_dirt, new Item.Properties().group(bread)).setRegistryName(BlockList.bread_dirt.getRegistryName()),
					ItemList.bread_grass = new BlockItem(BlockList.bread_grass, new Item.Properties().group(bread)).setRegistryName(BlockList.bread_grass.getRegistryName()),
					ItemList.bread_leaves = new BlockItem(BlockList.bread_leaves, new Item.Properties().group(bread)).setRegistryName(BlockList.bread_leaves.getRegistryName()),
					ItemList.bread_log = new BlockItem(BlockList.bread_log, new Item.Properties().group(bread)).setRegistryName(BlockList.bread_log.getRegistryName()),
					ItemList.bread_planks = new BlockItem(BlockList.bread_planks, new Item.Properties().group(bread)).setRegistryName(BlockList.bread_planks.getRegistryName()),
					ItemList.bread_stone = new BlockItem(BlockList.bread_stone, new Item.Properties().group(bread)).setRegistryName(BlockList.bread_stone.getRegistryName())

					
			);
			
			EntityList.registerEntitySpawnEggs(event);
			
			logger.info("blocks registered");
		}
		
		private static ResourceLocation location(String name) {
			return new ResourceLocation(modid, name);
		}
		
		@SubscribeEvent
		public static void registerBlocks(final RegistryEvent.Register<Block> event) {
			
			event.getRegistry().registerAll
			(
					BlockList.test_block = new Block(Block.Properties.create(Material.WOOD).hardnessAndResistance(2.0f, 1.5f).sound(SoundType.SNOW)).setRegistryName(location("test_block")),
					BlockList.bread_portal_frame = new Block(Block.Properties.create(Material.IRON).hardnessAndResistance(2.0f, 1.5f).sound(SoundType.STONE)).setRegistryName(location("bread_portal_frame")),

					BlockList.bread_dirt = new Block(Block.Properties.create(Material.EARTH).hardnessAndResistance(2.0f, 1.5f).sound(SoundType.SNOW)).setRegistryName(location("bread_dirt")),
					BlockList.bread_grass = new Block(Block.Properties.create(Material.GLASS).hardnessAndResistance(2.0f, 1.5f).sound(SoundType.SNOW)).setRegistryName(location("bread_grass")),
					BlockList.bread_leaves = new Block(Block.Properties.create(Material.LEAVES).variableOpacity().hardnessAndResistance(2.0f, 1.5f).sound(SoundType.SNOW)).setRegistryName(location("bread_leaves")),
					BlockList.bread_log = new Block(Block.Properties.create(Material.WOOD).hardnessAndResistance(2.0f, 1.5f).sound(SoundType.SNOW)).setRegistryName(location("bread_log")),
					BlockList.bread_planks = new Block(Block.Properties.create(Material.WOOD).hardnessAndResistance(2.0f, 1.5f).sound(SoundType.SNOW)).setRegistryName(location("bread_planks")),
					BlockList.bread_stone = new Block(Block.Properties.create(Material.ROCK).hardnessAndResistance(2.0f, 1.5f).sound(SoundType.SNOW)).setRegistryName(location("bread_stone"))

					
			);
			
			
			
			
			
		}
		

		@SubscribeEvent
		public static void registerEntities(final RegistryEvent.Register<EntityType<?>> event) {

			event.getRegistry().registerAll
			(
				EntityList.breadling	
			);
			
			EntityList.registerEntityWorldSpawn();
		}
		
		@SubscribeEvent
		public static void registerBiomes(final RegistryEvent.Register<Biome> event) {
			
			
			event.getRegistry().registerAll
			(
					
					BreadBiomes.bread_plains = new BreadBiome()
			);
			
			BreadBiomes.registerBiomes();
			
		}
		
		
		
	}
	
}

in my main file (line 61)

Edited by Flub_Tubs
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.