Jump to content
Currently supported: All versions

Registering NoteBlockInstruments to Blockstates

TheOnlyTrueEnte

By TheOnlyTrueEnte
in Suggestions

 Share

Recommended Posts

TheOnlyTrueEnte Tree Puncher

TheOnlyTrueEnte

Posted
Posted (edited)

NoteBlock updates its INSTRUMENT property by calling NoteBlockInstrument#byState.

This method is completely hardcoded. It would be nice if it instead did a lookup on a Map that modders can register their blocks to, for example.

 

Currently, if you want your modded block to serve as a specific NoteBlockInstrument you have to intercept a NoteBlockEvent.Play and change its instrument there.

This event is only fired when the NoteBlock is actually played and does not update the INSTRUMENT property. This sucks especially if you're using a resource pack to display the NoteBlock's instrument.

Edited by TheOnlyTrueEnte
better issue clarification
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept