Jump to content

[1.14.4]world.getTileEntity() doesn't work correctly


Yurim64

Recommended Posts

Hi guys, i don't understand why but when i use world.getTileEntity(pos) on a position in which there is a TileEntity setted with world.setTileEntity(pos, entity), it returns me null even if, using debug, the TileEntity exists in the List of the Client and Server World.

I leave the class of the block in which I use the two methods.

 

package com.yurim.alotofthings.block;

import com.yurim.alotofthings.tileentity.LumberjackTileEntity;
import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.Blocks;
import net.minecraft.block.material.Material;
import net.minecraft.entity.LivingEntity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.entity.player.ServerPlayerEntity;
import net.minecraft.inventory.container.INamedContainerProvider;
import net.minecraft.item.ItemStack;
import net.minecraft.state.StateContainer;
import net.minecraft.state.properties.BlockStateProperties;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.Direction;
import net.minecraft.util.Hand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.BlockRayTraceResult;
import net.minecraft.world.World;
import net.minecraftforge.fml.network.NetworkHooks;

import javax.annotation.Nullable;

/**
 * @author Yurim
 * @version 1.0A
 **/
@SuppressWarnings("NullableProblems")
public class Lumberjack extends Block {

    public Lumberjack() {
        super(net.minecraft.block.Block.Properties.create(Material.IRON).hardnessAndResistance(2.0f));
    }


    @Override
    public boolean onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit) {
        if (!worldIn.isRemote) {
            TileEntity entity = worldIn.getTileEntity(pos);
            if (entity instanceof LumberjackTileEntity && entity.getPos().equals(pos)) {
                NetworkHooks.openGui((ServerPlayerEntity) player, (INamedContainerProvider) entity, entity.getPos());
                return true;
            }
        }
        return false;
    }

    @Override
    public void onBlockPlacedBy(World world, BlockPos pos, BlockState state, @Nullable LivingEntity entity, ItemStack stack) {
        if (entity != null) {
            Direction direction = getFacingFromEntity(pos, entity);
            world.setBlockState(pos, state.with(BlockStateProperties.FACING, direction), 2);
            world.setTileEntity(pos, new LumberjackTileEntity(direction, pos));
        }
    }

    private static Direction getFacingFromEntity(BlockPos clickedBlock, LivingEntity entity) {
        return Direction.getFacingFromVector((float) (entity.posX - clickedBlock.getX()), (float) (entity.posY - clickedBlock.getY()), (float) (entity.posZ - clickedBlock.getZ()));
    }

    @Override
    protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) {
        super.fillStateContainer(builder);
        builder.add(BlockStateProperties.FACING);
    }

    @Override
    public void onBlockHarvested(World worldIn, BlockPos pos, BlockState state, PlayerEntity player) {
        TileEntity e = worldIn.getTileEntity(pos);
        if (e instanceof LumberjackTileEntity) {
            ((LumberjackTileEntity) e).dropToWorld(worldIn, pos);
        }
        super.onBlockHarvested(worldIn, pos, state, player);
    }

}

 

Link to comment
Share on other sites

13 minutes ago, Yurim64 said:

world.setTileEntity(pos, new LumberjackTileEntity(direction, pos));

You can't just do this. Override hasTileEntity and CreateTileEntity in your block class.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

23 minutes ago, Draco18s said:

You can't just do this. Override hasTileEntity and CreateTileEntity in your block class.

yes, but if I do this then I have another problem I was trying to solve. I cannot pass the block direction to TileEntity in the CreateTileEntity method, because the onBlockPlacedBy method, in which I also set the direction, is called later.

Any suggestions?

Edited by Yurim64
Link to comment
Share on other sites

You don't need to. The TileEntity can query the blockstate of its own position any time it wants.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.