Jump to content

Efficiency of Event Handlers


Lea9ue

Recommended Posts

I have a general question in regards to how I am formatting my code with event handlers. Is there a benefit with efficiency (lag) between 1 event handler checking and doing multiple things vs many of the same event handlers checking for 1 thing.  I give two 2 rough examples:

 

Example1:

@SubscribeEvent
public void creeperCheck(LivingDeath event){
	if(event.getEntity instanceof CreeperEntity){
		...
	}
}	

@SubscribeEvent
public void zombieCheck(LivingDeath event){
	if(event.getEntity instanceof ZombieEntity){
		...
	}
}

@SubscribeEvent
public void skeletonCheck(LivingDeath event){
	if(event.getEntity instanceof SkeletonEntity){
		...
	}
}

 

Vs

Example 2:

@Subscribe

@SubscribeEvent
public void deathCheck(LivingDeathEvent event){
	if(event.getEntity instanceof CreeperEntity){
		...
	}
	if(event.getEntity instanceof ZombieEntity){
		...
	}
	if(event.getEntity instanceof SkeletonEntity){
		...	
	}
}

 

 

Link to comment
Share on other sites

Use one function and multiple if...else if..else statements.

 

The difference between your examples is this:

 

Which is faster?
 

creeperCheck();
zombieCheck();
skeletonCheck();

 

or (a properly built, using else)

 

deathCheck();

 

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.