[1.14.4] [SOLVED] Gui Slots Behave Weird

[StefanDeSterke 0]

Hi, I have this weird bug where I can't move items properly around in my custom Gui. I'm trying to create a Gui with a container without the block being used being a TileEntity. Something like a crafting table. However, as I just said, I can't move the inventory items properly around. Here's a video of me trying to do something in the  gui:

 

 

Container Class:

package mod.sds.terrariamod.containers;

import org.apache.logging.log4j.LogManager;

import mod.sds.terrariamod.TerrariaMod;
import mod.sds.terrariamod.containers.slots.ResultSlot;
import mod.sds.terrariamod.inventories.FurnaceInventory;
import mod.sds.terrariamod.lists.BlockList;
import mod.sds.terrariamod.lists.ContainerList;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.entity.player.PlayerInventory;
import net.minecraft.inventory.container.ClickType;
import net.minecraft.inventory.container.Container;
import net.minecraft.inventory.container.Slot;
import net.minecraft.item.ItemStack;
import net.minecraft.util.IWorldPosCallable;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class ContainerFurnace extends Container
{
	
	private final FurnaceInventory inventory;
	private final World world;
	private final BlockPos blockPos;

	public ContainerFurnace(int id, PlayerInventory playerInv, World worldIn, BlockPos pos) 
	{
		super(ContainerList.furnace, id);
		
		this.inventory = new FurnaceInventory(this);
		this.world = worldIn;
		this.blockPos = pos;
		
		this.addSlot(new Slot(this.inventory, 30, 39, 35));
		this.addSlot(new Slot(this.inventory, 31, 57, 35));
		this.addSlot(new ResultSlot(this.inventory, 32, 124, 35));
		
        for (int i = 0; i < 3; i++) {
            for (int j = 0; j < 9; j++) {
                this.addSlot(new Slot(playerInv, j + i * 9 + 9, 8 + j * 18, 84 + i * 18));
            }
        }
        for (int i = 0; i < 9; i++) {
            this.addSlot(new Slot(playerInv, i, 8 + i * 18, 142));
        }
	}
	
	@Override
	public ItemStack slotClick(int slotId, int dragType, ClickType clickTypeIn, PlayerEntity player) {
		
		LogManager.getLogger(TerrariaMod.modid).info("Slot: " + slotId + ", Item: " + this.getSlot(slotId).getStack().getItem().getName());
		
		System.out.println("Slot: " + slotId + ", Item: " + this.getSlot(slotId).getStack().getItem().getName());
		
		return super.slotClick(slotId, dragType, clickTypeIn, player);
	}
	
	
    @Override
    public ItemStack transferStackInSlot(final PlayerEntity player, final int fromSlot) {
        ItemStack item = ItemStack.EMPTY;
        final Slot fromSlotS = this.inventorySlots.get(fromSlot);
        if (fromSlotS != null && fromSlotS.getHasStack()) {
            final ItemStack fromSlotItem = fromSlotS.getStack();
            item = fromSlotItem.copy();
            if (fromSlot == 0) {
                IWorldPosCallable.of(this.world, this.blockPos).consume((p_217067_2_, p_217067_3_) -> fromSlotItem.getItem().onCreated(fromSlotItem, p_217067_2_, player));
                if (!this.mergeItemStack(fromSlotItem, 10, 46, true)) {
                    return ItemStack.EMPTY;
                }
                fromSlotS.onSlotChange(fromSlotItem, item);
            }
            else if (fromSlot >= 10 && fromSlot < 37) {
                if (!this.mergeItemStack(fromSlotItem, 37, 46, false)) {
                    return ItemStack.EMPTY;
                }
            }
            else if (fromSlot >= 37 && fromSlot < 46) {
                if (!this.mergeItemStack(fromSlotItem, 10, 37, false)) {
                    return ItemStack.EMPTY;
                }
            }
            else if (!this.mergeItemStack(fromSlotItem, 10, 46, false)) {
                return ItemStack.EMPTY;
            }
            if (fromSlotItem.isEmpty()) {
                fromSlotS.putStack(ItemStack.EMPTY);
            }
            else {
                fromSlotS.onSlotChanged();
            }
            if (fromSlotItem.getCount() == item.getCount()) {
                return ItemStack.EMPTY;
            }
            final ItemStack dropItem = fromSlotS.onTake(player, fromSlotItem);
            if (fromSlot == 0) {
                player.dropItem(dropItem, false);
            }
        }
        return item;
    }
    
    
	
	@Override
	public void onContainerClosed(PlayerEntity playerIn) {
		super.onContainerClosed(playerIn);
		
		IWorldPosCallable.of(this.world, this.blockPos).consume((world, blockPos) -> this.clearContainer(playerIn, world, this.inventory));
	}
	
	

	@Override
	public boolean canInteractWith(PlayerEntity playerIn) 
	{
		return isWithinUsableDistance(IWorldPosCallable.of(world, blockPos), playerIn, BlockList.stone_furnace);
	}


	
	
}

 

Gui Class:

package mod.sds.terrariamod.guis;

import com.mojang.blaze3d.platform.GlStateManager;

import mod.sds.terrariamod.TerrariaMod;
import mod.sds.terrariamod.containers.ContainerFurnace;
import net.minecraft.client.gui.screen.inventory.ContainerScreen;
import net.minecraft.entity.player.PlayerInventory;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.text.ITextComponent;

public class StoneFurnaceGUI extends ContainerScreen<ContainerFurnace>
{

	private static final ResourceLocation TEXTURES = new ResourceLocation(TerrariaMod.modid, "textures/gui/container/furnace.png");
	@SuppressWarnings("unused")
	private ContainerFurnace container;
	
	
	public StoneFurnaceGUI(ContainerFurnace screenContainer, PlayerInventory inv, ITextComponent titleIn) 
	{
		super(screenContainer, inv, titleIn);

		this.container = screenContainer;
	}

	@Override
	public void render(int p_render_1_, int p_render_2_, float p_render_3_) {
		this.renderBackground();
        super.render(p_render_1_, p_render_2_, p_render_3_);
        this.renderHoveredToolTip(p_render_1_, p_render_2_);
	}
	
	@Override
	protected void drawGuiContainerForegroundLayer(int mouseX, int mouseY) {
		super.drawGuiContainerForegroundLayer(mouseX, mouseY);
	}
	
	@Override
	protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) 
	{
		
		GlStateManager.color4f(1f, 1f, 1f, 1f);
		this.getMinecraft().getTextureManager().bindTexture(TEXTURES);
        final int width = this.guiLeft;
        final int height = (this.height - this.ySize) / 2;
        this.blit(width, height, 0, 0, this.xSize, this.ySize);
        
		
	}

	
	
	
}

 

[diesieben07 6671]

• Do not use IInventory. Use IItemHandler resp. it's default implementation ItemStackHandler.
• Show where you open the GUI.

[StefanDeSterke 0]

Changed Container Class:

	private final IItemHandler inventory;
	private final World world;
	private final BlockPos blockPos;

	public ContainerFurnace(int id, PlayerInventory playerInv, World worldIn, BlockPos pos) 
	{
		super(ContainerList.furnace, id);
		
		this.inventory = new ItemStackHandler(3);
		this.world = worldIn;
		this.blockPos = pos;
		
		this.addSlot(new SlotItemHandler(this.inventory, 0, 39, 35));
		this.addSlot(new SlotItemHandler(this.inventory, 1, 57, 35));
		this.addSlot(new SlotItemHandler(this.inventory, 2, 124, 35));
		
        for (int i = 0; i < 3; i++) {
            for (int j = 0; j < 9; j++) {
                this.addSlot(new Slot(playerInv, j + i * 9 + 9, 8 + j * 18, 84 + i * 18));
            }
        }
        for (int i = 0; i < 9; i++) {
            this.addSlot(new Slot(playerInv, i, 8 + i * 18, 142));
        }
	}

 

I open the GUI in my custom Stone Furnace Class in the onBlockActivated method:

	@SuppressWarnings("deprecation")
	@Override
	public boolean onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit) 
	{	

		Minecraft.getInstance().displayGuiScreen(new StoneFurnaceGUI(new ContainerFurnace(guiId, player.inventory, worldIn, pos), player.inventory, new StringTextComponent("Stone Furnace")));
		
		return super.onBlockActivated(state, worldIn, pos, player, handIn, hit);
	}

 

[Draco18s 2090]

5 minutes ago, StefanDeSterke said:

Minecraft.getInstance().displayGuiScreen

This is not how you open GUIs.

[diesieben07 6671]

1 minute ago, Draco18s said:

This is not how you open GUIs.

This is not how you open container GUIs.

[StefanDeSterke 0]

I kind of know, but then I need to use NetworkHooks.openGui(), and I need an INamedContainerProvider, and I don't know how to use that and where to implement that.

[Draco18s 2090]

9 minutes ago, diesieben07 said:

This is not how you open container GUIs.

Yes, that is valid. But my point was that's not how (generic) you do the thing (generic) you are trying to do right now.

 

4 minutes ago, StefanDeSterke said:

I kind of know, but then I need to use NetworkHooks.openGui(), and I need an INamedContainerProvider, and I don't know how to use that and where to implement that.

 

Which I found by searching this (which is in a banner at the top of every page here on the forums) for "container"

[StefanDeSterke 0]

Ok, but since I don't have a tileentity class, where would I implement INamedContainerProvider? (I don't have one because I don't need to store inv data to the block)

[desht 73]

2 minutes ago, StefanDeSterke said:

Ok, but since I don't have a tileentity class, where would I implement INamedContainerProvider? (I don't have one because I don't need to store inv data to the block)

Er, what are those slots in your GUI in your very first post for, if not for displaying your block's inventory?  You need a tile entity and there is absolutely no way around that.

Edited November 19 by desht

[StefanDeSterke 0]

1 minute ago, desht said:

Er, what are those slots in your GUI in very first post for, if not for displaying your block's inventory?  You need a tile entity and there is absolutely no way around that.

I want to create an empty container when you open the block (Like a crafting table). When you close out of the inventory, then all the items that are in the slots of the furnace will pop back into your inventory,

[diesieben07 6671]

10 minutes ago, StefanDeSterke said:

where would I implement INamedContainerProvider?

Wherever you want. It's an interface. You can even use an anonymous class if you want.

[desht 73]

17 minutes ago, StefanDeSterke said:

I want to create an empty container when you open the block (Like a crafting table). When you close out of the inventory, then all the items that are in the slots of the furnace will pop back into your inventory,

Ah, ok.  What diesieben said, then

[StefanDeSterke 0]

Ok thank you, but now I'm getting this error when I'm opening the Furnace:

 

java.lang.UnsupportedOperationException: Unable to construct this menu by type

 

I think it has to do with the container type registration not being correct, so here's the code for that:

		@SubscribeEvent
		public static void onContainerRegistry(final RegistryEvent.Register<ContainerType<?>> event) 
        	{
			event.getRegistry().registerAll(
					
					IForgeContainerType.create((windowId, inv, data) -> {
						
						BlockPos pos = data.readBlockPos();
						return new ContainerFurnace(windowId, inv, TerrariaMod.proxy.getClientWorld(), pos);
						
					}).setRegistryName("container_furnace")
					
					
					);
		}

 

[diesieben07 6671]

You need to not only register the ContainerType, but you also need to register a screen factory (ScreenManager.registerFactory, this must happen through DeferredWorkQueue from FMLClientSetupEvent).

Also ensure you pass the correct ContainerType to the Container constructor.

 

Then you open the GUI through NetworkHooks.openGui on the server.

[StefanDeSterke 0]

What do I have to put as second argument in ScreenManager.registerFactory? It's asking me to put an IScreenFactory in there.

[diesieben07 6671]

You have to provide an implementation of IScreenFactory which is used to create the GuiContainer for your Container on the client.

[Draco18s 2090]

As an example:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/client/ClientEventHandler.java#L19

A "factory" is just a method that returns a given type, in this case your GuiScreen. Most of the time you will be able to do this through a 0-parameter constructor.

[StefanDeSterke 0]

Nope, still getting the same error.

 

Registry class:

	@Mod.EventBusSubscriber(modid = TerrariaMod.modid, bus = EventBusSubscriber.Bus.MOD, value = Dist.CLIENT)
	public static class ClientRegistryEvents {
		
		@SubscribeEvent
		public static void FMLClientSetupEvent(FMLClientSetupEvent event){
			
			ScreenManager.registerFactory(ContainerList.furnace, StoneFurnaceGUI::new);
			
		}
		
		
	}

 

[diesieben07 6671]

1 hour ago, diesieben07 said:

this must happen through DeferredWorkQueue from FMLClientSetupEvent

You did not do this. Your code will cause problems in it's current state. ScreenManager is not threadsafe.

 

1 hour ago, diesieben07 said:

Also ensure you pass the correct ContainerType to the Container constructor.

 

Then you open the GUI through NetworkHooks.openGui on the server.

Did you do this? Show the corresponding code.

[StefanDeSterke 0]

1 minute ago, diesieben07 said:

Did you do this? Show the corresponding code.

Here's the code:

	@Override
	public boolean onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit) 
	{	
		if(!worldIn.isRemote) 
		{
			NetworkHooks.openGui((ServerPlayerEntity) player, new Furnace(pos, worldIn), buf -> buf.writeBlockPos(pos));
			return true;
		}
		return false;
		
	}

 

[diesieben07 6671]

5 minutes ago, StefanDeSterke said:

Furnace

What does this class do?

[StefanDeSterke 0]

3 minutes ago, diesieben07 said:

What does this class do?

Oh, my bad. I've given it a very wrong name. It's a class that implements INamedContainerProvider. If you want to see it, here it is:

package mod.sds.terrariamod.inamedcontainerproviders;

import mod.sds.terrariamod.containers.ContainerFurnace;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.entity.player.PlayerInventory;
import net.minecraft.inventory.container.Container;
import net.minecraft.inventory.container.INamedContainerProvider;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.text.ITextComponent;
import net.minecraft.util.text.StringTextComponent;
import net.minecraft.world.World;

public class Furnace implements INamedContainerProvider {

	private BlockPos pos;
	private World world;
	
	public Furnace(BlockPos pos, World world) {
		this.pos = pos;
		this.world = world;
	}
	
	
	@Override
	public Container createMenu(int windowId, PlayerInventory inv, PlayerEntity player) {
		return new ContainerFurnace(windowId, inv, this.world, this.pos);
	}

	@Override
	public ITextComponent getDisplayName() {
		return new StringTextComponent("Furnace Container");
	}

}

 

[diesieben07 6671]

4 hours ago, diesieben07 said:

Also ensure you pass the correct ContainerType to the Container constructor.

You have not done this. You have passed null.

[StefanDeSterke 0]

18 hours ago, StefanDeSterke said:

 

		super(ContainerList.furnace, id);

 

 

I did pass the correct Container Type, right?

[diesieben07 6671]

3 minutes ago, StefanDeSterke said:

ContainerList.furnace

How do you initialize this field? It's value is null.