[Solved] [1.12.2] Why is client player null?

[SapphireSky 1]

This is driving me nuts and it's probably some stupid overlook. I've done this literally a dozen times but lost all my computer data so I can't check my old code.

I'm trying to replace the vanilla HUD with my own, and I can remove the vanilla one just fine but for some reason as soon as I try to access the client player it tells me the player is null.

 

Main event handler

	@SidedProxy(clientSide = "ww.souls.net.ClientProxy", serverSide = "ww.souls.net.ServerProxy")
	public static ServerProxy proxy;

	@EventHandler
	public void init(FMLInitializationEvent event)
	{
		proxy.init();
    }

 

Registering render event on client

@SideOnly(Side.CLIENT)
public class ClientProxy extends ServerProxy
{
	@Override
	public void init()
	{
		MinecraftForge.EVENT_BUS.register(new PlayerHud());
	}
}

 

Render event

	private void render()
	{
		//OpenGL stuff

		float health = player.getHealth() / mc.player.getMaxHealth(); // <- Crashes when first accessing 'null' player here
		float hunger = player.getFoodStats().getFoodLevel() / 20f;
		float exp = player.experience;

		mc.getTextureManager().bindTexture(res);

		ItemStack mainhand = player.getHeldItemMainhand();
		ItemStack offhand = player.getHeldItemOffhand();

		int y = screenheight - 100;
		int x = 20;
		drawTexturedModalRect(x, y, offhand.getCount() == 0 ? 0 : 46, 23, 22, 35);
		drawTexturedModalRect(x, y - 23, 23, 0, 22, 72);

		//OpenGL stuff
	}

	@SubscribeEvent
	public void onRender(RenderGameOverlayEvent.Pre event)
	{
		if (event.getType() == ElementType.ARMOR || event.getType() == ElementType.FOOD || event.getType() == ElementType.HEALTH
				|| event.getType() == ElementType.HEALTHMOUNT || event.getType() == ElementType.HOTBAR
				|| event.getType() == ElementType.JUMPBAR)
		{
			event.setCanceled(true);
			return;
		}

		if (event.getType() == ElementType.EXPERIENCE)
		{
			render();
			renderEnemyHealth();
			event.setCanceled(true);
		}
	}

 

Edited November 14 by SapphireSky

[diesieben07 6684]

5 hours ago, SapphireSky said:

player.getHealth()

Where is this player variable coming from?

[SapphireSky 1]

On 11/13/2019 at 3:39 AM, diesieben07 said:

Where is this player variable coming from?

Oops, thought I included that up there.

It's in the class, defined in constructor.

	private Minecraft mc;
	private EntityPlayer player;

	public PlayerHud()
	{
		mc = Minecraft.getMinecraft();
		player = mc.player;
      	//....
	}

 

[diesieben07 6684]

You cannot do that. The player can and will change. You have to always get it from the game.

[SapphireSky 1]

19 minutes ago, diesieben07 said:

You cannot do that. The player can and will change. You have to always get it from the game.

That's how I've always gotten it to work before... And I have it working that way in 1.14.

Isn't Minecraft.getMinecraft().player literally "getting it from the game"?

How else am I supposed to get the client player then?

 

[diesieben07 6684]

6 minutes ago, SapphireSky said:

Isn't Minecraft.getMinecraft().player literally "getting it from the game"?

Correct. But you get it from the game once, at which point it does not exist yet, and remember the value you got and never ask again.

You must ask every time and not remember the value.

[SapphireSky 1]

Ah okay, that makes a lot more sense now. Thanks.