Jump to content

[Solved] [1.12.2] Why is client player null?


SapphireSky

Recommended Posts

This is driving me nuts and it's probably some stupid overlook. I've done this literally a dozen times but lost all my computer data so I can't check my old code.

I'm trying to replace the vanilla HUD with my own, and I can remove the vanilla one just fine but for some reason as soon as I try to access the client player it tells me the player is null.

 

Main event handler

	@SidedProxy(clientSide = "ww.souls.net.ClientProxy", serverSide = "ww.souls.net.ServerProxy")
	public static ServerProxy proxy;

	@EventHandler
	public void init(FMLInitializationEvent event)
	{
		proxy.init();
    }

 

Registering render event on client

@SideOnly(Side.CLIENT)
public class ClientProxy extends ServerProxy
{
	@Override
	public void init()
	{
		MinecraftForge.EVENT_BUS.register(new PlayerHud());
	}
}

 

Render event


	private void render()
	{
		//OpenGL stuff

		float health = player.getHealth() / mc.player.getMaxHealth(); // <- Crashes when first accessing 'null' player here
		float hunger = player.getFoodStats().getFoodLevel() / 20f;
		float exp = player.experience;

		mc.getTextureManager().bindTexture(res);

		ItemStack mainhand = player.getHeldItemMainhand();
		ItemStack offhand = player.getHeldItemOffhand();

		int y = screenheight - 100;
		int x = 20;
		drawTexturedModalRect(x, y, offhand.getCount() == 0 ? 0 : 46, 23, 22, 35);
		drawTexturedModalRect(x, y - 23, 23, 0, 22, 72);

		//OpenGL stuff
	}

	@SubscribeEvent
	public void onRender(RenderGameOverlayEvent.Pre event)
	{
		if (event.getType() == ElementType.ARMOR || event.getType() == ElementType.FOOD || event.getType() == ElementType.HEALTH
				|| event.getType() == ElementType.HEALTHMOUNT || event.getType() == ElementType.HOTBAR
				|| event.getType() == ElementType.JUMPBAR)
		{
			event.setCanceled(true);
			return;
		}

		if (event.getType() == ElementType.EXPERIENCE)
		{
			render();
			renderEnemyHealth();
			event.setCanceled(true);
		}
	}

 

Edited by SapphireSky
Link to comment
Share on other sites

On 11/13/2019 at 3:39 AM, diesieben07 said:

Where is this player variable coming from?

Oops, thought I included that up there.

It's in the class, defined in constructor.

	private Minecraft mc;
	private EntityPlayer player;

	public PlayerHud()
	{
		mc = Minecraft.getMinecraft();
		player = mc.player;
      	//....
	}

 

Link to comment
Share on other sites

19 minutes ago, diesieben07 said:

You cannot do that. The player can and will change. You have to always get it from the game.

That's how I've always gotten it to work before... And I have it working that way in 1.14.

Isn't Minecraft.getMinecraft().player literally "getting it from the game"?

How else am I supposed to get the client player then?

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I have a problem, I am trying to put two different effects to two different armors but when I run it only the emerald armor effect works. This is the code public class ModArmorItem extends ArmorItem{ private static final Map<ArmorMaterial, MobEffectInstance> MATERIAL_TO_EFFECT_MAP = (new ImmutableMap.Builder<ArmorMaterial, MobEffectInstance>()) .put(ModArmorMaterials.EMERALD, new MobEffectInstance(MobEffects.HERO_OF_THE_VILLAGE,200, 1,false,false, true)) .put(ModArmorMaterials.OBSIDIAN, new MobEffectInstance(MobEffects.FIRE_RESISTANCE,200, 1,false,false, true)).build(); public ModArmorItem(ArmorMaterial pMaterial, Type pType, Properties pProperties) { super(pMaterial, pType, pProperties); } @Override public void onArmorTick(ItemStack stack, Level world, Player player){ if (!world.isClientSide()) { if (hasFullSuitOfArmorOn(player)) { evaluateArmorEffects(player); } } } private void evaluateArmorEffects(Player player) { for (Map.Entry<ArmorMaterial,MobEffectInstance> entry : MATERIAL_TO_EFFECT_MAP.entrySet()){ ArmorMaterial mapArmorMaterial = entry.getKey(); MobEffectInstance mapStatusEffect = entry.getValue(); if (hasCorrectArmorOn(mapArmorMaterial, player)) { addStatusEffectForMaterial(player, mapArmorMaterial, mapStatusEffect); } } } private void addStatusEffectForMaterial(Player player, ArmorMaterial mapArmorMaterial, MobEffectInstance mapStatusEffect) { boolean hasPlayerEffect = player.hasEffect(mapStatusEffect.getEffect()); if (hasCorrectArmorOn(mapArmorMaterial, player) && !hasPlayerEffect) { player.addEffect(new MobEffectInstance(mapStatusEffect)); } } private boolean hasCorrectArmorOn(ArmorMaterial material, Player player) { for (ItemStack armorStack : player.getInventory().armor){ if (!(armorStack.getItem() instanceof ArmorItem)) { return false; } } ArmorItem helmet = ((ArmorItem)player.getInventory().getArmor(3).getItem()); ArmorItem breastplace = ((ArmorItem)player.getInventory().getArmor(2).getItem()); ArmorItem leggins = ((ArmorItem)player.getInventory().getArmor(1).getItem()); ArmorItem boots = ((ArmorItem)player.getInventory().getArmor(0).getItem()); return helmet.getMaterial() == material && breastplace.getMaterial() == material && leggins.getMaterial() == material && boots.getMaterial() == material; } private boolean hasFullSuitOfArmorOn(Player player){ ItemStack helmet = player.getInventory().getArmor(3); ItemStack breastplace = player.getInventory().getArmor(2); ItemStack leggins = player.getInventory().getArmor(1); ItemStack boots = player.getInventory().getArmor(0); return !helmet.isEmpty() && !breastplace.isEmpty() && !leggins.isEmpty() && !boots.isEmpty(); } } Also when I place two effects on the same armor, the game crashes. Here is the crash file. The code is the same, only this part is different   private static final Map<ArmorMaterial, MobEffectInstance> MATERIAL_TO_EFFECT_MAP = (new ImmutableMap.Builder<ArmorMaterial, MobEffectInstance>()) .put(ModArmorMaterials.EMERALD, new MobEffectInstance(MobEffects.HERO_OF_THE_VILLAGE,200, 1,false,false, true)) .put(ModArmorMaterials.EMERALD, new MobEffectInstance(MobEffects.FIRE_RESISTANCE,200, 1,false,false, true)).build(); I hope you guys can help me. Thanks.
    • I removed all related embeddium and oculus mods, i just tested it by disconnecting and the error happened again. heres the report https://pastebin.com/1kcR5wAt   EDIT: i tried removing xaeros and also smoothboot thinking there may be an issue there, nothing, heres that report too. https://pastebin.com/zQS7i9rM
    • Hi, I need suggestions. I am a beginner in Minecraft Modding. I would like to apply custom effects to some armors, something like: more chance to drop seeds, change zombie awareness, drop more pieces of wood when chopping logs, and things like that. How would you recommend me to do it, is there any library that has something similar and which ones would you recommend me?.
    • "downloading minecraft server failed, invalid Checksum. try again, or manually place server.jar to skip download"    
    • You have to create an Entity class called PlayerPart and use multiple of them to make the different parts of the player. See EnderDragonPart.java source code. The green hitboxes of the dragon are all EnderDragonParts
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.