Hooking to Criteria Triggers?

[Lyinginbedmon]

In the vanilla code there's nearly 30 different criteria triggers that are natively updated and managed and almost none of them also connect to events. At a rough estimate, maybe 21 of them could be replicated using Forge events but this would be impractical and laggy in the extreme. However, the criteria triggers will only add listeners from the PlayerAdvancements class.

 

Criteria seem like a really configurable way of adding special effects and such, but is there any way to use them for more than just add new advancements given this hard-coded restriction?

[Draco18s]

What is your use-case here?

[Lyinginbedmon]

6 minutes ago, Draco18s said:

What is your use-case here?

I can see a number of possible contexts it'd be useful but I ran into this issue trying to make a progression system similar to that of Witchery's vampirism and lycanthropy, but able to configured with the same triggers of advancements.

 

Users provide a config/data pack file with a given "pact" contained within it, it gets broken down into tiers and each is accessed in turn based on given criteria. Just about every step of it I can already implement, but I'm flummoxed by how to interface it with the criteria triggers.

Edited October 19, 2019 by Lyinginbedmon

[Draco18s]

You'd have to see how Advancements uses them, I'm pretty sure you can utilize the existing systems for your own use.

[Lyinginbedmon]

12 hours ago, Draco18s said:

You'd have to see how Advancements uses them, I'm pretty sure you can utilize the existing systems for your own use.

This much I've already ascertained, more or less.

 

• Criteria Triggers are held as static final values in the CriteriaTriggers class, each as their own class (ImpossibleTrigger, KilledTrigger, TickTrigger, etc.) and not as a generic.
• The vanilla code then directly triggers them whenever they are needed, and they update a list of attached listeners when they are so updated.
• Listeners are added to each trigger via the AddListener method specified in ICriterionTrigger (which only declares 3 methods: addListener, removeListener, and removeAllListeners). This method (and all methods in ICriterionTrigger) requires a PlayerAdvancements input value to register the listener in a hashmap.

 

My problem is finding a way to add a listener to the criteria without using advancements, because no other route seems evident, but so far I've not found anything. I could theoretically extend from PlayerAdvancements, but that's about 500 lines of code that I'm not dreadfully sure of the operation.

Edited October 19, 2019 by Lyinginbedmon

[Draco18s]

Use player.getAdvancements() as your PlayerAdvancements object. The way trigger works is that trigger is passed a player and calls getAdvancements on it in order to get all the listeners. You'll have to do that for every player that joins the server (and call remove when they leave).

[Lyinginbedmon]

17 hours ago, Draco18s said:

Use player.getAdvancements() as your PlayerAdvancements object. The way trigger works is that trigger is passed a player and calls getAdvancements on it in order to get all the listeners. You'll have to do that for every player that joins the server (and call remove when they leave).

Unfortunately the trouble doesn't just end there, as the Listener we have to manage also requires an Advancement object and makes active use of the value (so we can't just feed it a null). One feasible solution would be to creatively generate dummy advancements but that could cause some considerable bloat in the advancement screen.

	private static final Criterion testCriteria;
	private static final Listener testListener;

	/** Add listeners on login */
	@SideOnly(Side.SERVER)
	@SubscribeEvent
	public void onPlayerLogin(PlayerLoggedInEvent event)
	{
		EntityPlayerMP player = (EntityPlayerMP)event.player;
		PlayerAdvancements advancements = player.getAdvancements();
		CriteriaTriggers.PLAYER_KILLED_ENTITY.addListener(advancements, testListener);
	}
	
	/** Remove listeners on logout */
	@SideOnly(Side.SERVER)
	@SubscribeEvent
	public void onPlayerLogout(PlayerLoggedOutEvent event)
	{
		EntityPlayerMP player = (EntityPlayerMP)event.player;
		PlayerAdvancements advancements = player.getAdvancements();
		CriteriaTriggers.PLAYER_KILLED_ENTITY.removeListener(advancements, testListener);
	}
	
	static
	{
		testCriteria = PactHandler.getPact(new ResourceLocation(Reference.ModInfo.MOD_ID, "feyWitch")).getTiers()[1].getCriteria().get("vax");
		testListener = new ICriterionTrigger.Listener(testCriteria.getCriterionInstance(), null, "vax");
	}

In this quick test example, the criteria (under the name "vax") being added is to kill 1 pig, retrieved from what I've already assembled for a configurable JSON folder.

Edited October 20, 2019 by Lyinginbedmon

[Draco18s]

Hmm, not sure then. I've not tried to do something like this.