[BUG] ModLoader::isGUIOpen incorrectly compares an instance to its Class

[MarcinS]

    @SideOnly(CLIENT)
    public static boolean isGUIOpen(Class<? extends GuiScreen> gui)
    {
        return FMLClientHandler.instance().getClient().currentScreen != null && FMLClientHandler.instance().getClient().currentScreen.equals(gui);
    }

 

This code copmpares an instance of class GuiScreen to class extending GuiScreen, which will always be false. Here is how the code should be:

    @SideOnly(CLIENT)
    public static boolean isGUIOpen(Class<? extends GuiScreen> gui)
    {
        return FMLClientHandler.instance().getClient().currentScreen != null && FMLClientHandler.instance().getClient().currentScreen.getClass().equals(gui);
    }

[MarcinS]

    @SideOnly(CLIENT)
    public static boolean isGUIOpen(Class<? extends GuiScreen> gui)
    {
        return FMLClientHandler.instance().getClient().currentScreen != null && FMLClientHandler.instance().getClient().currentScreen.equals(gui);
    }

 

This code copmpares an instance of class GuiScreen to class extending GuiScreen, which will always be false. Here is how the code should be:

    @SideOnly(CLIENT)
    public static boolean isGUIOpen(Class<? extends GuiScreen> gui)
    {
        return FMLClientHandler.instance().getClient().currentScreen != null && FMLClientHandler.instance().getClient().currentScreen.getClass().equals(gui);
    }

[luacs1998]

File an issue at the bt if you havent already.

https://github.com/MinecraftForge/MinecraftForge/issues

[luacs1998]

File an issue at the bt if you havent already.

https://github.com/MinecraftForge/MinecraftForge/issues

[LexManos]

Actually file it to FML since it's FML's end of things. Same goes for your other post about the Registry.

Small oversights can be fixed easily if reported properly.

[LexManos]

Actually file it to FML since it's FML's end of things. Same goes for your other post about the Registry.

Small oversights can be fixed easily if reported properly.

[MarcinS]

Actually file it to FML since it's FML's end of things. Same goes for your other post about the Registry.

Small oversights can be fixed easily if reported properly.

Can you give me an URL, where I can find some kind of Bugzilla for FML? I already was given the GitHub address for Forge, so I'm sorted on that front.

 

Thank you in advance!

[MarcinS]

Actually file it to FML since it's FML's end of things. Same goes for your other post about the Registry.

Small oversights can be fixed easily if reported properly.

Can you give me an URL, where I can find some kind of Bugzilla for FML? I already was given the GitHub address for Forge, so I'm sorted on that front.

 

Thank you in advance!

[LexManos]

 

https://github.com/MinecraftForge/

Has links to everything.

[LexManos]

 

https://github.com/MinecraftForge/

Has links to everything.