Jump to content

EventBus Weather and Minecart Events


Tim Graupmann

Recommended Posts

Is there a weather event for rain and snow? I searched the source and I found Biomes with snow, but I don't think that's the same thing.

 

I found there's a player.isOnLadder(), is there something for isInMinecart?

 

https://github.com/tgraupmann/MinecraftChromaMod/blob/master/src/main/java/com/example/examplemod/MyForgeEventHandler.java

 

Thanks!

Edited by Tim Graupmann
Link to comment
Share on other sites

5 hours ago, Tim Graupmann said:

I found there's a player.isOnLadder(), is there something for isInMinecart?

Player in minecart is handled as PlayerEntity riding MinecartEntity.

Therefore, you can just check for

player.getRidingEntity() instanceof MinecartEntity

.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

5 hours ago, Tim Graupmann said:

Is there a weather event for rain and snow?

No there isn't, but you can check if it is raining. I think its World#isRaining but I'm not sure. And you'll want to check this in WorldTickEvent(probably not every tick though.)

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

5 hours ago, diesieben07 said:

isRaining just checks if there is precipitation at all. World#isRainingAt(BlockPos) checks if there is rain at the given position (checks for caves and biomes, deserts do not have rain and snow biomes show rain as snow).

For snow you have to do similar checks to isRainingAt, but check for SNOW instead of RAIN.

Speaking of, where did the high-altitude snowfall logic get moved to?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Minecart and detecting rain works.

 

I can detect RAIN, I haven't seen SNOW reported yet. Even when I'm standing in snow or flying through it getPrecipitation reports RAIN.

 

		boolean isRaining = false;
		boolean isSnowing = false;
		if (event.world.isRainingAt(mPlayerState.mPosition)) {
			Biome biome = event.world.getBiome(mPlayerState.mPosition);
			switch (biome.getPrecipitation()) {
				case RAIN:
					isRaining = true;
					break;
				case SNOW:
					isSnowing = true;
					break;
			}
		}

 

Edited by Tim Graupmann
Link to comment
Share on other sites

Biome biome = event.world.getBiome(mPlayerState.mPosition);
logMessage("biome: "+biome+ " tenp "+biome.getTemperature(mPlayerState.mPosition));

 

Checking the biome temp reports around 0.14 but I get the same low temps for rain and snow areas.

 

I'd figure snow would be at temps 32F/0C or below.

 

I might use the condition if the player is on snow covered block or snow tile at the player position.

 

 

		boolean isRaining = false;
		boolean isSnowing = false;
		if (event.world.isRainingAt(mPlayerState.mPosition)) {
			BlockState blockState = event.world.getBlockState(mPlayerState.mPosition);
			if (blockState.getBlock() == Blocks.SNOW ||
					blockState.getBlock() == Blocks.SNOW_BLOCK) {
				isSnowing = true;
			} else {
				Biome biome = event.world.getBiome(mPlayerState.mPosition);
				switch (biome.getPrecipitation()) {
					case RAIN:
						isRaining = true;
						break;
					case SNOW:
						isSnowing = true;
						break;
				}
			}
		}

 

This works well enough...

 

 

Edited by Tim Graupmann
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.