Jump to content

Storing information to be called upon later (1.12.2)


Sour_Tooth

Recommended Posts

Greetings,

 

I am trying to make a mod that randomly generates biomes. My end goal is to call upon a method to generate a biome. Part of my code is this random number generator that generates the color of the grass. 

static class BiomeGenCustom extends Biome {

	public RandomBiome() {

		int Color = myRandomBiome.randomColor();

		@SideOnly(Side.CLIENT)
		public int getGrassColorAtPos(BlockPos pos) {
			return -Color;
	}
}

The issue I've encountered is that myBiome's grass color is generated when Minecraft is launched. Consequently, myBiome's grass color will be re-generated (and changed) every time Minecraft is launched. 

What I would like to happen is for myBiome's grass color to be generated when the world is made, and stay the same thenceforth.

My current idea entails saving myBiome's grass color to myBiome.txt, and referencing that stored number on world load. I, however, have no clue as to how I would approach implementing this idea. 

 

If you have any questions, let me know.

Thanks,

    -     Riley

 

(I am using 1.12.2)

Edited by Sour_Tooth
Clarification
Link to comment
Share on other sites

1. Are you sure you've posted the correct code? That will not compile.

2. Check out WorldSavedData. The documentation of which is at https://mcforge.readthedocs.io/en/latest/datastorage/worldsaveddata/.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

9 minutes ago, DavidM said:

1. Are you sure you've posted the correct code? That will not compile.

2. Check out WorldSavedData. The documentation of which is at https://mcforge.readthedocs.io/en/latest/datastorage/worldsaveddata/.

 

Thanks for responding!

 

1. The code I posted was extracted from a much larger chunk of code. If you’d like, I can update the post with all the code necessary to compile and execute the mod in Minecraft. 

 

2. This seems like it could work, but I’ll have to do some more research.

Link to comment
Share on other sites

44 minutes ago, Sour_Tooth said:

What I would like to happen is for myBiome's grass color to be generated when the world is made, and stay the same thenceforth.

Do you wish to make the grass color at the same position in each client the same?

i.e. There are two players on a server with your mod. Should the grass color at (0, 0) be the same to both of them?

If so, then you could override Biome#getGrassColorAtPos and calculate the color from the xyz coordinates.

This would allow the grass color in your world to stay the same when Minecraft is relaunched, and allow the color to be the same on different client.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

27 minutes ago, DavidM said:

Override Biome#getGrassColorAtPos and calculate the color from the xyz coordinates.

This would allow the grass color in your world to stay the same when Minecraft is relaunched, and allow the color to be the same on different client.

How would this prevent a new color being generated when Minecraft launches? If I understand you correctly, the grass color at (0, 0) would still be equal to randomColor. If so, then the grass at (0, 0) would still be given a new color at launch.

Edited by Sour_Tooth
Clarification
Link to comment
Share on other sites

6 minutes ago, Sour_Tooth said:

If I understand you correctly, the grass color at (0, 0) would still be equal to randomNumber(min, max).

By calculating the color from the xyz coordinates I mean generate the color value from the coordinates.

That way, the color at a specific position will always be the same (like how Minecraft handles its own grass coloring).

An example would be:

@Override
@SideOnly(Side.Client)
public int getGrassColorAtPos(BlockPos pos) {
	return min + (pos.getX() * pos.getY() * pos.getZ() % (max - min));
}

 

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.