Jump to content

Gui saving data help.


TesterTesting135

Recommended Posts

Hello, so i'm trying to make a GUI for a item that allows you to type in the amount of energy you want a machine to store. However, whenever it saves the NBT, it saves it for ALL of the items, not just that 1 instance. Here is my code for my GUI and

item class:

Item Class:

private int energy;

    public CapacityCard(String name) {
        setTranslationKey(name);
        setRegistryName(name);
        setCreativeTab(CreativeTabs.MATERIALS);


        ModItems.ITEMS.add(this);
    }
    public static final String ENERGYCAPACITY = "energyCapacity";
    @Override
    public void addInformation(ItemStack stack, World world, List<String> tooltip, ITooltipFlag advanced) {
 
        if (stack.getItem() == ModItems.ENERGY_CAPACITY_CARD) {
            NBTTagCompound nbt;
            if (stack.hasTagCompound()) {
                nbt = stack.getTagCompound();
            } else {
                nbt = new NBTTagCompound();
            }
            nbt.setInteger(ENERGYCAPACITY, energy);
            if (nbt.hasKey(ENERGYCAPACITY)) {
                tooltip.add(TextFormatting.GREEN + "Energy Capacity: " + nbt.getInteger(ENERGYCAPACITY));
            }
            stack.setTagCompound(nbt);
        }
    }


    @Override
    public void registerModels() {
        Main.proxy.registerItemRenderer(this, 0, "inventory");
    }

    @Override
    public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn) {
        if (worldIn.isRemote) {
            if (!playerIn.isSneaking()) {
                Minecraft.getMinecraft().displayGuiScreen(new GuiCapacityCard(this));
            }
        }
        return super.onItemRightClick(worldIn, playerIn, handIn);
    }

    @Override
    public boolean updateItemStackNBT(NBTTagCompound nbt) {
        return true;
    }
    public void setEnergyCapacity(int energy) {
        this.energy = energy;
    }

 

Gui Class:

private CapacityCard capacityCard;
    private final ResourceLocation gui = new ResourceLocation(Reference.MOD_ID, "textures/gui/link_card.png");
    private static final int WIDTH = 180;
    private static final int HEIGHT = 180;
    @Override
    public void drawScreen(int mouseX, int mouseY, float partialTicks) {
        drawDefaultBackground();
        super.drawScreen(mouseX, mouseY, partialTicks);
        int centerX = (width / 2) - WIDTH / 2;
        int centerY = (height / 2) - HEIGHT / 2;
        mc.getTextureManager().bindTexture(gui);
        drawTexturedModalRect(centerX, centerY, 0, 0, WIDTH, HEIGHT);
        energyCapacity.drawTextBox();
        //drawString(mc.fontRenderer, "Maxiumum Capacity: " + energy, 260, 160, 0xffffff);

    }
    public GuiCapacityCard(CapacityCard card) {
        capacityCard = card;
    }

    @Override
    public void initGui() {
        super.initGui();
        energyCapacity = new GuiTextFieldRevamped(mc.fontRenderer, 270, 100, 125, 20);
        energyCapacity.setMaxStringLength(10);
        energyCapacity.setCharFilter(GuiTextFieldRevamped.FILTER_NUMERIC);
        //energyCapacity.setText(Integer.toString(energy));
    }

    @Override
    protected void actionPerformed(GuiButton button) throws IOException {
        super.actionPerformed(button);
    }

    @Override
    protected void keyTyped(char typedChar, int keyCode) throws IOException {
        super.keyTyped(typedChar, keyCode);
        energyCapacity.textboxKeyTyped(typedChar, keyCode);
    }

    @Override
    public boolean doesGuiPauseGame() {
        return false;
    }

    @Override
    public void onGuiClosed() {
        if (energyCapacity.getInteger() <= 0) {
            energyCapacity.setText("0");
        } else {
            int energy = energyCapacity.getInteger();
            capacityCard.setEnergyCapacity(energy);
            //PacketHandler.INSTANCE.sendToServer(new PacketEnergyCapacity(energy, capacityCard));
        }
        super.onGuiClosed();
    }


    @Override
    public void updateScreen() {
        super.updateScreen();
    }

    @Override
    protected void mouseClicked(int mouseX, int mouseY, int mouseButton) throws IOException {
        super.mouseClicked(mouseX, mouseY, mouseButton);
        energyCapacity.mouseClicked(mouseX, mouseY, mouseButton);
    }

 

    private GuiTextFieldRevamped energyCapacity;

 

Any help would be great.

Thanks.

Link to comment
Share on other sites

6 hours ago, TesterTesting135 said:

private int energy;

6 hours ago, TesterTesting135 said:

public void setEnergyCapacity(int energy) {
        this.energy = energy;
    }

Here is your problem: You are storing the energy in the Instance of the Item ...

 

In Minecraft Items are designed to be Singletons, which means, for each Item there only exists one Instance at all time.

If you set the energy in the Instance of one of your CapacityCards, it will be set for every card, because they share the same Instance.

 

To store data only on one card, without affecting the others you want to store it on the ItemStack's NBT.

In you CapacityCard#setEnergyCapacity you have to write the energy to the stacks NBT data instead of the local variable

When ever you want to read the current energy you have to read it from the stacks NBT data

 

Nice Greetings

TechMage

Link to comment
Share on other sites

What method would i use to get the ItemStack in the Item class?

 

EDIT: I've tried creating an instance of the item class in the GUI and then doing this:

ItemStack stack = new ItemStack(capacityCard);

and then setting the NBT in the setEnergyCapacity method but that isn't working.

Edited by TesterTesting135
More info
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm creating a custom staff, that can be used like a bow, meaning i can use it and it should "load" the staff.   As far as i can see the interaction is pretty simple: activate the "draw" stage via overriding use and then when the mouse is released the "releaseUsing" and "useOnRelease" methods are called.    What i want to achieve is between the activation and the release: I want to do stuff while it is drawn. For example i want to create particles and i want to stop the "drawn" stage in certain conditions. Is something like this possible and if so, where can i look? I'm also happy with examples from other mods. (For example i think that mana and artifice has something like that with the beam spells, but that mod is not open source).
    • Minecraft Version: 1.8-1.20.X Forge Version: All (Tested on 49.0.27, 11.14.4.1577 and some others) Steps to Reproduce: Setup a server with IPV6 only Setup a docker container with forge Try to connect to the Forge Server Description of issue: Hello, I am reaching out to seek your expertise within this forum to clarify a technical situation I am encountering, suspecting a potential issue related to Forge in a Docker environment, specifically in an IPv6 context. Initial Configuration: Debian 12 server, configured exclusively for IPv6, with Docker installed. Using the Docker image ghcr.io/pterodactyl/yolks:java_17, launching a Minecraft Vanilla server version 1.20.4 proceeds without any issues. Problem: The issue arises when deploying a Minecraft Forge server version 1.20.4 with the same Docker image (ghcr.io/pterodactyl/yolks:java_17), where connecting to the server becomes impossible. Notably, this issue does not occur when launching outside of Docker, where the server functions as expected. Hypothesis: This situation leads me to question the interaction between Forge and Docker, particularly in an IPv6-only configuration, despite several resolution attempts (testing with different versions of Forge, adjusting container network configurations (0.0.0.0, ::/0, and the server's ipv6), trials with various network settings, and modifications of Java options). Further testing was conducted with and without the use of the Pterodactyl game panel, unsuccessfully. The parameter -Djava.net.preferIPv4Stack=false also did not provide a solution. I tried to do the same things on multiple Minecraft server (include vanilla,spigot,fabric,sponge) and this work fine. The problem only happend with Forge. This issue seem to happend on all forge versions.   I appreciate your time and assistance in advance.
    • The game crashed whilst exception ticking world Error: java.lang.NullPointerException: Cannot invoke "net.minecraft.resources.ResourceLocation.equals(Object)" because "this.lootTableId" is null Error given is above. I was already playing for around 15 minutes and wasn't doing anything specific or even breaking anything when the crashed happened. This is update 1.19.2 forge: 43.2.23 Mod list: ESSENTIAL Mod (by SparkUniverse_) Traveler's Titles (Forge) (by YUNGNICKYOUNG) Resourceful Config (by ThatGravyBoat) Dynamic Lights (by atomicstrykergrumpy) TenzinLib (by CommodoreThrawn) Nature's Compass (by Chaosyr) Library Ferret - Forge (by jtl_elisa) Cold Sweat (by Mikul) Simple Voice Chat (by henkelmax) Waystones (by BlayTheNinth) Carry On (by Tschipp) [Let's Do] Meadow (by satisfy) Creeper Overhaul (by joosh_7889) AutoRegLib (by Vazkii) Moonlight Lib (by MehVahdJukaar) AppleSkin (by squeek502) Xaero's World Map (by xaero96) Rotten Creatures (by fusionstudiomc) YUNG's API (Forge) (by YUNGNICKYOUNG) Village Artifacts (by Lothrazar) Right Click, Get Crops (by TeamCoFH) Supplementaries (by MehVahdJukaar) Automatic Tool Swap (by MelanX) Better Third Person (by Socolio) Supplementaries Squared (by plantspookable) Traveler's Backpack (by Tiviacz1337) Caelus API (Forge/NeoForge) (by TheIllusiveC4) Creatures and Beasts (by joosh_7889) Architectury API (Fabric/Forge/NeoForge) (by shedaniel) Quark Oddities (by Vazkii) Origins (Forge) (by EdwinMindcraft) Villager Names (by Serilum) GeckoLib (by Gecko) Realistic Bees (by Serilum) Illuminations Forge 🔥 (by dimadencep) Serene Seasons (by TheAdubbz) Critters and Companions (by joosh_7889) [Let's Do] Bakery (by satisfy) Falling Leaves (Forge) (by Cheaterpaul) Jade 🔍 (by Snownee) Collective (by Serilum) TerraBlender (Forge) (by TheAdubbz) [Let's Do] API (by Cristelknight) Towns and Towers (by Biban_Auriu) More Villagers (by SameDifferent) Biomes O' Plenty (by Forstride) Goblin Traders (by MrCrayfish) Corpse (by henkelmax) Tree Harvester (by Serilum) Balm (Forge Edition) (by BlayTheNinth) Mouse Tweaks (by YaLTeR) Sound Physics Remastered (by henkelmax) Xaero's Minimap (by xaero96) Just Enough Items (JEI) (by mezz) Terralith (by Starmute) Quark (by Vazkii) [Let's Do] Vinery (by satisfy) [Let's Do] Candlelight (by satisfy) Repurposed Structures (Neoforge/Forge) (by telepathicgrunt) Dusty Decorations (by flint_mischiff) Immersive Armors [Fabric/Forge] (by Conczin) Serene Seasons Fix (by Or_OS) Shutup Experimental Settings! (by Corgi_Taco) Skin Layers 3D (Fabric/Forge) (by tr7zw)
    • Make sure Java is running via Nvidia GPU https://windowsreport.com/minecraft-not-using-gpu/  
    • Also make a test with other Custom Launchers like AT Launcher, MultiMC or Technic Launcher
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.