Jump to content

[1.12 to 1.14.4] Separate logic for different block states


Alex Sim

Recommended Posts

Hello, I used to make mods for minecraft 1.7.10 and I'm getting back into it.

 

I haven't failed to notice the new XML JSON system (wannabe MVC compliant) sucks... a lot.

Haven't quite figured it out yet though, so my question is, can I separate what each blockstate for a single block does (ex: `facing` changes the rotation and `overworld` changes the base model) without having to write all combinations of states?

 

Example where i write all states combinations:

 

{
  "forge_marker": 1,
  "defaults" : {
    "model": "greenapple_glacia:block/glacial_berry"
  },
  "variants": {
    "facing=north,overworld=false" : {"y": 0},
    "facing=south,overworld=false": {"y": 180 },
    "facing=west,overworld=false":  {"y": 270 },
    "facing=east,overworld=false":  {"y": 90 },

    "facing=north,overworld=true" : {"model": "greenapple_glacia:block/glacial_berry_overworld", "y": 0},
    "facing=south,overworld=true": {"model": "greenapple_glacia:block/glacial_berry_overworld", "y": 180 },
    "facing=west,overworld=true":  {"model": "greenapple_glacia:block/glacial_berry_overworld", "y": 270 },
    "facing=east,overworld=true":  {"model": "greenapple_glacia:block/glacial_berry_overworld", "y": 90 }
  }
}

 

^ that is as much as i was able to trim it

I mean, if I used 4 states with 4 possible values each, I would have to write 4^4 = 256 stetes (?!)

Edited by Alex Sim
Link to comment
Share on other sites

16 minutes ago, diesieben07 said:

Wat?

 

Forge's blockstate format should help you here.

I'm dumb, I was trying to do something like this:

{
  "forge_marker": 1,
  "variants": {
    "facing" : {
      "north" : {"y": 0},
      "south" : {"y": 180},
      "west" : {"y": 270},
      "east" : {"y": 90}
    },
    "overworld" : {
      "true" : {"model": "greenapple_glacia:block/glacial_berry_overworld"},
      "false" : {"model": "greenapple_glacia:block/glacial_berry"}
    }
  }
}

 

But with normal syntax ("facing=north" : {...} ...)

This makes this XML JSON blockstates sytem not suck as much

 

Also thanks for answering again

Edited by Alex Sim
Link to comment
Share on other sites

5 hours ago, Alex Sim said:

(wannabe MVC compliant)

Its not MVC (model-view-controller), its data-driven design.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

5 hours ago, diesieben07 said:

Wat?

 

Forge's blockstate format should help you here.

I've got another small issue, I don't know if that's just me messing it up again or an unimplemented/changed feature, but on 1.14.4 I'm not able to override textures inside a blockstate file, it just uses the model-associated texture (if present) or not-found texture otherwise

Here's an example of my blockstate

 

{
  "forge_marker": 1,
  "variants": {
    "examplestate": {
      "true": {
        "textures": {
          "side": "greenapple_glacia:blocks/test_bedrock",
          "end": "greenapple_glacia:blocks/test_bedrock"
        },
        "model": "greenapple_glacia:block/glacia_column_mono"
      },
      "false": {
        "textures": {
          "side": "greenapple_glacia:blocks/test_stone",
          "end": "greenapple_glacia:blocks/test_stone"
        },
        "model": "greenapple_glacia:block/glacia_column_top"
      }
    }
  }
}

 

But I have many tried different ways with the same result

Edited by Alex Sim
Link to comment
Share on other sites

4 minutes ago, Alex Sim said:

1.14.4 I'm not able to override textures inside a blockstate file, it just uses the model-associated texture (if present) or not-found texture otherwise

https://github.com/MinecraftForge/MinecraftForge/issues/5615

  • Thanks 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.