Jump to content

1.12.2 fireball not colliding with any blocks or entities


clearcut

Recommended Posts

I made a left click event so that left clicking will fire out a fireball (I will make it specific to some items after I get it to work)

I have got this to work on a right click event in the tool class and it works fine.

package com.ChaoticSoul.MoreArmor.items.tools;

import com.ChaoticSoul.MoreArmor.Main;
import com.ChaoticSoul.MoreArmor.init.ModItems;
import com.ChaoticSoul.MoreArmor.util.IHasModel;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.projectile.EntityLargeFireball;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemSword;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.Vec3d;
import net.minecraft.world.World;

public class ToolSword extends ItemSword implements IHasModel
{
	
	public ToolSword(String name, ToolMaterial material)
	{
		super(material);
		setUnlocalizedName(name);
		setRegistryName(name);
		setCreativeTab(CreativeTabs.COMBAT);
		
		
		ModItems.ITEMS.add(this);
	}
	
	@Override
	public void registerModels() 
	{
		Main.proxy.registerItemRenderer(this, 0, "inventory");
		
	}
	
	public ActionResult<ItemStack> onEntitySwing(EntityLivingBase entityLiving, ItemStack stack, EnumHand handIn, World worldIn) {
		ItemStack item = entityLiving.getHeldItem(handIn);
		Vec3d aim = entityLiving.getLookVec();
		EntityLargeFireball fireball = new EntityLargeFireball(worldIn, entityLiving, 1, 1, 1);
		
		fireball.setPosition(entityLiving.posX, entityLiving.posY, entityLiving.posZ);
		fireball.accelerationX = aim.x * 0.1; fireball.accelerationY = aim.y * 0.1; fireball.accelerationZ = aim.z * 0.1;
		worldIn.spawnEntity(fireball);
		
		item.damageItem(1, entityLiving);
		return new ActionResult<ItemStack>(EnumActionResult.SUCCESS, item);
	}
	@Override
	public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn) {
		ItemStack item = playerIn.getHeldItem(handIn);
		Vec3d aim = playerIn.getLookVec();
		EntityLargeFireball fireball = new EntityLargeFireball(worldIn, playerIn, 1, 1, 1);
		
		fireball.setPosition(playerIn.posX, playerIn.posY, playerIn.posZ);
		fireball.accelerationX = aim.x * 0.1; fireball.accelerationY = aim.y * 0.1; fireball.accelerationZ = aim.z * 0.1;
		worldIn.spawnEntity(fireball);
		
		item.damageItem(1, playerIn);
		return new ActionResult<ItemStack>(EnumActionResult.SUCCESS, item);
	}

}
	

I then made a left click event which spawns and fires the fireball correctly but the fireball just travels through all entities and blocks without interacting in any way.

package com.ChaoticSoul.MoreArmor.events;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.projectile.EntityLargeFireball;
import net.minecraft.item.ItemStack;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.Vec3d;
import net.minecraft.world.World;
import net.minecraftforge.event.entity.player.PlayerInteractEvent;
import net.minecraftforge.event.entity.player.PlayerInteractEvent.LeftClickEmpty;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class MAEventHandler {
	@SubscribeEvent
	public ActionResult<ItemStack> leftClick(LeftClickEmpty event) {
		ItemStack item = event.getEntityPlayer().getHeldItemMainhand();
		Vec3d aim = event.getEntityPlayer().getLookVec();
		World worldIn = event.getEntityPlayer().getEntityWorld();
		EntityPlayer playerIn = event.getEntityPlayer(); 
		EntityLargeFireball fireball = new EntityLargeFireball(worldIn, playerIn, 1, 1, 1);
		
		fireball.setPosition(playerIn.posX, playerIn.posY, playerIn.posZ);
		fireball.accelerationX = aim.x * 0.1; fireball.accelerationY = aim.y * 0.1; fireball.accelerationZ = aim.z * 0.1;
		worldIn.spawnEntity(fireball);
		
		item.damageItem(1, playerIn);
		return new ActionResult<ItemStack>(EnumActionResult.SUCCESS, item);
	}

}

 

Edited by clearcut
Link to comment
Share on other sites

The LeftClickEmpty event is client-side only.

Use packets to notify the server of the left click.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.