Jump to content

[1.14.2] Registering TileEntites


TehStoneMan

Recommended Posts

Also post your code.

Heres an example of registration that works perfectly https://github.com/Cadiboo/Example-Mod/blob/d828cd29685f7732cac6a2a8cd0f5cbfee5d6e88/src/main/java/io/github/cadiboo/examplemod/ModEventSubscriber.java#L106-L118 

Edited by Cadiboo
  • Like 1

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

TileEntity

public class TileEntityLocker extends TileEntityLockable
{
	public TileEntityLocker()
	{
		super( BetterStorageTileEntityTypes.LOCKER );
	}
}

Registering

@Mod.EventBusSubscriber( bus = Mod.EventBusSubscriber.Bus.MOD )
public class RegistryEventHandler
{
	....
	@SubscribeEvent
	public static void onTileEntityRegistry( final RegistryEvent.Register< TileEntityType< ? > > event )
	{
		final IForgeRegistry< TileEntityType< ? > > registry = event.getRegistry();
		
		registry.register( TileEntityType.Builder.create( TileEntityLocker::new ).build( null ).setRegistryName( ModInfo.MOD_ID, "locker" ) );
	}
}

Error

[20:09:38.492] [Server thread/ERROR] [minecraft/Chunk]: A TileEntity type io.github.tehstoneman.betterstorage.common.tileentity.TileEntityLocker has thrown an exception trying to write state. It will not persist, Report this to the mod author
java.lang.RuntimeException: class io.github.tehstoneman.betterstorage.common.tileentity.TileEntityLocker is missing a mapping! This is a bug!
	at net.minecraft.tileentity.TileEntity.writeInternal(TileEntity.java:63) ~[?:?] {pl:accesstransformer:B}
	at net.minecraft.tileentity.TileEntity.write(TileEntity.java:57) ~[?:?] {pl:accesstransformer:B}
	at net.minecraft.world.chunk.Chunk.func_223134_j(Chunk.java:431) ~[?:?] {}
	at net.minecraft.world.chunk.storage.ChunkSerializer.write(ChunkSerializer.java:302) ~[?:?] {}
	at net.minecraft.world.chunk.ChunkManager.func_219229_a(ChunkManager.java:660) ~[?:?] {}
	at java.util.stream.ReferencePipeline$2$1.accept(Unknown Source) [?:1.8.0_211] {}
	at java.util.stream.ReferencePipeline$2$1.accept(Unknown Source) [?:1.8.0_211] {}
	at java.util.stream.ReferencePipeline$3$1.accept(Unknown Source) [?:1.8.0_211] {}
	at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(Unknown Source) [?:1.8.0_211] {}
	at java.util.stream.AbstractPipeline.copyInto(Unknown Source) [?:1.8.0_211] {}
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source) [?:1.8.0_211] {}
	at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source) [?:1.8.0_211] {}
	at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source) [?:1.8.0_211] {}
	at java.util.stream.AbstractPipeline.evaluate(Unknown Source) [?:1.8.0_211] {}
	at java.util.stream.ReferencePipeline.forEach(Unknown Source) [?:1.8.0_211] {}
	at net.minecraft.world.chunk.ChunkManager.save(ChunkManager.java:319) [?:?] {}
	at net.minecraft.world.chunk.ServerChunkProvider.save(SourceFile:277) [?:?] {pl:accesstransformer:B}
	at net.minecraft.world.ServerWorld.save(ServerWorld.java:733) [?:?] {pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.save(MinecraftServer.java:501) [?:?] {pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.stopServer(MinecraftServer.java:541) [?:?] {pl:accesstransformer:B}
	at net.minecraft.server.integrated.IntegratedServer.stopServer(IntegratedServer.java:210) [?:?] {pl:runtimedistcleaner:A}
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:646) [?:?] {pl:accesstransformer:B}
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_211] {}

 

Link to comment
Share on other sites

Place a breakpoint in the writeInternal method and check variables. Also make sure that  BetterStorageTileEntityTypes.LOCKER is getting properly filled with @ObjectHolder

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

The thing that I’m assuming you’re using to fill BetterStorageTileEntityTypes.LOCKER. Please post the entire BetterStorageTileEntityTypes class. 

 

Info on @ObjectHolder: https://mcforge.readthedocs.io/en/latest/concepts/registries/#injecting-registry-values-into-fields

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Here:

package io.github.tehstoneman.betterstorage.common.tileentity;

import net.minecraft.tileentity.TileEntityType;

public final class BetterStorageTileEntityTypes
{
	public static TileEntityType< TileEntityCrate >				CRATE;
	public static TileEntityType< TileEntityReinforcedChest >	REINFORCED_CHEST;
	public static TileEntityType< TileEntityLocker >			LOCKER;
	public static TileEntityType< TileEntityReinforcedLocker >	REINFORCED_LOCKER;
}

I guess @ObjectHolder is something new to me - I have not seen it before.

Link to comment
Share on other sites

56 minutes ago, TehStoneMan said:

Here:


package io.github.tehstoneman.betterstorage.common.tileentity;

import net.minecraft.tileentity.TileEntityType;

public final class BetterStorageTileEntityTypes
{
	public static TileEntityType< TileEntityCrate >				CRATE;
	public static TileEntityType< TileEntityReinforcedChest >	REINFORCED_CHEST;
	public static TileEntityType< TileEntityLocker >			LOCKER;
	public static TileEntityType< TileEntityReinforcedLocker >	REINFORCED_LOCKER;
}

I guess @ObjectHolder is something new to me - I have not seen it before.

Nope, @ObjectHolder is not new - it's been around since 1.10.  Read https://mcforge.readthedocs.io/en/latest/concepts/registries/ (although it's written for 1.12.2, the concepts still apply in 1.14+).

 

Learn it, use it - it's the Right Way to do things with Forge, especially in 1.14 where so many more things are in registries.

Link to comment
Share on other sites

First off, I said that it is new to -->ME<--, and how would I learn to use something that I did not know even exists when everything I have done up to now has worked without any reference to things that I may be missing?

Link to comment
Share on other sites

10 hours ago, TehStoneMan said:

Here:


package io.github.tehstoneman.betterstorage.common.tileentity;

import net.minecraft.tileentity.TileEntityType;

public final class BetterStorageTileEntityTypes
{
	public static TileEntityType< TileEntityCrate >				CRATE;
	public static TileEntityType< TileEntityReinforcedChest >	REINFORCED_CHEST;
	public static TileEntityType< TileEntityLocker >			LOCKER;
	public static TileEntityType< TileEntityReinforcedLocker >	REINFORCED_LOCKER;
}

I guess @ObjectHolder is something new to me - I have not seen it before.

These fields are never set to anything, so they are always null when used. @ObjectHolder would fill these values for you if you used it https://github.com/Cadiboo/Example-Mod/blob/1.14.2/src/main/java/io/github/cadiboo/examplemod/init/ModTileEntityTypes.java

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.