[1.13.2] Blockstates and Texture not Loading

[chriss1998_15]

Hello,

 

I recently got back into Modding and created my first Block with all the .JSONs and the Texture are not loading and the looks weird in my head and in the World.

Here is a link to the Repo. This is meant to be a test Mod.

Is there somebody who can help? If so Thanks in advance. Also if there are questions please feel ask.

 

Chris

[Draco18s]

Your registry event method (the one that's actually registered) does nothing:

    @Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD)
    public static class RegistryEvents {
        @SubscribeEvent
        public static void onBlocksRegistry(final RegistryEvent.Register<Block> blockRegistryEvent) {
            // register a new block here
            LOGGER.info("HELLO from Register Block");
        }
    }

The one that actually does something, isn't registered as an event handler:

public static void registerAll(RegistryEvent.Register<Block> event) {
        // Verify we are getting the correct registry event. If not, just silently return.
        if (!event.getName().equals(ForgeRegistries.BLOCKS.getRegistryName())) {
            return;
        }

        // This could be on one line, I typically break before each chained method call on
        // Block.Properties. You can break up the line however you like. If extending a block class,
        // I usually create the Properties in the new class' constructor, instead of here.
        blueStone = register("blue_stone", new Block(Block.Properties.create(Material.ROCK)
                .hardnessAndResistance(1.5f, 6f)
                .sound(SoundType.STONE)
        ));
    }

 

[chriss1998_15]

Hallo @Draco18s,

 

thanks for the Help sadly my attempt at fixing the Problem didn't work the Block load fine,

but there is still the Problem with the Blockstate any suggestion. 

 

Chris

Edited June 20, 2019 by chriss1998_15

[Draco18s]

ForgeRegistries.BLOCKS.register(block);

What?

No. Bad modder, no cookie.

 

The whole point of the registry events is that you use event.getRegistry().register(...)

 

Ditto for your ModItems class.

 

Similarly, this is useless:

        if (!event.getName().equals(ForgeRegistries.BLOCKS.getRegistryName())) {
            return;
        }

 

https://bitbucket.org/chriss199815/whatdoiknow/src/b5f75d284115320e57b10671a8c1825fef6f716b/src/main/java/de/chriss1998/wdik/init/ModBlocks.java#lines-79

Use @ObjectHolder do not assign to fields yourself.

[chriss1998_15]

6 hours ago, Draco18s said:

ForgeRegistries.BLOCKS.register(block);

What?

No. Bad modder, no cookie.

 

The whole point of the registry events is that you use event.getRegistry().register(...)

 

Ditto for your ModItems class.

 

Similarly, this is useless:

        if (!event.getName().equals(ForgeRegistries.BLOCKS.getRegistryName())) {
            return;
        }

 

https://bitbucket.org/chriss199815/whatdoiknow/src/b5f75d284115320e57b10671a8c1825fef6f716b/src/main/java/de/chriss1998/wdik/init/ModBlocks.java#lines-79

Use @ObjectHolder do not assign to fields yourself.

Ok, I will look into this but what does that have with the Blockstates? Or is that related to this? 

Edited June 20, 2019 by chriss1998_15

[Draco18s]

If you don't register things the way you're supposed to, when you're supposed to, GOD ONLY KNOWS what'll go wrong.