Jump to content

[1.12.2] Problem durability don't loose


Reikenz

Recommended Posts

Hello everyone, I have a small problem my item is working properly, but does not lose durability while I withdraw from it

I watched a lot of English subjects without finding the answer.

 

Here is my code:

public ItemEffect(String name, int maxDamage, int stackSize, int coolDown, PotionEffect effect)
    {
        super(name);
 
        this.setMaxDamage(maxDamage);
        this.setMaxStackSize(stackSize);
        this.setFull3D();
 
        this.effect = effect;
        this.coolDown = coolDown;
    }
 
    @Override
    public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn) {
        ItemStack itemStack = playerIn.getHeldItemMainhand();

        if(worldIn.isRemote)
        {
            return new ActionResult<>(EnumActionResult.FAIL, itemStack);
        }

        if (!playerIn.inventory.hasItemStack(itemStack))
        {
            return new ActionResult<>(EnumActionResult.FAIL, itemStack);
        }

        if (itemStack.getItemDamage() > itemStack.getMaxDamage()) {
            return new ActionResult<>(EnumActionResult.FAIL, itemStack);
        }

        playerIn.addPotionEffect(new PotionEffect(effect.getPotion(), effect.getDuration(), effect.getAmplifier(), effect.getIsAmbient(), effect.doesShowParticles()));
        playerIn.getCooldownTracker().setCooldown(this, coolDown);
        itemStack.damageItem(1, playerIn);
        itemStack.shrink(1);

        return new ActionResult<>(EnumActionResult.SUCCESS, itemStack);
    }

 

Thank you in advance to the person who will help me.

Edited by Reikenz
Link to comment
Share on other sites

Add a breakpoint right before the damaging item line to see if the code is reached.

 

Why are you damaging the item and shrinking the stack at the same time though?

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

9 hours ago, DavidM said:

Add a breakpoint right before the damaging item line to see if the code is reached.

 

Why are you damaging the item and shrinking the stack at the same time though?

Small mistake x)

 

image.thumb.png.8ce369ad1e83068d6e5c4dfa1331c375.png 

 

 

When I put a breakpoint on the damage item it does not work

image.png.81daa4af40f908e6af9c8d27bc126f69.png

 

 

 

Resolved juste im in creative mod... 

Edited by Reikenz
Link to comment
Share on other sites

How are you launching the game? You need to launch it in debug mode

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.