Jump to content

[1.13.2] Blocks and Items not registered in the game.


cinsiian

Recommended Posts

Quote

 

This method will register the first parameter (item) and assign the current item(item) to the current item's class(itemClass).

 

 

 

What? This is not how anything works.

 

Quote

item = itemClass;

Yeah, this does absolutely nothing because item isn't a reference.

 

Your second method makes even less sense. Why assign the passed parameter to a random local and then register said local?

 

Quote

ItemBase

Here we go again. Don't use Item/BlockBase, there is already one, it's called Item/Block. Don't abuse inheritance.

 

Quote

public static void createBlock(Block block, Block blockClass, ItemBlock itemBlock, RegistryEvent.Register<Block> eventBlock, RegistryEvent.Register<Item> eventItem)

You can't pass both events to this method. Well, you can but you will break everything because items and blocks need to be registered in an appropriate event, you can't just start registering items in the block registry event and vice-versa.

 

Quote

block = blockClass;

As said already this won't work. It just assigns the value of blockClass to a block. Both of which are parameters which work as locals for this purpose.

 

Quote

ItemBlock itemBlock = new ItemBlock(block, new Item.Properties());

This will crash you in so many ways lol. Registering in the wrong time to a locked registry without a registry name is not the way to go.

 

Same to the next method.

 

public static ResourceLocation location(String name, String modid)
	{
		return new ResourceLocation(modid, name);
	}

But WHY have this method at all? Why type RegistryUtils.location every time when you can just type new ResourceLocation?

 

You don't seem to understand the concepts of passing by reference/value. 

https://stackoverflow.com/questions/40480/is-java-pass-by-reference-or-pass-by-value

 

You also don't seem to understand how registries work and we have docs for that.

https://mcforge.readthedocs.io/en/latest/concepts/registries/#registering-things

 

Next up:

https://github.com/cinsiian/Crystal/blob/master/src/main/java/cinsiian/crystal/config/CrystalConfig.java#L13

But why? You can just assign the value right there, in the field declaration. When we tell people never to use static initializers we mean don't use them for registry entries, otherwise static initializers are fine.

 

https://github.com/cinsiian/Crystal/blob/master/src/main/java/cinsiian/crystal/item/ItemBase.java#L11
As said earlier don't use ItemBase.

 

https://github.com/cinsiian/Crystal/blob/master/src/main/java/cinsiian/crystal/item/ItemBase.java#L28

You can do this in the Properties of your item. In fact please do so.

 

https://github.com/cinsiian/Crystal/blob/master/src/main/java/cinsiian/crystal/item/ItemTab.java

I don't... the more I look at this class the more I understand that I don't understand anything. Is this a horrifying way to type CrystalConfig.MOD_TABS ? ModItemGroups.GROUP : ItemGroup.SOMETHNG? But then

https://github.com/cinsiian/Crystal/blob/master/src/main/java/cinsiian/crystal/item/ItemTab.java#L35

Like, what is even supposed to happen here? I am so confused. Why are you creating a new list, adding all vanilla groups to it, iterating it, doing a reference comparason to the group passed and then call your setters? Why not call them at the very beginning of the constructor?

 

https://github.com/cinsiian/Crystal/blob/master/src/main/java/cinsiian/crystal/mod/CrystalRegistry.java#L23

Don't use static initializers for registry entries. Here exampleBlock is null by the time this instantinates, so you pass a null block to your ItemBlock. 

 

https://github.com/cinsiian/Crystal/blob/master/src/main/java/cinsiian/crystal/mod/CrystalRegistry.java#L35

This is not how events work. Read the docs

https://mcforge.readthedocs.io/en/1.13.x/events/intro/

 

Edit: Yeah, what @DavidM said. Don't overcomplicate basic stuff, there is no reason to do so.

Edited by V0idWa1k3r
Link to comment
Share on other sites

You are way overcomplicating stuff like registration with unnecessary library classes and functions, making your code almost unreadable.

I would suggest to remove unnecessary classes (for example RegUtils, which only adds an item to the registry and assign the references of it to an ObjectHolder (and fails to do it), something that can be done in one line) and rewrite most of your code to keep things simple.

Moreover, do not use ItemBase. Read the Common issues and recommendations for more explanation.

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

I am kinda new to this things so instead of copy other people's code i tried to make my own things. Apparently I did everything wrong lol. The ItemTab class is supposed to return my mod item group if the boolean in CrystalConfig is true, then, if false it will return a vanilla item group. I'm going to totally rewrite my mod. Thanks everyone.

Link to comment
Share on other sites

Simple base 1.13.2 mod: https://github.com/Cadiboo/Example-Mod

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.