Set items in Container

[Schleim_time]

I tried out to set items in my container if i place something in the right place but the problem i got is that i cant see the item until i click on the slot and than it will appear.  I tried detectandsendchanges, getslot and putiteminslot and tried to set an itemstack to my slot, i also tried to use .update or something but it all dont worked, i recieve the item but the are not visible until you interact with the right slot, how can i fix that problem? Also i tried to use oncraftmatrixchanged but that dont even return me a sysout

[Schleim_time]

I already deleted it but i did everytime the same its tileentity.setSlotcontent(index, new Itemstack(items.(blabla))

[Schleim_time]

Its only a problem in a container, i do an input, it finds the input but the output is set in the right field, only problem is it is invisible. So is there a way to uptade the inv?

[DavidM]

Show your code.

I've realized that you are reluctant in showing your code in many of your post. Why?

It is hard to help you if you don't show your code.

Edited May 17, 2019 by DavidM

[Schleim_time]

3 hours ago, DavidM said:

Show your code.

I've realized that you are reluctant in showing your code in many of your post. Why?

It is hard to help you if you don't show your code.

Quote

package com.Schleimtime.Wasteland.blocks.forgebench;

import java.util.ArrayList;
import java.util.List;

import com.Schleimtime.Wasteland.blocks.forgebench.slots.Outputslot;
import com.Schleimtime.Wasteland.init.moditems;

import net.minecraft.client.gui.inventory.GuiCrafting;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.init.Items;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.ContainerWorkbench;
import net.minecraft.inventory.IContainerListener;
import net.minecraft.inventory.IInventory;
import net.minecraft.inventory.InventoryCrafting;
import net.minecraft.inventory.Slot;
import net.minecraft.item.ItemArmor;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraftforge.items.ItemStackHandler;

public class forgebenchcontainer extends Container{
    
    private forgetileentity tileentity;

public forgebenchcontainer(InventoryPlayer player, forgetileentity tyleentity) {
        this.tileentity = tyleentity;
        
        
        this.addSlotToContainer(new Slot(tyleentity, 0, 30, 17));
        this.addSlotToContainer(new Slot(tyleentity, 1, 48, 17));
        this.addSlotToContainer(new Slot(tyleentity, 2, 66, 17));
        
        this.addSlotToContainer(new Slot(tyleentity, 3, 30, 35));
        this.addSlotToContainer(new Slot(tyleentity, 4, 48, 35));
        this.addSlotToContainer(new Slot(tyleentity, 5, 66, 35));
        
        this.addSlotToContainer(new Slot(tyleentity, 6, 30, 53));
        this.addSlotToContainer(new Slot(tyleentity, 7, 48, 53));
        this.addSlotToContainer(new Slot(tyleentity, 8, 66, 53));
        
        this.addSlotToContainer(new Outputslot(tyleentity, 9, 124, 35));
        
        
        
        for(int y = 0; y < 3; y++) {
            for(int x = 0; x < 9; x++) {
                this.addSlotToContainer(new Slot(player, x+y*9+9, 8+x*18, 84+y*18));
            }
        }
        
        for(int x = 0; x < 9; x++) {
            this.addSlotToContainer(new Slot(player, x, 8+x*18, 142));
        }
        
        
    }

    @Override
    public boolean canInteractWith(EntityPlayer playerIn) {
        return true;
    }
    
    @Override
    public void detectAndSendChanges() {
        if(tileentity.getStackInSlot(1).getItem() == Items.IRON_INGOT) {
            System.out.println("lol");
            tileentity.setInventorySlotContents(9, new ItemStack(moditems.BRONZE_INGOT));
        }
    }
    
    @Override
    public void onContainerClosed(EntityPlayer playerIn) {
        ArrayList<ItemStack> itemlist = new ArrayList<ItemStack>();
        for(int x = 0; x < 9; x++) {
            ItemStack stack = tileentity.getStackInSlot(x);
            if(stack!=null) {
                itemlist.add(stack);
            }
        }
        if(!itemlist.isEmpty()) {
            for(ItemStack item : itemlist) {
            playerIn.inventory.addItemStackToInventory(item);
            }
        }
        tileentity.clear();
        itemlist.clear();
    }
    
    @Override
    public ItemStack transferStackInSlot(EntityPlayer playerIn, int index)
    {
        ItemStack itemstack = ItemStack.EMPTY;
        Slot slot = this.inventorySlots.get(index);

        if (slot != null && slot.getHasStack())
        {
            ItemStack itemstack1 = slot.getStack();
            itemstack = itemstack1.copy();

            if (index == 0)
            {
                itemstack1.getItem().onCreated(itemstack1, playerIn.getEntityWorld(), playerIn);

                if (!this.mergeItemStack(itemstack1, 10, 46, true))
                {
                    return ItemStack.EMPTY;
                }

                slot.onSlotChange(itemstack1, itemstack);
            }
            else if (index >= 10 && index < 37)
            {
                if (!this.mergeItemStack(itemstack1, 37, 46, false))
                {
                    return ItemStack.EMPTY;
                }
            }
            else if (index >= 37 && index < 46)
            {
                if (!this.mergeItemStack(itemstack1, 10, 37, false))
                {
                    return ItemStack.EMPTY;
                }
            }
            else if (!this.mergeItemStack(itemstack1, 10, 46, false))
            {
                return ItemStack.EMPTY;
            }

            if (itemstack1.isEmpty())
            {
                slot.putStack(ItemStack.EMPTY);
            }
            else
            {
                slot.onSlotChanged();
            }

            if (itemstack1.getCount() == itemstack.getCount())
            {
                return ItemStack.EMPTY;
            }

            ItemStack itemstack2 = slot.onTake(playerIn, itemstack1);

            if (index == 0)
            {
                playerIn.dropItem(itemstack2, false);
            }
        }

        return itemstack;
    }
    
    
}

 

thats it the sysout give me my message and the item is there but its buggy and i will only see the item if i click on the slot

 

3 hours ago, diesieben07 said:

Again: Show your code.

3 hours ago, DavidM said:

I've realized that you are reluctant in showing your code in many of your post. Why?

im sorry, i am responding when i got the mail and sometimes im not at home XD

[Schleim_time]

Ok im tryed it now with an Override method

 

Quote

@Override
    public ItemStack getStackInSlot(int slotIndex) {
        if(slotIndex == 9) {
            for(ForgingRecipe r : ForgingbenchRecipesInit.FORGINGRECIPES) {
                System.out.println("its wörking"+r.getinput1+r.getinput4);
                if(this.getStackInSlot(0).getItem() == r.getinput1) {
                if(this.getStackInSlot(1).getItem() == r.getinput2) {
                if(this.getStackInSlot(2).getItem() == r.getinput3) {
                if(this.getStackInSlot(3).getItem() == r.getinput4) {
                if(this.getStackInSlot(4).getItem() == r.getinput5) {
                if(this.getStackInSlot(5).getItem() == r.getinput6) {
                if(this.getStackInSlot(6).getItem() == r.getinput7) {
                if(this.getStackInSlot(8).getItem() == r.getinput8) {
                if(this.getStackInSlot(9).getItem() == r.getinput9) {
                                                    
                                                    return new ItemStack(r.getoutput);
                                                    
                                                }
                                            }
                                        }
                                    }
                                }
                            }
                        }
                    }
                }
            }
        }
        return itemStacks[slotIndex];
    }

that worked if i do that manully but for some reason it will not work and also the for loop will not work

 

Quote

package com.Schleimtime.Wasteland.blocks.forgebench;

import java.util.ArrayList;

import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;

public class ForgingbenchRecipesInit {
    
    public static final ArrayList<ForgingRecipe> FORGINGRECIPES = new ArrayList<ForgingRecipe>();
    
    Item o = null;
    Item i = Items.IRON_INGOT;
    Item s = Items.IRON_INGOT;
    
    ForgingRecipe iron_pickaxe = new ForgingRecipe(i,i,i,o,s,o,o,s,o, Items.IRON_PICKAXE);
}

 

Quote

package com.Schleimtime.Wasteland.blocks.forgebench;

import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;

public class ForgingRecipe {
    
    private Item input1;
    private Item input2;
    private Item input3;
    private Item input4;
    private Item input5;
    private Item input6;
    private Item input7;
    private Item input8;
    private Item input9;
    private Item output;

    public ForgingRecipe (Item input1, Item input2, Item input3, Item input4, Item input5, Item input6, Item input7, Item input8, Item input9, Item output) {
        ForgingbenchRecipesInit.FORGINGRECIPES.add(this);
        
        this.input1 = input1;
        this.input2 = input2;
        this.input3 = input3;
        this.input4 = input4;
        this.input5 = input5;
        this.input6 = input6;
        this.input7 = input7;
        this.input8 = input8;
        this.input9 = input9;
        this.output = output;
        
    }
    
    public Item getinput1 = input1;
    public Item getinput2 = input2;
    public Item getinput3 = input3;
    public Item getinput4 = input4;
    public Item getinput5 = input5;
    public Item getinput6 = input6;
    public Item getinput7 = input7;
    public Item getinput8 = input8;
    public Item getinput9 = input9;
    public Item getoutput = output;
    
    
}

i dont get why

[Schleim_time]

all okay its solved, btw how can i ask if player takes item out of a slot?

[Draco18s]

7 hours ago, Schleim_time said:

                if(this.getStackInSlot(0).getItem() == r.getinput1) {
                if(this.getStackInSlot(1).getItem() == r.getinput2) {
                if(this.getStackInSlot(2).getItem() == r.getinput3) {
                if(this.getStackInSlot(3).getItem() == r.getinput4) {
                if(this.getStackInSlot(4).getItem() == r.getinput5) {
                if(this.getStackInSlot(5).getItem() == r.getinput6) {
                if(this.getStackInSlot(6).getItem() == r.getinput7) {
                if(this.getStackInSlot(8).getItem() == r.getinput8) {
                if(this.getStackInSlot(9).getItem() == r.getinput9) {

Have you heard of loops?

[Schleim_time]

14 hours ago, Draco18s said:

Have you heard of loops?

Yes but i cant do for x < 8 because i have for every recipe a own getInputX 

[DavidM]

15 minutes ago, Schleim_time said:

Yes but i cant do for x < 8 because i have for every recipe a own getInputX 

You can. Simply iterate through the inputs instead of creating a new variable for each one of them. Use a list.

Also, ItemStack != Item.

Edited May 18, 2019 by DavidM

[Schleim_time]

ahh however i think it isnt that much performance so i take that easy way i did

[DavidM]

16 minutes ago, Schleim_time said:

ahh however i think it isnt that much performance so i take that easy way i did

Iterating through a list isn't that performance intensive, but will make your code a lot more readable and easy to fix.

[Cadiboo]

18 hours ago, Schleim_time said:

ahh however i think it isnt that much performance so i take that easy way i did

Don't manually unroll loops. If there are any possible optimisations that can be done to your code, the JIT will do them. Manually unrolling loops makes your code unreadable and is likely to adversely effect performance.

https://stackoverflow.com/questions/2684364/why-arent-programs-written-in-assembly-more-often/2685541#2685541

https://blog.overops.com/java-on-steroids-5-super-useful-jit-optimization-techniques/