Jump to content

How to make a client side command that can also be run on servers


outflows

Recommended Posts

So what I'm trying to do is pretty simple. I want to make a command that can be run by a player in order to open my mod's gui. The problem is that I want this to be entirely client side and also be able to run it on a server from the client. I know that I could just check whether or not the client types the command in chat by using a ServerChatEvent event but I want to know if there's actually a way to register a command for the client and not for the server and still make it possible to run said command while the client is on any server.

Link to comment
Share on other sites

3 hours ago, diesieben07 said:

ClientCommandHandler.

I tried to do that like this: 

ClientCommandHandler.instance.registerCommand(new ListTargetsCommand(new ArrayList<>(Arrays.asList("listtargets", "lt"))));

But for some reason this doesn't work when I join servers

 

Here are my classes for both the command in question and my commandbase class:

public class ListTargetsCommand extends CommandBase
{
	public ListTargetsCommand(ArrayList<String> alias)
	{
		super(alias, "ListTargets");
	}
	
	@Override
	public void execute(MinecraftServer server, ICommandSender sender, String[] args)
	{
		ArrayList<EntityPixelmon> pokes = PokemonDetection.getTargets();
		for(EntityPixelmon poke: pokes)
		{
			PokemonDetection.privateChat(poke.getPokemonName());
		}
	}
}
package com.outflows.pokalert.commands;


	import java.util.ArrayList;
	import java.util.List;

import net.minecraft.command.CommandException;
import net.minecraft.command.ICommand;
import net.minecraft.command.ICommandSender;
import net.minecraft.server.MinecraftServer;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.text.TextComponentString;

	public abstract class CommandBase implements ICommand
	{
	private ArrayList<String> aliases = new ArrayList<>();
	private String commandName;
	
	public CommandBase(ArrayList<String> aliasList, String commandName)
	{
		for(String word: aliasList)
		{
			this.aliases.add(word);
		}
		this.commandName = commandName;
	}

	public String getCommandName()
	{
		return this.commandName;
	}

	public String getCommandUsage(ICommandSender icommandsender)
	{
		return this.commandName+" <text/help>";
	}

	public List<String> getCommandAliases()
	{
		return this.aliases;
	}

	public void processCommand(ICommandSender icommandsender, String[] astring)
	{
		if(astring.length == 0)
		{
			icommandsender.sendMessage(new TextComponentString("Invalid Arguments. Usage: " + this.getCommandUsage(icommandsender)));
			return;
		}
		if (astring[0] == "help")
		{
			icommandsender.sendMessage(new TextComponentString("Usage: " + this.getCommandUsage(icommandsender)));
			return;
		} else {
		TextComponentString msg = new TextComponentString("Output: [");
		for (int i = 0;i < astring.length; ++i)
		{
			msg.appendText(" " + astring[i]);
		}
		msg.appendText(" ]");
		icommandsender.sendMessage(msg);	
		}
	}

	public boolean canCommandSenderUseCommand(ICommandSender icommandsender)
	{
	return true;
	}

	public List<?> addTabCompletionOptions(ICommandSender icommandsender,
	String[] astring)
	{
	return aliases;
	}

	@Override
	public boolean isUsernameIndex(String[] astring, int i)
	{
	return false;
	}

	@Override
	public int compareTo(ICommand arg0) {
		// TODO Auto-generated method stub
		return 0;
	}

	@Override
	public String getName() {
		// TODO Auto-generated method stub
		return this.commandName;
	}

	@Override
	public String getUsage(ICommandSender sender) {
		// TODO Auto-generated method stub
		return getCommandUsage(sender);
	}

	@Override
	public List<String> getAliases() 
	{
		return aliases;
	}

	@Override
	public void execute(MinecraftServer server, ICommandSender sender, String[] args) throws CommandException 
	{
		
	}

	@Override
	public boolean checkPermission(MinecraftServer server, ICommandSender sender) {
		// TODO Auto-generated method stub
		return true;
	}

	@Override
	public List<String> getTabCompletions(MinecraftServer server, ICommandSender sender, String[] args,
			BlockPos targetPos) 
	{
		return aliases;
	}
	}

 

Link to comment
Share on other sites

2 minutes ago, diesieben07 said:

Why did you make your own CommandBase class? For a start, it violates the Comparable interface contract. Please use Minecraft's CommandBase and only override the methods you need.

 

What does this do?

 

And clarify "doesn't work".

Oh ok, I was unaware that there was already a CommandBase class. That method just gets an arraylist of all the pokemon that I need to retrieve. When I say it doesn't work I mean that I'm just entirely unable to execute the command. All it says is that the command is unknown. I'll try doing what you said though and see if that works.

Link to comment
Share on other sites

6 minutes ago, diesieben07 said:

So...

You register your client command in an event that is fired by the server when it starts.

Find the error.

Yeah idk that's what someone said to do on a different forum. I didn't really think about it at the time but I see now

Link to comment
Share on other sites

2 hours ago, outflows said:

 


@EventHandler
    public void serverStarting(FMLServerStartingEvent event)
    {
    	ClientCommandHandler.instance.registerCommand(new ListTargetsCommand(new ArrayList<>(Arrays.asList("listtargets", "lt"))));
    }

 

I think you need to put that in the init function.  

I used ClientCommandHandler and it correctly registered the command, it just never displayed the GUI like it should.  

I use 

@EventHandler
    public void serverStarting(FMLServerStartingEvent event) {
        event.registerServerCommand(new ImageSpawnerCommand());
    }

ImageSpawnerCommand extends CommandBase. I don't know if that would work with a dedicated server though, I use it only for singleplayer.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.