Jump to content

[Unsolved] Detected leaking worlds in memory?


ThatBenderGuy

Recommended Posts

Okay so I finally get my tile entity to correctly save data but now I'm getting this message in my console

2013-03-29 09:37:39 [sEVERE] [ForgeModLoader] Detected leaking worlds in memory. There are 2 worlds that appear to be persisting. A mod is likely caching the world incorrectly

 

2013-03-29 09:53:19 [sEVERE] [ForgeModLoader] The world 878a1d2 (New World) has leaked.

 

And here is my code

package com.biosystemstudios;

import net.minecraft.block.Block;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.network.INetworkManager;
import net.minecraft.network.packet.Packet;
import net.minecraft.network.packet.Packet132TileEntityData;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.world.World;

public class CannonTileEntity extends TileEntity{
private boolean powered;
private int frontX;
private int frontY;
private int frontZ;
private long coolDownTime;
private String frontAxis;
private boolean negativeOnAxis;

/**
 * Reads a tile entity from NBT.
 */
public void readFromNBT(NBTTagCompound par1NBTTagCompound)
{
	super.readFromNBT(par1NBTTagCompound);
	this.powered = par1NBTTagCompound.getBoolean("power");
	this.frontX = par1NBTTagCompound.getInteger("fx");
	this.frontY = par1NBTTagCompound.getInteger("fy");
	this.frontZ = par1NBTTagCompound.getInteger("fz");
	this.coolDownTime = par1NBTTagCompound.getLong("cdt");
	this.frontAxis = par1NBTTagCompound.getString("fa");
	this.negativeOnAxis = par1NBTTagCompound.getBoolean("na");   
}

/**
 * Writes a tile entity to NBT.
 */
public void writeToNBT(NBTTagCompound par1NBTTagCompound)
{
	super.writeToNBT(par1NBTTagCompound);
	par1NBTTagCompound.setBoolean("power", powered);
	par1NBTTagCompound.setInteger("fx", frontX);
	par1NBTTagCompound.setInteger("fy", frontY);
	par1NBTTagCompound.setInteger("fz", frontZ);
	par1NBTTagCompound.setLong("cdt", coolDownTime);
	par1NBTTagCompound.setString("fa", frontAxis);
	par1NBTTagCompound.setBoolean("na", negativeOnAxis);
}

public boolean getPowered(){
	return powered;
}
public void powerOn(){
	powered = true;
}

public String destroy(){
	if(coolDownTime <= (this.worldObj.getTotalWorldTime())){
		if(this.worldObj.getBlockId(xCoord, yCoord-1, zCoord) == Block.obsidian.blockID){
			double Dir = 1.0;
			float power = 2.0f;

			if(negativeOnAxis){Dir = -1.0;}

			for(int steps = 1; steps < 256; steps++){
				if(steps<=3)
					power += 0.5f;
				if(frontAxis == "x"){
					this.worldObj.setBlock(frontX + (int)(steps*Dir), frontY, frontZ, 0);
					this.worldObj.createExplosion(null, frontX + (steps*Dir), ((double)frontY)+0.5, frontZ, power, true);
				}

				if(frontAxis == "z"){
					this.worldObj.setBlock(frontX, frontY, frontZ  + (int)(steps*Dir), 0);
					this.worldObj.createExplosion(null, frontX, frontY+0.5, ((double)frontZ) + (steps*Dir), power, true);
				}
			}

			powered = false;
			coolDownTime = (this.worldObj.getTotalWorldTime()) + 29*20;
			return "Fired Cannon, please wait " + getCoolDownTime() + " Seconds Before Using Again.";

		}else{
			powered = false;
			return "Cannon needs an obsidian base to operate";
		}
	}else{
		powered = false;
		return "Cannon Cooling down: "+getCoolDownTime() + " Seconds Left";
	}
}

public void setFrontOfCannon(int x, int y, int z){
	frontX = x;
	frontY = y;
	frontZ = z;
}

public void setFrontDirection(String axis, boolean nDirection){
	frontAxis = axis;
	negativeOnAxis = nDirection;
}

public long getCoolDownTime(){
	return ((coolDownTime - this.worldObj.getTotalWorldTime())/20)+1;
}

public Packet getDescriptionPacket()
   {
   NBTTagCompound tag = new NBTTagCompound();
   this.writeToNBT(tag);
   return new Packet132TileEntityData(this.xCoord, this.yCoord, this.zCoord, 1, tag);
  }

@Override
public void onDataPacket(INetworkManager net, Packet132TileEntityData packet)
{
	NBTTagCompound tag = packet.customParam1;
	this.readFromNBT(tag);
}


}

 

The thing about my tile entity saving data is that it will remember the private long coolDownTime variable but when I save and quit and leave my world it has seemed to forget all the other vars. I'm thinking it has something to do with the ForgeModLoader message in my console. Any thoughts or ideas on how to fix this?

Bumper Cars!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.