Jump to content

[1.13.2] Trying to make a custom potion effect


ketchup_god

Recommended Posts

I'm still a beginner modder, so I've been watching some tutorials on modding and I've decided to make a custom potion effect. I've scoured the internet trying to find a working tutorial, read the docs, and looked through the forums, but I still can't find anything that will help. Most of it is all in 1.12 and I can't find anything in 1.13. Please help!

Link to comment
Share on other sites

Thanks for your quick reply!

 

As a matter of fact, I have been trying to use a 1.12 tutorial. However, I always encounter errors that I can't fix.

For example, in my PotionInit class, I have 

public static final PotionEffect Restlessness = new CustomPotion()

so I created a new class called CustomPotion and wrote

public static CustomPotion(String name, boolean isBadPotion, int colour, int iconIndexX, int iconIndexY)
{
super(isBadPotion, colour);
setPotionName("effect." + name);
setIconIndex(iconIndexX, iconIndexY);
setRegistryName(new ResourceLocation(examplemod.modid + ":" + name));
}

However, eclipse gives me an error on PotionInit saying that I need to add values to the CustomPotion() constructor. When I apply the quick fix, eclipse gives me this:

public static final PotionEffect Restlessness = new CustomPotion(null, null, 0, 0, 0)

I'm wondering if this is what you were talking about in your reply about the static initializers. Is there a fix to my issue, or am I doing something wrong?

Link to comment
Share on other sites

57 minutes ago, ketchup_god said:

I'm wondering if this is what you were talking about in your reply about the static initializers. Is there a fix to my issue, or am I doing something wrong?

Well, yes, it is a static initializer.

 

All I can recommend to you is to learn java. Making minecraft mods requires an understanding of the language the mods are written in, you can't really make a mod without knowledge of the programming language you are using.

I mean I could say "you have created the constructor yourself, pass in the values that make sense" but even if you fix this issue with our help you will encounter new issues at every step going forward if you don't know the basics of java.

 

Link to comment
Share on other sites

Alright, one last question concerning forge methods.

In my CustomPotion class, I have this to get the GUI icon:

Minecraft.getMinecraft().getTextureManager().bindTexture(new ResourceLocation(examplemod.modid + "textures/gui/potion_effects.png"));

Eclipse keeps on telling me that getMinecraft() isn't a method for Minecraft. I'm pretty sure this is an issue with the outdated tutorial, so is there a way to do this in the current version?

Thanks again for your help.

Link to comment
Share on other sites

8 hours ago, ketchup_god said:

new ResourceLocation(examplemod.modid + "textures/gui/potion_effects.png"));

You need a comma instead of a plus sign here

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.