perigrine3 Posted April 27, 2019 Author Share Posted April 27, 2019 THANK YOU! Quote Link to comment Share on other sites More sharing options...
perigrine3 Posted April 27, 2019 Author Share Posted April 27, 2019 Could I use that to disable recipes too? Quote Link to comment Share on other sites More sharing options...
DavidM Posted April 27, 2019 Share Posted April 27, 2019 (edited) 52 minutes ago, perigrine3 said: Could I use that to disable recipes too? Yes. Do something similar to that. (that was terribly explained, sorry) I meant you should do something logically similar: iterate through the list of recipes and remove the recipe if it matches certain criteria. Edited April 27, 2019 by DavidM Quote Some tips: Spoiler Modder Support: Spoiler 1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code. 2. Always post your code. 3. Never copy and paste code. You won't learn anything from doing that. 4. Quote Programming via Eclipse's hotfixes will get you nowhere 5. Learn to use your IDE, especially the debugger. 6. Quote The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it. Support & Bug Reports: Spoiler 1. Read the EAQ before asking for help. Remember to provide the appropriate log(s). 2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support. Link to comment Share on other sites More sharing options...
perigrine3 Posted April 27, 2019 Author Share Posted April 27, 2019 (edited) So I found this online (for removing RECIPES): @SubscribeEvent public static void registerRecipes(RegistryEvent.Register<IRecipe> event) { ResourceLocation theButton = new ResourceLocation("minecraft:wooden_button"); IForgeRegistryModifiable modRegistry = (IForgeRegistryModifiable) event.getRegistry(); modRegistry.remove(theButton); } And using your code, nov4e (for removing ITEMS associated with Minecraft): @SubscribeEvent public void hideCreativeItems(FMLPostInitializationEvent event) { for(Item item : ForgeRegistries.ITEMS) { if(item.getCreatorModId(new ItemStack(item)).equals("minecraft")) { item.setCreativeTab(null); } } } I created this: @SubscribeEvent public void removeRecipes(RegistryEvent.Register<IRecipe> event) { for(IRecipe recipe : ForgeRegistries.RECIPIES) { if(recipe.getCreatorModId(new ResourceLocation(recipe)).equals("minecraft")) { modRegistry.remove(recipe); } } } I figured if I made a variable for the recipe, it would work for all of them, especially if I used nov4e's code to make it apply only to items in vanilla Minecraft, but instead of items, recipes. I assumed because both are part of the ForgeRegistries, it could be applied similarly to both. It's very likely that I'm off, but I feel like I can't be TOO far off. I'm still new to coding java and I'm only using prior coding knowledge to guess my way through my problems, but I am trying, and I do understand what a good portion of this code means, it's only some parts I don't understand, and the big words make it difficult. Edited April 27, 2019 by perigrine3 Quote Link to comment Share on other sites More sharing options...
DavidM Posted April 27, 2019 Share Posted April 27, 2019 (edited) Don't put it in the IRecipe registry event; put it in something like the post init instead. Edited April 27, 2019 by DavidM 1 Quote Some tips: Spoiler Modder Support: Spoiler 1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code. 2. Always post your code. 3. Never copy and paste code. You won't learn anything from doing that. 4. Quote Programming via Eclipse's hotfixes will get you nowhere 5. Learn to use your IDE, especially the debugger. 6. Quote The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it. Support & Bug Reports: Spoiler 1. Read the EAQ before asking for help. Remember to provide the appropriate log(s). 2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support. Link to comment Share on other sites More sharing options...
Cadiboo Posted April 27, 2019 Share Posted April 27, 2019 On 4/27/2019 at 1:08 AM, nov4e said: You can just hide every item doing: for(Item i : ForgeRegistries.ITEMS) { if(i.getCreatorModId(new ItemStack(i)).equals("minecraft")) { i.setCreativeTab(null); } } That means for every item in forge, if the item has the modid "minecraft" it will set the item's creative tab to null. Use Item.getRegistryName().getDomain().equals(modid) instead. Quote About Me Spoiler My Discord - Cadiboo#8887 My Website - Cadiboo.github.io My Mods - Cadiboo.github.io/projects My Tutorials - Cadiboo.github.io/tutorials Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support. When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible. Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme) Link to comment Share on other sites More sharing options...
perigrine3 Posted April 28, 2019 Author Share Posted April 28, 2019 But won't that get stuff that ISN'T vanilla too? I mean, I'm probably wrong cuz I'm a noob, but still, just want to check before I use it. Quote Link to comment Share on other sites More sharing options...
perigrine3 Posted April 28, 2019 Author Share Posted April 28, 2019 (edited) I know what the code does though, just so nobody thinks I have no clue. I just don't know what the modid part is. Edited April 28, 2019 by perigrine3 Quote Link to comment Share on other sites More sharing options...
DavidM Posted April 28, 2019 Share Posted April 28, 2019 2 hours ago, perigrine3 said: I know what the code does though, just so nobody thinks I have no clue. I just don't know what the modid part is. That is for checking whether the item's domain is equal to something... The method names should be pretty self-explanatory. Quote Some tips: Spoiler Modder Support: Spoiler 1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code. 2. Always post your code. 3. Never copy and paste code. You won't learn anything from doing that. 4. Quote Programming via Eclipse's hotfixes will get you nowhere 5. Learn to use your IDE, especially the debugger. 6. Quote The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it. Support & Bug Reports: Spoiler 1. Read the EAQ before asking for help. Remember to provide the appropriate log(s). 2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support. Link to comment Share on other sites More sharing options...
nov4e Posted April 28, 2019 Share Posted April 28, 2019 4 hours ago, perigrine3 said: I know what the code does though, just so nobody thinks I have no clue. I just don't know what the modid part is. Well, when you execute the command /give in game, you need to put "minecraft:the_item_you_want" right? Well, forge consider minecraft as a mod so the minecraft modid is simply "minecraft". Quote Link to comment Share on other sites More sharing options...
perigrine3 Posted April 29, 2019 Author Share Posted April 29, 2019 Okay, that makes sense. Quote Link to comment Share on other sites More sharing options...
perigrine3 Posted April 29, 2019 Author Share Posted April 29, 2019 This doesn't appear to be working, but I don't know why: //Removes existing recipes// @SubscribeEvent public void removeRecipes(FMLPostInitializationEvent event) { for(IRecipe recipe : ForgeRegistries.RECIPIES && Item item : ForgeRegistries.ITEMS) { if(recipe.getCraftingResult(new ResourceLocation(item)).equals("minecraft")) { IForgeRegistryModifiable.remove(recipe); } } } I don't see why it is wrong. Before, I hadn't put in the && Item item : ForgeRegistries.ITEMS, but now that I have it, ResourceLocation can work correctly, using the getCraftingResult method to get the item, and then connect it with ForgeRegistries, but it doesn't seem to be working. What could it be? Quote Link to comment Share on other sites More sharing options...
DavidM Posted April 29, 2019 Share Posted April 29, 2019 (edited) The iterable of items is not necessarily in the same order as the iterable of recipes. In fact, they might not even be the same size. I don't see why you need to iterate through the items; just go through all the recipes and remove them if the result match a certain criteria. Is that even going to compile though? I've never seen such syntax before. Edited April 29, 2019 by DavidM Quote Some tips: Spoiler Modder Support: Spoiler 1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code. 2. Always post your code. 3. Never copy and paste code. You won't learn anything from doing that. 4. Quote Programming via Eclipse's hotfixes will get you nowhere 5. Learn to use your IDE, especially the debugger. 6. Quote The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it. Support & Bug Reports: Spoiler 1. Read the EAQ before asking for help. Remember to provide the appropriate log(s). 2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support. Link to comment Share on other sites More sharing options...
Draco18s Posted April 30, 2019 Share Posted April 30, 2019 19 hours ago, perigrine3 said: if(recipe.getCraftingResult(new ResourceLocation(item)).equals("minecraft")) { "Get the crafting result, is that object equal to the string 'minecraft'?" Almost certainly not. 1 Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given. Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.