Jump to content

[1.13.2] GUI wont open


TheRedMelon

Recommended Posts

I right click on the block and nothing happens.  All relevant code below.  If I'm missing something you need to see, just let me know ?.

I've looked at previous threads where people ask for help and looked for their code as examples but can't figure out where I'm going wrong.

 

GUI Class:

Spoiler

public class GUIThreefoldCombiner extends GuiContainer {
	
	private static final ResourceLocation TEXTURE = new ResourceLocation(Reference.MOD_ID + ":textures/gui/threefold_combiner.png");
	
	public GUIThreefoldCombiner(InventoryPlayer inventory, TileEntityThreefoldCombiner te) {
		
		super(new ContainerThreefoldCombiner(inventory, te));
		
	}
	
	@Override
	public void render(int mouseX, int mouseY, float partialTicks) {

		drawDefaultBackground();
		super.render(mouseX, mouseY, partialTicks);
		renderHoveredToolTip(mouseX, mouseY);
		
	}

	@Override
	protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) {
		
		mc.getTextureManager().bindTexture(TEXTURE);
		drawModalRectWithCustomSizedTexture(guiLeft, guiTop, 0, 0, xSize, ySize, xSize, ySize);
		
	}
	
}

 

 

Main Class with GUI Handler:

Spoiler

@Mod(Reference.MOD_ID)
public class EnhancedMechanisms {

	public EnhancedMechanisms() {
		
		ModLoadingContext.get().registerExtensionPoint(ExtensionPoint.GUIFACTORY, () -> {
			
			return (OpenContainer) -> {
				
				ResourceLocation loc = OpenContainer.getId();
				
				if (loc.toString().equals(Reference.MOD_ID + ":threefold_combiner")) {
					
					EntityPlayerSP player = Minecraft.getInstance().player;
					BlockPos pos = OpenContainer.getAdditionalData().readBlockPos();
					TileEntity te = player.world.getTileEntity(pos);
					
					if (te instanceof TileEntityThreefoldCombiner) {
						
						return new GUIThreefoldCombiner(player.inventory, (TileEntityThreefoldCombiner) te);
						
					}
					
				}
				
				return null;
				
			};
			
		});
		
	}
	
}

 

 

onBlockActived:

Spoiler

	@Override
	public boolean onBlockActivated(IBlockState state, World worldIn, BlockPos pos, EntityPlayer player, EnumHand hand, EnumFacing side, float hitX, float hitY, float hitZ) {
		
		if (worldIn.isRemote) {
			
			return true;
			
		} else {
			
			TileEntity tEntity = worldIn.getTileEntity(pos);
			
			if (tEntity instanceof TileEntityThreefoldCombiner) {
				
				NetworkHooks.openGui((EntityPlayerMP) player, (TileEntityThreefoldCombiner) tEntity, pos);
				
			}
			
			return true;
			
		}
		
	}

 

 

Tile Entity createContainer & getGuiID:

Spoiler

	@Override
	public Container createContainer(InventoryPlayer playerInventory, EntityPlayer playerIn) {

		return new ContainerThreefoldCombiner(playerInventory, this);
		
	}

	@Override
	public String getGuiID() {

		return Reference.MOD_ID + ":threefold_combiner";
		
	}

 

 

Tile Entity Registry:

Spoiler

	public static TileEntityType<TileEntityThreefoldCombiner> tileEntityThreefoldCombiner;

	@SubscribeEvent
	public static void OnRegisterTileEntities (RegistryEvent.Register<TileEntityType<?>> e) {
		
		tileEntityThreefoldCombiner = TileEntityType.register(Reference.MOD_ID + ":threefold_combiner", TileEntityType.Builder.create(TileEntityThreefoldCombiner::new));
		
	}

 

 

Thanks for any help.

Link to comment
Share on other sites

9 hours ago, TheRedMelon said:

new ResourceLocation(Reference.MOD_ID + ":textures/gui/threefold_combiner.png");

Don’t use this constructor, use the constructor that takes in your modid and the path as separate parameters.

 

9 hours ago, TheRedMelon said:

NetworkHooks.openGui((EntityPlayerMP) player, (TileEntityThreefoldCombiner) tEntity, pos);

I’m not sure that this is the correct way to open a mod GUI in 1.13.2.

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

above the method openGui in NetworkHooks, it specifically says "Request to open a GUI on the client, from the server", so I'm pretty sure this isn't the correct method. We used to use the openGui method in EntityPlayer, but that no longer exists, nor does the class FMLNetworkHandler exist.

Edited by KingIceCream
Link to comment
Share on other sites

Hold on, try replacing 

if (worldIn.isRemote) {
			
	return true;
			
} else {
			
	TileEntity tEntity = worldIn.getTileEntity(pos);
			
	if (tEntity instanceof TileEntityThreefoldCombiner) {
				
		NetworkHooks.openGui((EntityPlayerMP) player, (TileEntityThreefoldCombiner) tEntity, pos);
				
	}
			
	return true;
			
}

with

if (!worldIn.isRemote) {
			
	TileEntity tEntity = worldIn.getTileEntity(pos);
	NetworkHooks.openGui((EntityPlayerMP) player, (TileEntityThreefoldCombiner) tEntity, pos);
}
return true;

 

Link to comment
Share on other sites

I'm using the proper ResourceLocation  constructor now.

I tried changing that code like KingIceCream said, it basically does the same thing though so nothing changed.  I followed it through with the debugger and it gets to the GUI Factory and runs

return new GUIThreefoldCombiner(player.inventory, (TileEntityThreefoldCombiner) te);

So I think the issue is with the GUI or Container perhaps.

Link to comment
Share on other sites

4 hours ago, KingIceCream said:

Could you post or dm me all of the code so I can try to debug it more easily? (Like, all the code.

The best way to do this is to post your code as a working GitHub repository 

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Can you post your code as a GitHub repo?

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.