Jump to content

[1.12.2] Only drop when killed by a certain weapon.


FrostBytes

Recommended Posts

To be more specific:

I have a chance for a item to drop when killed normally. However, it's ridiculously small, so it basically means you'd have to be really lucky to get the drop.

However, there's an item in my mod, that lets you significantly increase the chances of this item being dropped. How would I do that?

Epic Website

Link to comment
Share on other sites

Just now, diesieben07 said:

DamageSource#getTrueSource will give you the entity causing the damage, if there is any. You can then check if it's a living entity (instanceof EntityLivingBase) and if so use EntityLivingBase#getHeldItemMainhand to get the held item. Check if that item is yours and if so, increase the drop chance.

How would I "increase the drop chance?"

Currently I have no loot tables or any of the sort set up. Would it just be spawning the item entity?

Epic Website

Link to comment
Share on other sites

The easiest way would be to create an event handler for LivingDropsEvent, and detect the item held in the player's hand. If all conditions match, spawn the drop(s) at the position of the event (the position of the EntityLiving that was killed).

 

What you are trying to create sounds very similar to Draconic Evolution's mob soul system.

You might want to check out Brandon's code for it here.

Edited by DavidM
  • Like 1

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

8 hours ago, diesieben07 said:

No. How are you currently creating your drop?

I’m not. I was just asking in case I started to do something and then someone presented a solution for something else.

7 hours ago, DavidM said:

The easiest way would be to create an event handler for LivingDropsEvent, and detect the item held in the player's hand. If all conditions match, spawn the drop(s) at the position of the event (the position of the EntityLiving that was killed).

I’ll try that when I can.

Epic Website

Link to comment
Share on other sites

8 hours ago, diesieben07 said:

DamageSource#getTrueSource will give you the entity causing the damage

I would just use DamageSource#getImmediateSource(). Because otherwise when you shot an arrow with your bow and swap to the item that increases the drop chance. You would get the increased drop chance without using the item.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.