Jump to content

[1.13.2] unFormattedComponentText not Equaling a String


cleardragonf

Recommended Posts

 

Hello So I run the below code

 	@SubscribeEvent
	public void arrowNocked(PlayerEvent.ItemPickupEvent event)
	{
		if(event.getStack().getItem().getDisplayName(null).getUnformattedComponentText().toString() =="Arrow"){
			logger.error(event.getPlayer().getName().getFormattedText()+ " has collected a Diamond at" + event.getPlayer().getPosition());
		}else{
			
			logger.warn("Hmm Doesn't seem to be working at all" + event.getStack().getItem().getDisplayName(null).getUnformattedComponentText().toString());
		}
		
	}

 

However I get the below result

Quote

[21:20:38.838] [Server thread/INFO] [dedicated.DedicatedServer/]: ºeCleardragonf joined the gameºr
[21:20:43.424] [Server thread/WARN] [asuramagica/]: Hmm Doesn't seem to be working at allArrow

Could Someone Please Explain Why it keeps going to the else? when i pick up an Arrow?

Link to comment
Share on other sites

1. Use String#equals when possible. Since strings are not primitive types, 

str_1 == str_2

will return false even if both strings are the same value given that both strings does not point to the same object.

 

2. Checking an item's type with its name is not accurate, as an item's name can be changed. Check the registry name or use some other methods of checking instead.

Edited by DavidM
  • Thanks 1

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

14 hours ago, DavidM said:

Your if statement will never be true.

String is not a primitive type, so


"Hello World" == "Hello World"

will always return false.

Use String#equals instead.

hmmm yea i didn't know that...my java is very basic and i've had .toString() == "asdf" work before in pure java...so i'll use the Equals() Thanks.

 

9 hours ago, diesieben07 said:

First of all, why do you call all of your event handlers arrowNocked? ?

Also, that is not how you check for something being an arrow. Make a tag for it or use some other kind of proper check. Checking the name of an item is not appropriate to determine what it is.

lol cause i'm learning i'm overwritten the same method over and over.  I'm learning to do things like i say...this is my first time ever getting into modding for minecraft...so i'm trying different things to understand the code a bit better and logic.  Could you explain why I would use Tag vs checking the name of an item? the reason i'm doing the name of an item is because once i figure out how to make items i may want to do things based upon picking that item up.

Link to comment
Share on other sites

19 hours ago, DavidM said:

Your if statement will never be true.

String is not a primitive type, so


"Hello World" == "Hello World"

will always return false.

Use String#equals instead.

Not quite, you are comparing 2 constants in that and because the JVM does some stuff with string constants to make them the same object, this expression will be true. However 

new String("Hello World") == new String("Hello World")

will always be false as they are not the same object 

  • Like 1

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

26 minutes ago, Cadiboo said:

Not quite, you are comparing 2 constants in that and because the JVM does some stuff with string constants to make them the same object, this expression will be true. However 

Thanks for the clarification.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.