[SOLVED]Delay TileEntity removal when block broken in creative mode.

[TheMCJavaFre4k 1]

Hi There

Im wanting to prevent the tile entity of a block from being removed until after Ive executed some code within the tile entity via a custom packet.

 

Im able to get this working in survival mode by sending the packet within the getDrops method and delaying removal until the harvestBlock method(Similar to blockFlowerPot) as so:

Spoiler

@Override
	public void getDrops(net.minecraft.util.NonNullList<ItemStack> drops, IBlockAccess worldIn, BlockPos pos, IBlockState state, int fortune)
	{
		super.getDrops(drops, worldIn, pos, state, fortune);
		World world = (World)worldIn;

		TileEntityDJDeck te = world.getTileEntity(pos) instanceof TileEntityDJDeck ? (TileEntityDJDeck)world.getTileEntity(pos) : null;

		System.out.println("Called Get Drops");

		if (te != null) {

			System.out.println("Sending Stop To Server");

			MCDJMod.network.sendToAllAround(new PacketPlaySoundOnClient(pos, 0, 3), new NetworkRegistry.TargetPoint(world.provider.getDimension(), pos.getX(), pos.getY(), pos.getZ(), 20)); 

		}

	}

	@Override
	public void harvestBlock(World world, EntityPlayer player, BlockPos pos, IBlockState state, @Nullable TileEntity te, ItemStack tool)
	{
		super.harvestBlock(world, player, pos, state, te, tool);

		System.out.println("Harvesting");

		world.setBlockToAir(pos);
		world.removeTileEntity(pos);
	}

	@Override
	public boolean removedByPlayer(IBlockState state, World world, BlockPos pos, EntityPlayer player, boolean willHarvest) {
		return true; 
	}

 

 Currently when broken in creative, nothing happens(Only breaking particles). I was initially using breakBlock but that didn't provide enough time for the packet to be read and when it was, the tile entity at the BlockPos was already removed.

Im just not sure what methods would provide the necessary time or how i would modify the above setup to work for creative mode.

Edited February 27, 2019 by TheMCJavaFre4k
Solved

[Cadiboo 300]

Why are you trying to do this? You can probably send whatever data you need in the packet

[TheMCJavaFre4k 1]

1 minute ago, Cadiboo said:

Why are you trying to do this? You can probably send whatever data you need in the packet

My tile entity has a few methods responsible for stopping sound playback. The packet is used to update all nearby clients to stop any sound the TileEntity is making before it is removed. So in the packet handler I'm getting the TileEntity from the position sent over the packet and calling my methods on the client from there.

[Cadiboo 300]

Couldn’t you subscribe to the sound play event and cancel it?

[TheMCJavaFre4k 1]

6 minutes ago, Cadiboo said:

Couldn’t you subscribe to the sound play event and cancel it?

I haven't dealt with any Events thus far other than the standard registration ones so I wouldn't know where to begin. They current way I'm dealing with sounds is by using a custom MovingSound class(So to update positioning) being played by Minecraft.getMinecraft().getSoundHandler().playSound(). I can then stop it by passing in the exact same sound. This allows me to differentiate the exact same sound being played from 2 TileEntities and stop them independent of one another. Is this same functionality obtainable using a @SubscribeEvent and subscribing to the PlaySoundEvent class?

[Draco18s 2131]

Option (a) include all of the relevant parameters in the packet so you don't need the TE.

 

Option (b) use an ITickableSound in order for it to terminate itself when its source block is removed.

https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/ores/client/SoundWindmill.java#L37

[TheMCJavaFre4k 1]

7 hours ago, Draco18s said:

Option (b) use an ITickableSound in order for it to terminate itself when its source block is removed.

https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/ores/client/SoundWindmill.java#L37

I totally forgot to check if I could use the sound to stop itself. I guess I just had tunnel vision when looking at the problem. Considering my custom sound is a tickable sound, this works flawlessly. Thanks heaps!