[Solved] [1.12.2] Placing structures in ChunkGenerator causes "cascading worldgen" errors

[MajikalExplosions]

Hi!  I'm new to MC modding, so I'm not too sure whether the format of this post is correct or not - if it isn't, please let me know how to change it in the future.

 

I'm working on a mod that generates one structure (16*y*16, y is anywhere between 4 and 32) in every chunk(it's supposed to completely fill the chunk on the surface from 0,0 to 16,16), which is why it's 16 blocks wide and 16 blocks long).  The structures are in .nbt files that load like they're supposed to and show up in-game - sometimes.  However, the structures aren't showing up in every chunk; rather, they show up only close to the chunk 0, 0 and are randomly scattered all over.  When I teleport myself over, it says that my mod is causing "cascading worldgen" issues.  I'm pretty sure it's because my structures aren't spawning in the chunks like they're supposed to and instead are overlapping into other chunks.  My problem is that I don't know why this happens and how to fix it.

 

Below is the code snippet from my ChunkGenerator class (yes, it implements IChunkGenerator).  I overrode the generateStructures function and added my own code.  I am aware that this is probably a terrible way to do this (it's probably in the wrong function and class), but I'm not sure how to make it better.  Can I have some advice?

 

@Override
    public boolean generateStructures(Chunk chunkIn, int x, int z) {//chunkIn isn't used.
    	PlacementSettings ps = new PlacementSettings().setRotation(BuildingGenerator.getRotation(x, z));//getRotation returns a random Rotation (EX Rotation.NONE, Rotation.CLOCKWISE_90)
        buildingGenerator.getBuilding(x, z).addBlocksToWorldChunk(world, new BlockPos(x * 16, BUILDING_Y_VALUE, z * 16), ps);//buildingGenerator.getBuilding(x, z) returns an object of class Template that is read from a .nbt file created by a structure block.
    	return false;//It crashes when I return true...?  I'm not sure why.
	}

 

If you need more clarification, I can always provide more information.  The crash log is attached.  Thanks in advance!

 

Edited February 7, 2019 by MajikalExplosions

[Draco18s]

 

[MajikalExplosions]

Hi!  I have already seen that article on Reddit, but I'm not sure how I should go about carrying out the solution.  The Reddit post says:

Quote

The solution is often very simple, they just need an offset. 

However, I don't know how to add the offset.  Do I just rewrite the code to generate

buildingGenerator.getBuilding(x, z).addBlocksToWorldChunk(world, new BlockPos(x * 16 - 8, BUILDING_Y_VALUE, z * 16 - 8), ps);//buildingGenerator.getBuilding(x, z) returns an object of class Template that is read from a .nbt file created by a structure block.

I've tried that before, but it still doesn't work.  It still prints the error, and behaves just like how it was without the change.  Hints, maybe?  Thank you for taking your time to help me.

 

 

 

P.S.: Here's the error in case it helps:

[Server thread/WARN] [FML]: Tutorial Dimension loaded a new chunk [33, 20] in dimension 0 (overworld) while populating chunk [35, 22], causing cascading worldgen lag.

[Draco18s]

On 2/5/2019 at 8:32 PM, MajikalExplosions said:

int x, int z

You see these? 

Have you tried adding 8 to them before you use them? No? Why not?

[MajikalExplosions]

Yes, I have.  It's what I meant by "I've tried that before, but it still doesn't work."  I found a workaround that does practically the same thing yesterday, so I guess I should mark this as solved.  Thank you for trying to help me regardless.

[Draco18s]

On 2/6/2019 at 7:16 PM, MajikalExplosions said:

x * 16

Are you sure about this? I thought x and z were already block coordinates.
Also, you should use <<4 to avoid issues with negative values being incorrectly rounded when dealing with chunk<->block conversions.

[MajikalExplosions]

Hi,

 

The x and z are chunk coordinates.  Also - I was able to solve the problem.  I just moved everything to a worldgenerator (which I should have done already).  Thanks for the help!