Need Help With Death Event

[Scorpyon04]

Im trying to make a mod that plays a sound when a you kill a player.

this is my code

package scorpyon04.bloodeffect;

import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;

@Mod(modid = Reference.MOD_ID, name = Reference.MOD_NAME, version = Reference.MOD_NAME)
public class BloodEffect {

	public static void preInit(FMLPreInitializationEvent event) {

	}
	public static void Init(FMLInitializationEvent event) {
		System.out.println("Blood Effect Init");
		MinecraftForge.EVENT_BUS.register(new DeathEventHandler());
	}
	public static void postInit(FMLPostInitializationEvent event) {

	}
}

and My DeathEventHandler

package scorpyon04.bloodeffect;

import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraftforge.event.entity.living.LivingDeathEvent;

public class DeathEventHandler {
	public void onLivingDeath(LivingDeathEvent event){
		Entity e = event.entity;
		if (e instanceof EntityPlayer) {
			EntityPlayer killedplr = (EntityPlayer) e;
			if (event.source.getSourceOfDamage() instanceof EntityPlayer) {
				EntityPlayer plr = (EntityPlayer) event.source.getEntity();
				plr.playSound("dig.stone", 1000.0f, 1.0f);
			}
		}
	}
}

when im in game nothing happens when i kill a player

 

[Eiachh]

public class DeathEventHandler {

       @SubscribeEvent
	public void onLivingDeath(LivingDeathEvent event){
		Entity e = event.entity;
		if (e instanceof EntityPlayer) {
			EntityPlayer killedplr = (EntityPlayer) e;
			if (event.source.getSourceOfDamage() instanceof EntityPlayer) {
				EntityPlayer plr = (EntityPlayer) event.source.getEntity();
				plr.playSound("dig.stone", 1000.0f, 1.0f);
			}
		}
	}
}


use @subscribe event on top of the event and register This class"DeathEventHandler"
in the preInit

@EventHandler
public void preInit(FMLPreInitializationEvent event) {

MinecraftForge.EVENT_BUS.register(new DeathEventHandler());

}
I swear this site refuses to register what i write normally

Edited January 2, 2019 by Eiachh

[Scorpyon04]

Subscribe event is error and i cant import it btw im using 1.8.9 forge

 

[Eiachh]

3 minutes ago, Scorpyon04 said:

Subscribe event is error and i cant import it btw im using 1.8.9 forge

 

Well I only used forge for 1.12 but this would be the import. Otherwise sorry no idea.

 

import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

[Scorpyon04]

Quote

Thanks for the import its there is no error now and ima try ingame

 

[Scorpyon04]

Still cant hear it

[Scorpyon04]

12 minutes ago, Eiachh said:

Well I only used forge for 1.12 but this would be the import. Otherwise sorry no idea.

 

import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

This Worked But the mod still isnt working

[Eiachh]

12 minutes ago, Scorpyon04 said:

Still cant hear it

@SubscribeEvent
	public void reeewdyeven(LivingDeathEvent event){
		if (event.getEntityLiving() instanceof  EntityPlayer || event.getEntityLiving() instanceof  EntityPlayerMP){
			System.out.println("asd");
		}
	}

https://cdn.discordapp.com/attachments/526458081329152002/529999484885925918/unknown.png
 

Try this if its printing then solve the sound. Ihave no clue to sounds in minecraft yet

[Scorpyon04]

how can i see if its printing

 

im testing this on a vanilla server

 

Edited January 2, 2019 by Scorpyon04
More Info

[Eiachh]

Just now, Scorpyon04 said:

how can i see if its printing

Its in the console on your environment in Intellij IDE its there:
https://cdn.discordapp.com/attachments/526458081329152002/530000677305319434/unknown.png

In eclipse probably the same placement but in white tho

[Scorpyon04]

ya but i have to build the jar so i cant see it in my ide

[TestingSubject002]

1 minute ago, Scorpyon04 said:

ya but i have to build the jar so i cant see it in my ide

Look in the log then.

[Scorpyon04]

Wheres the log lol

 

[TestingSubject002]

1 minute ago, Scorpyon04 said:

Wheres the log lol

 

Are you running your mod on server? If yes, post server_folder/logs/latest.log

[Scorpyon04]

its not my server

[TestingSubject002]

1 minute ago, Scorpyon04 said:

its not my server

Wait. You only have mod on clients, but not on the server?

Edited January 2, 2019 by TestingSubject002

[Scorpyon04]

im trying to make a mod that shows particles when you kill someone for hypixel and only the player with the mod can see it

 

[Eiachh]

Now you legit made me confused. Bro if you build something it won't magically get applied on the server.

[Eiachh]

1 minute ago, Scorpyon04 said:

im trying to make a mod that shows particles when you kill someone for hypixel and only the player with the mod can see it

 

Why dont you run the mod from the developer environment tho?

[Scorpyon04]

I know

but like i have mods like cps counter with display cps i wont a mod like that but it displays particles for the person using the mod not everyone on the server

[TestingSubject002]

Just now, Scorpyon04 said:

im trying to make a mod that shows particles when you kill someone for hypixel and only the player with the mod can see it

 

Event is called on Server side, but not on Client side.

[Scorpyon04]

 

Just now, TestingSubject002 said:

Event is called on Server side, but not on Client side.

Is there a way to make it on client side

[TestingSubject002]

6 minutes ago, Scorpyon04 said:

 

Is there a way to make it on client side

Yes. Give me a minute.

 

EDIT: Sorry, I don't know how. I thought that I saw client-side events.

Edited January 2, 2019 by TestingSubject002

[Scorpyon04]

15 minutes ago, TestingSubject002 said:

Yes. Give me a minute.

 

EDIT: Sorry, I don't know how. I thought that I saw client-side events.

Damn

 

[Eiachh]

6 minutes ago, Scorpyon04 said:

Damn

 

@SubscribeEvent
	public void reeewdyeven(LivingDeathEvent event){
		if (event.getEntityLiving() instanceof  EntityPlayer || event.getEntityLiving() instanceof  EntityPlayerMP){
			System.out.println("asd");
			Minecraft mc = Minecraft.getMinecraft();
			mc.player.sendChatMessage("asdasd");

		}
	}

This event is clientsided as well tho idk what you were talking about

So now you dont have to look for the log files