Jump to content

Coremod not working


Alex_Wells

Recommended Posts

Hello there. I'm writing a mod, and I need to modify minecraft's code so I can see barrier blocks depending on my method's result. So there's a singleton with one method specifically for this, called like this (returns bool):
 

AlwaysShowBarriersManager.instance().isEnabled()

 

Minecraft code, responsible for displaying barrier particles is in the "net.minecraft.client.multiplayer.WorldClient" class:

public void doVoidFogParticles(int p_doVoidFogParticles_1_, int p_doVoidFogParticles_2_, int p_doVoidFogParticles_3_) {
        int i = 16;
        Random random = new Random();
        ItemStack itemstack = this.mc.thePlayer.getHeldItem();
        boolean flag = this.mc.playerController.getCurrentGameType() == GameType.CREATIVE && itemstack != null && Block.getBlockFromItem(itemstack.getItem()) == Blocks.barrier;
        MutableBlockPos blockpos$mutableblockpos = new MutableBlockPos();

        for(int j = 0; j < 1000; ++j) {
            int k = p_doVoidFogParticles_1_ + this.rand.nextInt(i) - this.rand.nextInt(i);
            int l = p_doVoidFogParticles_2_ + this.rand.nextInt(i) - this.rand.nextInt(i);
            int i1 = p_doVoidFogParticles_3_ + this.rand.nextInt(i) - this.rand.nextInt(i);
            blockpos$mutableblockpos.set(k, l, i1);
            IBlockState iblockstate = this.getBlockState(blockpos$mutableblockpos);
            iblockstate.getBlock().randomDisplayTick(this, blockpos$mutableblockpos, iblockstate, random);
            if (flag && iblockstate.getBlock() == Blocks.barrier) {
                this.spawnParticle(EnumParticleTypes.BARRIER, (double)((float)k + 0.5F), (double)((float)l + 0.5F), (double)((float)i1 + 0.5F), 0.0D, 0.0D, 0.0D, new int[0]);
            }
        }

    }

 

So what I want to do is alter "flag" variable, like this:

 

boolean flag =
                (this.mc.playerController.getCurrentGameType() == GameType.CREATIVE && itemstack != null && Block.getBlockFromItem(itemstack.getItem()) == Blocks.barrier) ||
                        my.mod.package.AlwaysShowBarriersManager.instance().isEnabled();

or

if(!flag) {
	flag = my.mod.package.AlwaysShowBarriersManager.instance().isEnabled();
}

 

Both solutions would work. What I usually do with coremod's ClassTransformers is I copy the whole class into same package in my mod's src folder, then modify what I need and ASMify it using IDEA plugin. I receive such code in result:

mv = cw.visitMethod(ACC_PUBLIC, "doVoidFogParticles", "(III)V", null, null);
mv.visitCode();
// blablabla
mv.visitEnd();


My ClassTransformer's transform method looks like this (simplified):

ClassNode classNode = new ClassNode();
ClassReader classReader = new ClassReader(bytes);
ClassWriter classWriter = new ClassWriter(ClassWriter.COMPUTE_FRAMES | ClassWriter.COMPUTE_MAXS);

classReader.accept(classNode, ClassReader.EXPAND_FRAMES);

// find needed method

MethodVisitor mv = classWriter.visitMethod(); // arguments blablabla

// visit code

classReader.accept(methodReplacer, ClassReader.EXPAND_FRAMES);

return classWriter.toByteArray();

 

If I try to run this, the game crashes: https://pastebin.com/0hp3EsqU

Auto-generated "visit code": https://pastebin.com/ivuabcZv

 

What am I missing here? I know that I shouldn't use coremods, but there's no way around it, so I'm forced to use them.

Link to comment
Share on other sites

Don't make coremods.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

5 minutes ago, Alex_Wells said:

What am I missing here? I know that I shouldn't use coremods, but there's no way around it, so I'm forced to use them.

Coremods are not supported on this forum, a moderator will most likely close this thread.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Just now, diesieben07 said:

Especially not if you don't know what you are doing.

And yes, your approach to this shows that you absolutely do not know what you are doing. Don't go around replacing entire methods.

At first I just wanted to replace couple instructions with my own, but I'm kind of lazy to rewrite my whole "method transformer" system in order to achieve that. And I feel like this won't fix the problem =/

Link to comment
Share on other sites

  • Guest locked this topic
Guest
This topic is now closed to further replies.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.