Jump to content

When moving an item in creative inventory, it loses its NBT!


CAS_ual_TY

Recommended Posts

Hello!

Basically, I have an item which saves a lot of NBT data to an itemstack. Now, this data can become so huge, that when updating the data to the client, the client would be disconnected because of a too big packet. Now, this information is not needed on the client, so I disabled the updating of the NBT to the client.

 

Everything works fine now, except for one thing: When moving the item around in the inventory, while in creative, it loses all stored data! I simply can not explain why or how. I have already tried using the specific nbt share tag method (commented out in the given code below), but that is also not working. I honestly have no idea anymore. Looking for help. Now before posting the code, you will see that I have added a debug output to the method which basically saves the data. This print does not get called at all, when just moving the item around.

 

public class ItemStorage extends Item
{
	public ItemStorage()
	{
		this.setMaxStackSize(1);
		this.setMaxDamage(0);
		this.setHasSubtypes(false);
	}
	
	@Override
	public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn)
	{
		playerIn.openGui(Dueling.instance, 5, worldIn, 0, 0, 0);
		//		ContainerStorage container = (ContainerStorage) playerIn.openContainer;
		
		return super.onItemRightClick(worldIn, playerIn, handIn);
	}
	
	public static final String NBT_SIZE = "LIST_SIZE";
	
	public NonNullList<ItemStack> getItems(ItemStack itemStack)
	{
		NBTTagCompound nbt = this.getSubCompound(itemStack);
		int size = nbt.getInteger(ItemStorage.NBT_SIZE);
		NonNullList<ItemStack> items = NonNullList.<ItemStack>withSize(size, ItemStack.EMPTY);
		ItemStorage.loadAllItems(nbt, items);
		return items;
	}
	
	public void setItems(ItemStack itemStack, NonNullList<ItemStack> items)
	{
		System.out.println("saving");
		
		NBTTagCompound nbt = new NBTTagCompound();
		nbt.setInteger(ItemStorage.NBT_SIZE, items.size());
		ItemStorage.saveAllItems(nbt, items);
		this.setSubCompound(itemStack, nbt);
	}
	
	public NBTTagCompound getSubCompound(ItemStack itemStack)
	{
		if(!itemStack.hasTagCompound())
		{
			itemStack.setTagCompound(new NBTTagCompound());
		}
		
		return itemStack.getTagCompound().getCompoundTag(Dueling.MOD_ID);
	}
	
	public void setSubCompound(ItemStack itemStack, NBTTagCompound tag)
	{
		if(!itemStack.hasTagCompound())
		{
			itemStack.setTagCompound(new NBTTagCompound());
		}
		
		itemStack.getTagCompound().setTag(Dueling.MOD_ID, tag);
	}
	
	@Override
	public void getSubItems(CreativeTabs tab, NonNullList<ItemStack> items)
	{
		super.getSubItems(tab, items);
	}
	
	@Override
	public boolean getShareTag()
	{
		return false;
	}
	
	/*@Override
	public NBTTagCompound getNBTShareTag(ItemStack itemStack)
	{
		NBTTagCompound nbt = itemStack.getTagCompound();
		NBTTagCompound nbtNew = new NBTTagCompound();
		
		if(nbt != null)
		{
			for(String key : nbt.getKeySet())
			{
				if(!key.equals(Dueling.MOD_ID))
				{
					nbtNew.setTag(key, nbt.getTag(key));
				}
			}
		}
		
		itemStack.setTagCompound(nbt);
		
		return nbtNew;
	}*/
	
	public static NBTTagCompound saveAllItems(NBTTagCompound tag, NonNullList<ItemStack> list)
	{
		return ItemStorage.saveAllItems(tag, list, true);
	}
	
	public static NBTTagCompound saveAllItems(NBTTagCompound tag, NonNullList<ItemStack> list, boolean saveEmpty)
	{
		NBTTagList nbttaglist = new NBTTagList();
		
		for (int i = 0; i < list.size(); ++i)
		{
			ItemStack itemstack = list.get(i);
			
			if (!itemstack.isEmpty())
			{
				NBTTagCompound nbttagcompound = new NBTTagCompound();
				nbttagcompound.setInteger("Slot", i);
				itemstack.writeToNBT(nbttagcompound);
				nbttaglist.appendTag(nbttagcompound);
			}
		}
		
		if (!nbttaglist.hasNoTags() || saveEmpty)
		{
			tag.setTag("Items", nbttaglist);
		}
		
		return tag;
	}
	
	public static void loadAllItems(NBTTagCompound tag, NonNullList<ItemStack> list)
	{
		NBTTagList nbttaglist = tag.getTagList("Items", 10);
		
		for (int i = 0; i < nbttaglist.tagCount(); ++i)
		{
			NBTTagCompound nbttagcompound = nbttaglist.getCompoundTagAt(i);
			int j = nbttagcompound.getInteger("Slot")/* & 255 */;
			
			if (j >= 0 && j < list.size())
			{
				list.set(j, new ItemStack(nbttagcompound));
			}
		}
	}
}

 

Appreciating any help!

Link to comment
Share on other sites

Maybe try to create an Inventory from an ItemStackHandler using the Capability Item Handler
If you dont know how to use them, here are few lines for you

private ItemStackHandler inventory = new ItemStackHandler(size); // Create the inventory

// In your writeToNBT
compound.setTag("inventory", inventory.serializeNBT());

//In your readToNBT
inventory.deserializeNBT(compound.getCompoundTag("inventory"));

//Use capabilities
    @Override
    public boolean hasCapability(Capability<?> capability, @Nullable EnumFacing facing)
    {
        if (capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) return true;
        return super.hasCapability(capability,facing);
    }

    @Nullable
    @Override
    public <T> T getCapability(Capability<T> capability, @Nullable EnumFacing facing)
    {
        if (capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) return  (T)inventory;
        return super.getCapability(capability, facing);
    }

 

Link to comment
Share on other sites

Show more of your code.

1 hour ago, Riss_Crew said:

private ItemStackHandler inventory

If that is in your Item class, you are doing everything wrong.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.