[1.12.2] Issues about Model and Collision

K10 · February 20, 2018

Hi. I added thin Block looks like wooden slab or wooden pressure plate in my Mod. However, There are some issue :

Block model is not loaded (or not adapted).
Block has a larger hit box than appearance.

BlockRegisterer.java

Spoiler


package doph.niho.cookmod.init;

import doph.niho.cookmod.block.BaseBlock;
import doph.niho.cookmod.block.BlockManaita;
import doph.niho.cookmod.block.BlockManaita2;
import doph.niho.cookmod.itemblock.BaseItemBlock;
import doph.niho.cookmod.itemblock.ItemBlockManaita;
import doph.niho.cookmod.itemblock.ItemBlockManaita2;
import net.minecraft.block.Block;
import net.minecraft.client.renderer.block.model.ModelBakery;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.event.RegistryEvent;

public class BlockRegisterer {

	public static BaseBlock manaita;
	public static BaseBlock manaita2;

	public static BaseItemBlock manaitaItem;
	public static BaseItemBlock manaitaItem2;

	public static void RegisterModel() {
		RegisterRender(manaita);
		RegisterRender(manaita2);
	}

	public static void RegisterBlock(RegistryEvent.Register<Block> e) {
		e.getRegistry().register(manaita);
		e.getRegistry().register(manaita2);
	}

	public static void RegisterItemBlock(RegistryEvent.Register<Item> e) {
		e.getRegistry().register(manaitaItem);
		e.getRegistry().register(manaitaItem2);
	}

	public static void RegisterRender(Block block, String... subName) {
		int len = subName.length;
		if (len == 0) {
			ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(block), 0,
					new ModelResourceLocation(block.getRegistryName(), "inventory"));
		} else {
			ResourceLocation[] rl = new ResourceLocation[subName.length];
			for(int i = 0; i < subName.length; i++) {
				rl[i] = new ResourceLocation(block.getRegistryName() + subName[i]);
			}
			ModelBakery.registerItemVariants(Item.getItemFromBlock(block), rl);
			for (int i = 0; i < len; i++) {
				ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(block), i,
						new ModelResourceLocation(block.getRegistryName() + subName[i], "inventory"));
			}
		}
	}

	public static void Init() {
		manaita = new BlockManaita();
		manaita2 = new BlockManaita2();

		manaitaItem = new ItemBlockManaita();
		manaitaItem2 = new ItemBlockManaita2();
	}
}

BlockManaita.java

Spoiler


package doph.niho.cookmod.block;

import doph.niho.cookmod.system.Define;
import net.minecraft.block.BlockHorizontal;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.MapColor;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyDirection;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.BlockFaceShape;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.IStringSerializable;
import net.minecraft.util.NonNullList;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.Rotation;
import net.minecraft.util.math.AxisAlignedBB;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class BlockManaita extends BaseBlock {

	public static final PropertyEnum<BlockManaita.EnumType> VARIANT = PropertyEnum.<BlockManaita.EnumType>create("meta",
			BlockManaita.EnumType.class);
	public static final PropertyDirection FACING = BlockHorizontal.FACING;
	protected static final AxisAlignedBB X_AXIS_AABB = new AxisAlignedBB(0.0625D, 0.0D, 0.25D, 0.9375D, 0.0625D, 0.75D);
	protected static final AxisAlignedBB Z_AXIS_AABB = new AxisAlignedBB(0.25D, 0.0D, 0.0625D, 0.75D, 0.0625D, 0.9375D);

	public BlockManaita() {
		super(Material.WOOD);
		this.setRegistryName(new ResourceLocation(Define.MODID, "manaita"));
		this.setUnlocalizedName("manaita");
		this.setHardness(0.25F);
		this.setResistance(0.5F);
		this.setSoundType(SoundType.WOOD);
		this.setLightOpacity(1);
		this.setLightLevel(0.0F);
		this.setDefaultState(this.blockState.getBaseState().withProperty(FACING, EnumFacing.NORTH).withProperty(VARIANT,
				BlockManaita.EnumType.OAK));
	}

	public AxisAlignedBB getCollisionBoundingBox(IBlockState state, IBlockAccess worldIn, BlockPos pos) {
		EnumFacing enumfacing = (EnumFacing) state.getValue(FACING);
		return enumfacing.getAxis() == EnumFacing.Axis.X ? X_AXIS_AABB : Z_AXIS_AABB;
	}

	public boolean isFulllCube(IBlockState state) {
		return false;
	}

	public BlockFaceShape getBlockFaceShape(IBlockAccess worldIn, IBlockState state, BlockPos pos, EnumFacing face) {
		return BlockFaceShape.UNDEFINED;
	}

	public boolean isOpequeCube(IBlockState state) {
		return false;
	}

	@SuppressWarnings("deprecation")
	public boolean canPlaceBlockAt(World worldIn, BlockPos pos) {
		IBlockState down = worldIn.getBlockState(pos.down());
		return super.canPlaceBlockAt(worldIn, pos) && (down.isTopSolid() || down.getBlockFaceShape(worldIn, pos.down(), EnumFacing.UP) == BlockFaceShape.SOLID);
	}

	@SuppressWarnings("deprecation")
	public IBlockState getStateForPlacement(World worldIn, BlockPos pos, EnumFacing facing, float hitX, float hitY,
			float hitZ, int meta, EntityLivingBase placer) {
		EnumFacing enumfacing = placer.getHorizontalFacing().rotateY();

		try {
			return super.getStateForPlacement(worldIn, pos, facing, hitX, hitY, hitZ, meta, placer)
					.withProperty(FACING, enumfacing).withProperty(VARIANT, BlockManaita.EnumType.byMetadata(meta));
		} catch (IllegalArgumentException var11) {
			if (!worldIn.isRemote) {
				if (placer instanceof EntityPlayer) {
					placer.sendMessage(new TextComponentTranslation(
							"Invalid damage property. Please pick in [0, 1, 2, 3]", new Object[0]));
				}
			}
			return super.getStateForPlacement(worldIn, pos, facing, hitX, hitY, hitZ, meta, placer)
					.withProperty(FACING, enumfacing).withProperty(VARIANT, BlockManaita.EnumType.OAK);
		}
	}

	public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn,
			EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) {
		return true;
	}

	public AxisAlignedBB getBoundingBox(IBlockState state, IBlockAccess source, BlockPos pos) {
		EnumFacing enumfacing = (EnumFacing) state.getValue(FACING);
		return enumfacing.getAxis() == EnumFacing.Axis.X ? X_AXIS_AABB : Z_AXIS_AABB;
	}

	@SideOnly(Side.CLIENT)
	public boolean shouldSideBeRendered(IBlockState blockState, IBlockAccess blockAccess, BlockPos pos,
			EnumFacing side) {
		return true;
	}

	public String getUnlocalizedName(ItemStack item) {
		return BlockManaita.EnumType.byMetadata(item.getMetadata()).getUnlocalizedName();
	}

	public int damageDropped(IBlockState state) {
		return ((BlockManaita.EnumType) state.getValue(VARIANT)).getMetadata();
	}

	public void getSubBlocks(CreativeTabs itemIn, NonNullList<ItemStack> items) {
		for (BlockManaita.EnumType blockmanaita$enumtype : BlockManaita.EnumType.values()) {
			items.add(new ItemStack(this, 1, blockmanaita$enumtype.getMetadata()));
		}
	}

	public MapColor getMapColor(IBlockState state, IBlockAccess worldIn, BlockPos pos) {
		return MapColor.AIR;
	}

	public IBlockState getStateFromMeta(int meta) {
		return this.getDefaultState().withProperty(FACING, EnumFacing.getHorizontal(meta & 4)).withProperty(VARIANT,
				BlockManaita.EnumType.byMetadata(meta));
	}

	public int getMetaFromState(IBlockState state) {
		int i = 0;
		i = i | ((EnumFacing) state.getValue(FACING)).getHorizontalIndex();
		i = i | ((BlockManaita.EnumType) state.getValue(VARIANT)).getMetadata();
		return i;
	}

	public IBlockState withRotation(IBlockState state, Rotation rot) {
		return state.getBlock() != this ? state
				: state.withProperty(FACING, rot.rotate((EnumFacing) state.getValue(FACING)));
	}

	protected BlockStateContainer createBlockState() {
		return new BlockStateContainer(this, new IProperty[] { FACING, VARIANT });
	}

	public static enum EnumType implements IStringSerializable {
		OAK(0, "oak"), SPRUCE(1, "spruce"), BIRCH(2, "birch"), JUNGLE(3, "jungle");

		private static final BlockManaita.EnumType[] META_LOOKUP = new BlockManaita.EnumType[values().length];
		private final int meta;
		private final String name;

		private EnumType(int metaIn, String nameIn) {
			this.meta = metaIn;
			this.name = nameIn;
		}

		public int getMetadata() {
			return this.meta;
		}

		public String toString() {
			return this.name;
		}

		public static BlockManaita.EnumType byMetadata(int meta) {
			if (meta < 0 || meta >= META_LOOKUP.length) {
				meta = 0;
			}
			return META_LOOKUP[meta];
		}

		public String getName() {
			return this.name;
		}

		public String getUnlocalizedName() {
			return this.name;
		}

		static {
			for (BlockManaita.EnumType blockmanaita$enumtype : values()) {
				META_LOOKUP[blockmanaita$enumtype.getMetadata()] = blockmanaita$enumtype;
			}
		}
	}
}

blockstates\manaita.json

Spoiler


{
	"variants" : {
		"facing=south,meta=oak" : {"model":"cookmod:block/manaita_oak"},
		"facing=west,meta=oak" : {"model":"cookmod:block/manaita_oak", "y" : 90},
		"facing=north,meta=oak" : {"model":"cookmod:block/manaita_oak", "y" : 180},
		"facing=east,meta=oak" : {"model":"cookmod:block/manaita_oak", "y" : 270},
		"facing=south,meta=spruce" : {"model":"cookmod:block/manaita_spruce"},
		"facing=west,meta=spruce" : {"model":"cookmod:block/manaita_spruce", "y" : 90},
		"facing=north,meta=spruce" : {"model":"cookmod:block/manaita_spruce", "y" : 180},
		"facing=east,meta=spruce" : {"model":"cookmod:block/manaita_spruce", "y" : 270},
		"facing=south,meta=birch" : {"model":"cookmod:block/manaita_birch"},
		"facing=west,meta=birch" : {"model":"cookmod:block/manaita_birch", "y" : 90},
		"facing=north,meta=birch" : {"model":"cookmod:block/manaita_birch", "y" : 180},
		"facing=east,meta=birch" : {"model":"cookmod:block/manaita_birch", "y" : 270},
		"facing=south,meta=jungle" : {"model":"cookmod:block/manaita_jungle"},
		"facing=west,meta=jungle" : {"model":"cookmod:block/manaita_jungle", "y" : 90},
		"facing=north,meta=jungle" : {"model":"cookmod:block/manaita_jungle", "y" : 180},
		"facing=east,meta=jungle" : {"model":"cookmod:block/manaita_jungle", "y" : 270}
	}
}

models\block\manaita_oak.json

Spoiler


{
	"parent" : "block/cube_all",
	"textures" : {
		"all" : "block/planks_oak"
	}
}

models\block\manaita_birch

Spoiler


{
	"parent" : "cookmod:block/manaita",
	"textures" : {
		"texture" : "blocks/planks_birch"
	}
}

models\block\manaita

Spoiler


{
	"parent" : "block/thin_block",
	"textures" : {
		"particle" : "#texture"
	},
	"elements" : [
		{
			"from" : [ 1, 0, 4 ],
			"to" : [ 15, 2, 12],
			"faces" : {
				"down" : { "uv" : [ 1,  4, 15, 12 ], "texture" : "#texture", "cullface" : "down" },
				"up"   : { "uv" : [ 1,  4, 15, 12 ], "texture" : "#texture" },
				"north": { "uv" : [ 1, 14, 15, 16 ], "texture" : "#texture" },
				"south": { "uv" : [ 1, 14, 15, 16 ], "texture" : "#texture" },
				"west" : { "uv" : [ 4, 14, 12, 16 ], "texture" : "#texture" },
				"east" : { "uv" : [ 4, 14, 12, 16 ], "texture" : "#texture" }
			}
		}
	]
}

Can anyone tell me why model is not adapted and block has strange collision box?

Draco18s · February 20, 2018

1 hour ago, K10 said:


	public static void RegisterBlock(RegistryEvent.Register<Block> e) {
		e.getRegistry().register(manaita);
		e.getRegistry().register(manaita2);
	}

	public static void RegisterItemBlock(RegistryEvent.Register<Item> e) {
		e.getRegistry().register(manaitaItem);
		e.getRegistry().register(manaitaItem2);
	}

You haven't annotated these methods such that the event bus knows about them.

K10 · February 21, 2018

Sorry, I forgot to say that these methods is called from

@SubscribeEvent

public static void OnBlockRegistered(RegistryEvent.Register<Block> e);

@SubscribeEvent

public static void OnItemRegistered(RegistryEvent.Register<Item> e);

diesieben07 · February 21, 2018

4 hours ago, K10 said:

Sorry, I forgot to say that these methods is called from

@SubscribeEvent

public static void OnBlockRegistered(RegistryEvent.Register<Block> e);

@SubscribeEvent

public static void OnItemRegistered(RegistryEvent.Register<Item> e);

So you did not post your complete code. Please post all relevant code.

K10 · February 21, 2018

OK, here is a my all code.

https://github.com/nihotamor/cookmod

diesieben07 · February 21, 2018

Why do some of your class files not have the .java file extension? How does this code even compile?
Problematic code, issue 2.
You are referencing client-only classes (such as Minecraft and ModelLoader) in common code. This will crash on a server, you must encapsulate this using @SidedProxy.
ModelBakery.registerItemVariants is not needed if you are using ModelLoader.setCustomModelResourceLocation.

K10 · February 21, 2018

Quote

Why do some of your class files not have the .java file extension? How does this code even compile?

I mistook file name when I create file on github because I didn't know way to drag and drop file at first. I already fixed.

Quote

Problematic code, issue 2.

There are not enough document about forge tutorial in Japan, so I have to study old article...

Quote

You are referencing client-only classes (such as Minecraft and ModelLoader) in common code. This will crash on a server, you must encapsulate this using @SidedProxy.

Oh, I missed it! I have to add it in my code.

Quote

ModelBakery.registerItemVariants is not needed if you are using ModelLoader.setCustomModelResourceLocation.

OK, I see.

Thank you for your advices. I hava to rewrite the majority of my codes, so I recreate project and restart from first. I will report and ask later.

diesieben07 · February 21, 2018

4 minutes ago, K10 said:

I mistook file name when I create file on github because I didn't know way to drag and drop file at first. I already fixed.

Drag and drop? What? Please use the actual Git client.

K10 · February 21, 2018

Sorry I used github via web browser.

diesieben07 · February 21, 2018

22 minutes ago, K10 said:

Sorry I used github via web browser.

Yes, I know. Please don't.

vpontin · March 2, 2018

Use Github Desktop if you have problems using git via command line.

Draco18s · March 2, 2018

12 minutes ago, vpontin said:

Use Github Desktop if you have problems using git via command line.

On 9/14/2017 at 1:34 PM, diesieben07 said:

Please don't ever use this crap.

If you want a good Git client, use SourceTree (I don't know GitKraken, never used it) or (even better) use a good IDE (*cough* IntelliJ *cough*) that has built-in Git support.

vpontin · March 2, 2018

I've been using Github desktop because sourcetree just stopped working in my computer.

TheRPGAdventurer · March 2, 2018

Just now, Draco18s said:

Please don't ever use this crap.

Why?

diesieben07 · March 3, 2018

15 hours ago, TheRPGAdventurer said:

Why?

I don't know if this is still accurate. I made that statement when Github for Desktop was still new and it sucked badly. Is it better now? Maybe. I have not tried it.

Sign In

[1.12.2] Issues about Model and Collision

Recommended Posts

K10 0

Share this post

Link to post

Share on other sites

Draco18s 2090

Share this post

Link to post

Share on other sites

K10 0

Share this post

Link to post

Share on other sites

diesieben07 6671

Share this post

Link to post

Share on other sites

K10 0

Share this post

Link to post

Share on other sites

diesieben07 6671

Share this post

Link to post

Share on other sites

K10 0

Share this post

Link to post

Share on other sites

diesieben07 6671

Share this post

Link to post

Share on other sites

K10 0

Share this post

Link to post

Share on other sites

diesieben07 6671

Share this post

Link to post

Share on other sites

vpontin 11

Share this post

Link to post

Share on other sites

Draco18s 2090

Share this post

Link to post

Share on other sites

vpontin 11

Share this post

Link to post

Share on other sites

TheRPGAdventurer 4

Share this post

Link to post

Share on other sites

diesieben07 6671

Share this post

Link to post

Share on other sites

Join the conversation

Recently Browsing

Posts

Topics

Who's Online (See full list)