[1.12.2][solved] Block getMetaFromState for multiple properties

[DonKresenko 0]

I have two properties in my block, LEVEL and FACING. I need to store the meta in order to save the properties.

 

I have this code

public int getMetaFromState(IBlockState state)
    {
        return ((Integer)state.getValue(LEVEL)).intValue();
    }

which saves LEVEL property. 

 

I need a way to save FACING property too.

Edited February 9, 2018 by DonKresenko
solved

[DonKresenko 0]

Or even if I have 3 properties, then I would probably need TileEntity class

[DonKresenko 0]

I found this in BlockEndPortalFrame, but I am not quite familiar with this

public int getMetaFromState(IBlockState state)
    {
        int i = 0;
        i = i | ((EnumFacing)state.getValue(FACING)).getHorizontalIndex();

        if (((Boolean)state.getValue(EYE)).booleanValue())
        {
            i |= 4;
        }

        return i;
    }

Edited February 9, 2018 by DonKresenko

[diesieben07 6693]

You can store up to 4 bits of data in metadata.

If you want to store more than one property, you need to encode the data into one 4 bit number. One example:

 

Two properties: Facing (0-3) and Active (true or false).Facing needs two bits (values 0b00, 0b01, 0b10 and 0b11), Active needs one bit (values 0b0 and 0b1). Now you need to shift one over so that they do not collide (pseudocode follows):

activeBit = active ? 0b1 : 0b0;
activeShifted = activeBit << 2; // activeShifted is now 0b100 or 0b000
facingBits = facing; // 0b00 - 0b11
combined = activeShifted | facingBits // e.g. 0b101 for facing 0b01 and active 0b1

 

The reverse then has to be done when reading from metadata and is left as an exercise to the reader.

[DonKresenko 0]

7 minutes ago, diesieben07 said:

You can store up to 4 bits of data in metadata.

If you want to store more than one property, you need to encode the data into one 4 bit number. One example:

 

Two properties: Facing (0-3) and Active (true or false).Facing needs two bits (values 0b00, 0b01, 0b10 and 0b11), Active needs one bit (values 0b0 and 0b1). Now you need to shift one over so that they do not collide (pseudocode follows):

activeBit = active ? 0b1 : 0b0;
activeShifted = activeBit << 2; // activeShifted is now 0b100 or 0b000
facingBits = facing; // 0b00 - 0b11
combined = activeShifted | facingBits // e.g. 0b101 for facing 0b01 and active 0b1

 

The reverse then has to be done when reading from metadata and is left as an exercise to the reader.

Thank you for the information.

 

I have LEVEL property (0,6) that takes 3 bits and FACING (n, s, e, w) which takes 2 bits.

So I cannot do this cause I need 5 bits?

 

[diesieben07 6693]

2 minutes ago, DonKresenko said:

I have LEVEL property (0,6) that takes 3 bits and FACING (n, s, e, w) which takes 2 bits.

So I cannot do this cause I need 5 bits?

Exactly. You will need a TileEntity or two blocks.

[DonKresenko 0]

Alright. Thank you

[DonKresenko 0]

I now decreased my property LEVEL to 2 bits (0-3)

 

I tried this code but it seems not to be working

public int getMetaFromState(IBlockState state)
    {
    	int lvl = ((Integer)state.getValue(LEVEL)).intValue();
    	lvl <<= 2;
    	int i = ((EnumFacing)state.getValue(FACING)).getHorizontalIndex();
    	// System.out.println(lvl+" | "+i+" = "+(lvl |= i));
    	lvl |= i;
    	
    	return lvl;
    }

What am I doing wrong?

Edited February 9, 2018 by DonKresenko

[diesieben07 6693]

That looks right. How does your getStateFromMeta look?

[DonKresenko 0]

3 minutes ago, diesieben07 said:

That looks right. How does your getStateFromMeta look?

That is getStateFromMeta method

 

I get this exception

Spoiler

java.lang.IllegalArgumentException: Cannot set property PropertyInteger{name=level, clazz=class java.lang.Integer, values=[0, 1, 2, 3]} to 4 on block testmod:store_block, it is not an allowed value

 

[diesieben07 6693]

Just now, DonKresenko said:

That is getStateFromMeta method

You did not post this...

[DonKresenko 0]

sorry I read getMetaFromState

 

public IBlockState getStateFromMeta(int meta)
    {
    	EnumFacing enumfacing = EnumFacing.getFront(meta);

        if (enumfacing.getAxis() == EnumFacing.Axis.Y)
        {
            enumfacing = EnumFacing.NORTH;
        }
        
        return this.getDefaultState().withProperty(LEVEL, Integer.valueOf(meta)).withProperty(FACING, enumfacing);
    }

Edited February 9, 2018 by DonKresenko

[diesieben07 6693]

You can't just use the metadata as-is, you need to decode, i.e. do the inverse of what you are doing when encoding.

[DonKresenko 0]

Ok.

public IBlockState getStateFromMeta(int meta)
    {
    	int lvl = meta>>2;
    	int face = meta & 0b11;
        
    	EnumFacing enumfacing = EnumFacing.getFront(face);

        if (enumfacing.getAxis() == EnumFacing.Axis.Y)
        {
            enumfacing = EnumFacing.NORTH;
        }
        
        return this.getDefaultState().withProperty(LEVEL, Integer.valueOf(lvl)).withProperty(FACING, enumfacing);
        
    }

This works for NORTH and SOUTH but not for the EAST and WEST

This is my problem now

 

(note that directional block is working, this is after reloading the world)

 

Edited February 9, 2018 by DonKresenko

[diesieben07 6693]

When using EnumFacing::getHorizontalIndex for encoding you must use EnumFacing.getHorizontal for decoding. EnumFacing.getFront only works with EnumFacing::getIndex.

[DonKresenko 0]

Alright I almost got it. The problem now is this

image

 

code:

public IBlockState getStateFromMeta(int meta)
    {
    	int lvl = meta>>2;
    	int face = meta & 0b11;
    	
    	EnumFacing enumfacing = EnumFacing.getHorizontal(face);
    	
    	if (enumfacing.getAxis() == EnumFacing.Axis.Y)
        {
            enumfacing = EnumFacing.NORTH;
        }
    	
        return this.getDefaultState().withProperty(LEVEL, Integer.valueOf(lvl)).withProperty(FACING, enumfacing);
        
    }

 

[DonKresenko 0]

Got it now

Thank you for your help

 

I removed this
 

if (enumfacing.getAxis() == EnumFacing.Axis.Y)
        {
            enumfacing = EnumFacing.NORTH;
        }

 

[diesieben07 6693]

That doesn't look like a problem with the metadata, but more like you have a typo in your model or blockstate json.

[Draco18s 2098]

2 hours ago, DonKresenko said:

.withProperty(LEVEL, Integer.valueOf(lvl))

You don't need to box here. withProperty(LEVEL, lvl) works just fine.