[Solved] [1.12.2] Particles only in Slime Chunks

[IceMetalPunk 22]

I have a block which spawns some custom particles below it. The idea is that it should show slime dripping in slime chunks under Y=40. I got all the particle spawning and rendering to work, but as soon as I add the check for if it's a slime chunk... no particles spawn. I've put the world seed into an online Slime Finder (the ChunkBase one) to verify I'm in a slime chunk, and according to that web app, I am. But no particles. If I remove the one condition that checks for slime chunks? Then it properly spawn particles at all such blocks under Y=40.

Here's the relevant code in the block's class:

 

@Override
	@SideOnly(Side.CLIENT)
	public void randomDisplayTick(IBlockState stateIn, World worldIn, BlockPos pos, Random rand) {
		Material material = worldIn.getBlockState(pos.down()).getMaterial();
		double d0 = pos.getX();
		double d1 = pos.getY();
		double d2 = pos.getZ();

		Chunk chunk = worldIn.getChunkFromBlockCoords(pos);

		if (chunk.getRandomWithSeed(987234911L).nextInt(10) == 0 && worldIn.rand.nextInt(2) == 1 && d1 <= 40.0d
				&& material == Material.AIR) {
			double d3 = d0 + (double) rand.nextFloat();
			double d5 = d1;
			double d7 = d2 + (double) rand.nextFloat();
			Particle part = new ParticleSlimeDrip(worldIn, d3, d5, d7);
			Minecraft.getMinecraft().effectRenderer.addEffect(part);
		}
	}

 

The chunk.getRandomWithSeed bit is the "slime chunk condition"; I copied it directly from the slime spawning code, and it lines up with what the Gamepedia Wiki says about how slime chunks are calculated. The world seed is -5415528417089611098, and ChunkBase's Slime Finder says that seed means there should be a slime chunk from (-80,-16) to (-65,-1), but if I go in that range, dig down below Y=40, and place one of these blocks...no particles. If I remove the chunk random value check, it spawns everywhere below Y=40, regardless of chunk.

Am I missing something here? What's the proper way to detect if a given block is in a slime chunk?

Edited February 9, 2018 by IceMetalPunk
Solved

[Draco18s 2089]

Add a logging statement to tell you what the output of that method is.

[IceMetalPunk 22]

27 minutes ago, Draco18s said:

Add a logging statement to tell you what the output of that method is.

The issue there is that this class is being registered to replace the vanilla stone block. If I make it give any console output, I'll be getting output from every loaded stone block in the world, which would be impossible to sift through for the proper blocks.

[Draco18s 2089]

This is what clever programmers are for.

if(pos.x == N && pos.z == M && pos.y == 39) { log.message("hey! listen!"); }

[IceMetalPunk 22]

23 hours ago, Draco18s said:

This is what clever programmers are for.

if(pos.x == N && pos.z == M && pos.y == 39) { log.message("hey! listen!"); }

Hm... I suppose I could do that I feel a little weird hardcoding coordinates like that, but I guess that's ridiculous since it's only for temporary debugging, isn't it? Habits are forceful things...

Aaaannnddd the problem is discovered: the result is 9, so it's not a slime chunk. Wonderful. But that leads me to another question: what's the most reliable way to find a slime chunk for testing this feature? Clearly ChunkBase is inaccurate, and flying around looking for one could be unbounded in time... I suppose I could pick an arbitrary x coordinate and then solve the equation for z? Is there an easier way (since having a list of slime chunks would provide much easier testing than just one at a time)? (EDIT: Yeah, reverse the Random class's methods, that was a genius idea )

 

*EDIT* Or, of course, just iterate in multiples of 16 across (x,z) coordinates and check for each, which I suppose may be easier, though a bit brute force?

*EDIT 2* I am now thoroughly confused. I did it the brute-force way and, on the WorldEvent.Load, generated a list of all (x,z) values which produced 0 for the getRandomWithSeed call. One of those is, in fact, (-80, -16) like ChunkBase said. Yet when I go to that coordinate, there are no particles; and when I check the output from the randomDisplayTick() method's call, it's still 9!

Does the client have a different seed than the server or something? Why is it always 9, even when a brute-force check on world load showed those coordinates to produce a value of 0 for the same function calls?

 

*EDIT 3* Well, testing this found... the client's seed is always 0, regardless of what the server's seed is. So how do I get the proper seed in the randomDisplayTick(), which is client-only? Or is there another way to figure out, in the client-side display tick method, if I'm displaying in a slime chunk or not?

Edited February 8, 2018 by IceMetalPunk

[IceMetalPunk 22]

AHA! After a little research, I've managed to get it all working. I'm using the DimensionManager to get the server World instance for the current dimension based on the client World passed to the randomDisplayTick() method. I don't know if this is the "proper" or "best" way to achieve this, but it works!

Here's the final, working code (which may be updated later to only apply to the overworld, depending on how it behaves in other dimensions):

 

@Override
	@SideOnly(Side.CLIENT)
	public void randomDisplayTick(IBlockState stateIn, World worldIn, BlockPos pos, Random rand) {
		Material material = worldIn.getBlockState(pos.down()).getMaterial();
		double d0 = pos.getX();
		double d1 = pos.getY();
		double d2 = pos.getZ();

		WorldServer server = DimensionManager.getWorld(worldIn.provider.getDimension());

		Chunk chunk = server.getChunkFromBlockCoords(pos);
		int slimeChunkCheck = chunk.getRandomWithSeed(987234911L).nextInt(10);
		if (slimeChunkCheck == 0 && worldIn.rand.nextInt(2) == 1 && d1 <= 40.0d && material == Material.AIR) {
			double d3 = d0 + (double) rand.nextFloat();
			double d5 = d1;
			double d7 = d2 + (double) rand.nextFloat();
			Particle part = new ParticleSlimeDrip(worldIn, d3, d5, d7);
			Minecraft.getMinecraft().effectRenderer.addEffect(part);
		}
	}

 

[diesieben07 6667]

No, what you are doing is known as reaching across logical sides and it is a very bad idea. This will crash as soon as you play on a server and it will cause random inexplicable crashes during normal single player gameplay.

[IceMetalPunk 22]

51 minutes ago, diesieben07 said:

No, what you are doing is known as reaching across logical sides and it is a very bad idea. This will crash as soon as you play on a server and it will cause random inexplicable crashes during normal single player gameplay.

In that case, what is the best way to actually achieve this? The randomDisplayTick() method has to be client-side only, but the client world doesn't actually have a seed to use to detect slime chunks. So how do I determine whether the place I'm trying to render is a slime chunk or not if I can't access the server's seed?

Edited February 8, 2018 by IceMetalPunk

[diesieben07 6667]

29 minutes ago, IceMetalPunk said:

The randomDisplayTick() method has to be client-side only, but the client world doesn't actually have a seed to use to detect slime chunks. So how do I determine whether the place I'm trying to render is a slime chunk or not if I can't access the server's seed?

You send the server seed over using a custom packet.

[IceMetalPunk 22]

15 hours ago, diesieben07 said:

You send the server seed over using a custom packet.

Oh... so I need to add a message class, a message handler, and an event handler that sends the message (and possibly a WorldSavedData class? What's the best way to save the seed on the client?)... all just to get one number that defines the world into the world on the client side? That seems overly elaborate... but if I have no other choice, then I guess I'll get to work...

[Draco18s 2089]

You basically just need to do it once (when the player joins the world) and store it.

Every block can then query that stored seed.

 

And yes, you need to do this, because how else would you get the data when the player connects to a server?

[IceMetalPunk 22]

35 minutes ago, Draco18s said:

You basically just need to do it once (when the player joins the world) and store it.

Every block can then query that stored seed.

 

And yes, you need to do this, because how else would you get the data when the player connects to a server?

I understand *why* it's required, where I'm on the fence is in understanding why the seed, which is integral to the identity of a world, is not already synchronized between both copies of the world. Other than "because vanilla Minecraft hasn't needed it yet"...

Anyway, I'm having an issue implementing this solution. I was under the impression that the PlayerLoggedInEvent fired on the server when a client connected. But instead, it seems to be firing on the client when it connects. This means the client, whose initial world seed is 0, is sending a message to itself saying to set the world seed cache to 0. Clearly, that doesn't work. Should I be using a different event (and if so, what? There doesn't seem to be anything else like ClientConnectEvent or something)?

Here's the current code I'm using (this.serverData is an instance of ServerData, which extends WorldSavedData):

 

	@SubscribeEvent
	public void startSever(WorldEvent.Load ev) {
		World world = ev.getWorld();
		this.serverData = ServerData.get(world, world.getSeed());
		System.out.println("Setting server data: " + this.serverData.getSeed());
	}

	@SubscribeEvent
	public void clientConnect(PlayerLoggedInEvent ev) {
		if (ev.player instanceof EntityPlayerMP) {
			MessageServerSeed message = new MessageServerSeed(this.serverData.getSeed());
			System.out.println("Sending message: " + message.getSeed());
			Microaesthetics.NETWORK.sendTo(message, (EntityPlayerMP) ev.player);
		}
	}

 

The output shows that the proper world seed is getting set on the server, and 0's are getting set on the client -- which is expected. But it's also showing that the only message being sent is from the client -- i.e. it's sent after the client sets its seed to 0 instead of after the server sets its seed properly -- which is the opposite of what I want. (Note: the message handling works just fine, the message gets sent and the handler calls its onMessage method properly and has a valid MessageServerSeed passed to it -- that message just has a seed of 0 because it's only sent from the client, which has a seed of 0.)

So if PlayerLoggedInEvent fires only on the client, what's the equivalent event that fires on the server when a new client connects?

Edited February 9, 2018 by IceMetalPunk

[Draco18s 2089]

Because the client doesn't give a damn what the seed is. What would the client *do* with the information?

[IceMetalPunk 22]

Just now, Draco18s said:

Because the client doesn't give a damn what the seed is. What would the client *do* with the information?

Oh, I don't know... calculate slime chunks for rendering particles? Or some crazy thing like that

[Draco18s 2089]

10 minutes ago, IceMetalPunk said:

Oh, I don't know... calculate slime chunks for rendering particles? Or some crazy thing like that

But vanilla doesn't do that, so it doesn't need the seed, so it doesn't synchronize it.

[IceMetalPunk 22]

48 minutes ago, Draco18s said:

But vanilla doesn't do that, so it doesn't need the seed, so it doesn't synchronize it.

Which is why I said " Other than 'because vanilla Minecraft hasn't needed it yet'...". It just seems like a lack of foresight on the devs' part to not sync an identifying bit of data, that's all. An ounce of prevention and all that.

On another note, I tried switching from the PlayerLoggedInEvent to the ServerConnectionFromClientEvent. On the bright side, this one does seem to fire only on the server. On the downside, it also fires before the entity passed to it exists (or something like that -- it errors when sendTo is called there, without crashing, giving an NPE in the FMLOutboundHandler$selectNetworks method when trying to get the supplied player's dispatcher; the player entity itself is a valid EntityPlayerMP representing the player).

So now I'm at a loss as to where to go from here. I can't send messages at all with the ServerConnectionFromClientEvent, but the PlayerLoggedInEvent only fires on the client. So where do I send a message from the server to a newly-connected client?

 

*EDIT* Well, it looks like I finally got the message part working. I'm using the EntityJoinWorldEvent. It seems like this would be much less efficient than it needs to be, as it fires for every entity and then checks if it's a player, and it still fires and runs every time the player respawns, changes dimensions, etc. But at least it works, I guess. Now I'm just going to update the block code to use the ServerData for the seed, and if that works, I guess this thread will actually be solved then.

 

*EDIT 2* It's so weird... it worked. Once. And now it doesn't work anymore. I don't understand...

HandleEvents.serverData is the static instance of the ServerData class (child of WorldSavedData). Here's the code I have in my message handler:
 

public class ServerSeedMessageHandler implements IMessageHandler<MessageServerSeed, IMessage> {

	@Override
	public IMessage onMessage(MessageServerSeed message, MessageContext ctx) {
		HandleEvents.serverData.setSeed(message.getSeed());
		System.out.println("Received message with seed " + message.getSeed() + " on side " + ctx.side);
		System.out.println("The new seed is " + HandleEvents.serverData.getSeed());
		return null;
	}

}

And here's the corresponding output, which looks perfectly correct:
 

Quote

[00:56:56] [Netty Local Client IO #0/INFO] [STDOUT]: [com.icemetalpunk.microaesthetics.data.ServerSeedMessageHandler:onMessage:14]: Received message with seed -5415528417089611098 on side CLIENT
[00:56:56] [Netty Local Client IO #0/INFO] [STDOUT]: [com.icemetalpunk.microaesthetics.data.ServerSeedMessageHandler:onMessage:15]: The new seed is -5415528417089611098

So the client-side is getting the proper seed, and it's setting the serverData' seed to that value. Great!

And yet... here's the new code in the randomDisplayTick() method of the block:
 

	@Override
	@SideOnly(Side.CLIENT)
	public void randomDisplayTick(IBlockState stateIn, World worldIn, BlockPos pos, Random rand) {

		Material material = worldIn.getBlockState(pos.down()).getMaterial();
		double d0 = pos.getX();
		double d1 = pos.getY();
		double d2 = pos.getZ();

		Chunk chunk = worldIn.getChunkFromBlockCoords(pos);
		long seed = HandleEvents.serverData.getSeed();
		Random slimeChunkRNG = new Random(seed + (long) (chunk.x * chunk.x * 4987142) + (long) (chunk.x * 5947611)
				+ (long) (chunk.z * chunk.z) * 4392871L + (long) (chunk.z * 389711) ^ 987234911L);
		int slimeChunkCheck = slimeChunkRNG.nextInt(10);

		if (pos.getX() == -73 && pos.getY() == 38 && pos.getZ() == -8) {
			System.out.println("Seed: " + seed);
			System.out.println("Result: " + slimeChunkCheck);
		}

		if (slimeChunkCheck == 0 && worldIn.rand.nextInt(10) == 1 && d1 <= 40.0d && material == Material.AIR) {
			double d3 = d0 + (double) rand.nextFloat();
			double d5 = d1;
			double d7 = d2 + (double) rand.nextFloat();
			Particle part = new ParticleSlimeDrip(worldIn, d3, d5, d7);
			Minecraft.getMinecraft().effectRenderer.addEffect(part);
		}
	}

And here is the (extremely frustrating) log output from this:

Quote

[00:56:59] [main/INFO] [STDOUT]: [com.icemetalpunk.microaesthetics.blocks.BlockSlimeChunkStone:randomDisplayTick:46]: Seed: 0
[00:56:59] [main/INFO] [STDOUT]: [com.icemetalpunk.microaesthetics.blocks.BlockSlimeChunkStone:randomDisplayTick:47]: Result: 9

 

So can someone please explain to me why, according to the message handler, the static serverData instance on the client has a proper seed, but when the randomDisplayTick() method queries that static serverData (on the client side) for its seed -- using the SAME METHOD as the debug output in the message handler -- it's getting 0?

I literally have nowhere else I'm calling serverData.setSeed(), and the only place I instantiate serverData is in the WorldEvent.Load event handler, which occurs before the message is even sent (which is, of course, on the EntityJoinWorldEvent for EntityPlayerMP types).

I'm so confused.

Edited February 9, 2018 by IceMetalPunk

[diesieben07 6667]

2 hours ago, IceMetalPunk said:

I tried switching from the PlayerLoggedInEvent to the ServerConnectionFromClientEvent. On the bright side, this one does seem to fire only on the server.

PlayerLoggedInEvent is fine. It only fires on the server (unless you meant "dedicated server", in which case: you should not care about whether you run in single player or on a dedicated server). However you also need to send the seed again in PlayerChangedDimensionEvent and PlayerRespawnEvent.

 

2 hours ago, IceMetalPunk said:

I'm so confused.

What you are observing is (I think) threads being weird because you are not properly synchronizing. If you write to a field from more than one thread without any synchronization guards in place, basically anything can happen. Message handlers are by default ran on the networking thread, not the main client thread. Read the warning in the documentation.

[IceMetalPunk 22]

10 minutes ago, diesieben07 said:

PlayerLoggedInEvent is fine. It only fires on the server (unless you meant "dedicated server", in which case: you should not care about whether you run in single player or on a dedicated server). However you also need to send the seed again in PlayerChangedDimensionEvent and PlayerRespawnEvent.

Um, no? I didn't mean dedicated server; I was testing in a single player world on the client build. The server world has the proper seed, but when I use the PlayerLoggedInEvent, the message is only being sent from the client (as evidenced by the fact that the code which sends the message outputs a seed of 0 before sending the message).

Quote

What you are observing is (I think) threads being weird because you are not properly synchronizing. If you write to a field from more than one thread without any synchronization guards in place, basically anything can happen. Message handlers are by default ran on the networking thread, not the main client thread. Read the warning in the documentation.

Ah, I guess that's a possibility. I'll try changing it to a scheduled task and seeing if that fixes anything. Thanks!

Edited February 9, 2018 by IceMetalPunk

[diesieben07 6667]

13 minutes ago, IceMetalPunk said:

Um, no? I didn't mean dedicated server; I was testing in a single player world on the client build. The server world has the proper seed, but when I use the PlayerLoggedInEvent, the message is only being sent from the client (as evidenced by the fact that the code which sends the message outputs a seed of 0 before sending the message).

Then you are doing something wrong here... PlayerLoggedInEvent is definitely server-side only. Please show updated code if you still have an issue with this.

Edited February 9, 2018 by diesieben07

[IceMetalPunk 22]

33 minutes ago, diesieben07 said:

Then you are doing something wrong here... PlayerLoggedInEvent is definitely server-side only. Please show updated code if you still have an issue with this.

I haven't been using any version control (I know, shame on me; this was meant to be a small hobby project!), so that code is gone now. But I tried to reproduce it from memory to post here, and... my reproduced code works with that event >_< (Or at least, it has the right seed; I haven't tested it with the rendering aspect yet.) So either I'm going crazy, or I had a stupid mistake in my original code that I missed, or the entire problem was a multithreaded race condition the whole time and now that that's fixed the proper event works as expected.

Either way, I'll switch back to using the PlayerLoggedInEvent and do another full test. *Sigh* Heisenbugs are a pain...

*EDIT* And it works perfectly. Because of course it does. Now I get to mark this topic as solved accurately this time. Thank you to everyone who helped!

Edited February 9, 2018 by IceMetalPunk