Jump to content

[1.12.2] Arrays of TextComponents


Aarilight

Recommended Posts

I have a command that prints a long list of information about the current location.

 

It occurred to me just recently that it wasn't translatable, so I've been rewriting it for that purpose. I rewrote the whole thing using TextComponentTranslations, and then I realised that the number of arguments passed to a translation is hardcoded in the translation itself. On that note, I figured maybe I could send a TextComponent which contains an array of other TextComponentTranslations, that would just be joined together automatically. Is there any way for me to do that? I don't see another TextComponent class that would do it (but maybe I'm blind). Do I have to roll my own? If that's what I have to do, does anyone have any recommendations of open source mods that have done a similar thing that I can learn from?

Link to comment
Share on other sites

Since I couldn't find something that would work, I went ahead and implemented my own TextComponent. It's called TextComponentList, and it simply joins the child TextComponents together. It seems to work fine, except that for some reason if I put into it a TextComponentTranslation that shows an argument (via %1$s), the colours in it don't work anymore.

Example:

# colours work:
command.soulus:soulus.location.dimension=Dimension: §6some text
# appears as white:
command.soulus:soulus.location.dimension=Dimension: §6%1$s

 

The TextComponentList implementation.

 

The code that actually uses the TextComponentList.

 

Any ideas as to why that is, or how I could go about fixing it?

Edited by Aarilight
Link to comment
Share on other sites

7 hours ago, diesieben07 said:

I am not sure I understand why you need the arguments to the translation to be variable, to be honest.

I think they mean if they wanted to list out all of the biomes at a block position. For most places, that will be 1. Along biome borders, that would be 2. Where two biomes meet up with a third, there would be 3. Conceivably there might even be 4.

 

So you'd need to translate the "Biomes at this location: ..." text along with translating the biome's names, along with having list grammar ("A" "A and B" "A, B, and C").

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Biome Types, not Biomes (there's only ever one biome per block x/z, afaik). Also, Structure types. (EG: when mineshafts intersect a dungeon or a stronghold)

 

Since there can be multiple of each of those, depending on your location, I wanted to put them together into a list and have the "list separator" be translatable. (Idk, what if another language actually needed that?)

 

Here's an example of the current output: Dimension: º6overworldºf, Biome: ºcminecraft:º6extreme_hillsºf, Biome Types: ºcMOUNTAINºf, ºcHILLSºf, Structures: ºcNone

 

The colour codes are correct in it, but they're not actually rendering that way. I assume it's an issue with "style", but I don't quite understand how the style stuff works. Anyway, this conversation gave me an idea of a solution: the top layer doesn't actually have to be a variable-length list, that one can be a static translation. This might fix the child styles.

Link to comment
Share on other sites

The List Separator is always a comma, with the exception of listing numbers when the local's decimal separator is a comma, in which case, use a semicolon.

https://stackoverflow.com/a/14925131/1663383

Note that you can translate this just fine with the lang files by having something like:

list_separator=,

And just doing a translate on that key when you need to combine things.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

I can't combine them that way because the command is server-side. EG: doesn't support using whatever language the client is. Therefore, I can't send the client a string, because then they can't translate it on their end. I have to send them an ITextComponent.

 

I could make a packet to show the command output but I would rather keep the code less spread out and more reusable. Anyway, it seems like it's just arguments in general that the TextComponentTranslation can't handle. It colourizes the text inside the translation itself, but resets as soon as it enters an argument. Not sure what else to try.

Edited by Aarilight
Link to comment
Share on other sites

I realised I had overlooked a simple solution all along: hardcode the colours of the arguments when passing them as strings. It's not ideal, but it works, and that's what's important.

 

EG:

Biome biome = world.getBiome(pos);
ResourceLocation biomeId = biome.getRegistryName();
result.add(new TextComponentString(TextFormatting.RED + biomeId.getResourceDomain()));
result.add(new TextComponentString(TextFormatting.GOLD + biomeId.getResourcePath()));

 

The final result:

java_2018-01-17_16-30-13.png

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.