Jump to content

[1.12.2] onBlockActivated Shouldn't this method be called twice?


American2050

Recommended Posts

So I was wondering, shouldn't the method onBlockActivated be called two times? One for each hand?

 

I'm testing with a simple:

 

@Override
    public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) {

        LogHelper.info("CALLED " + hand);

 

On console I see:

 

[17:29:34] [main/INFO] [LogHelper]: CALLED MAIN_HAND
[17:29:34] [Server thread/INFO] [LogHelper]: CALLED MAIN_HAND

 

I was expecting to see calls for OFF_HAND also.

 

So my question here would be: Am I forgetting something, and if so, what? And if this is the way it's intended, how do I make it so the player "Swings" the off hand if the action tool place from that hand?

Link to comment
Share on other sites

I don't have time to look at the code, but I think I remember that off-hand is only called if the main hand is empty. Remember this method/event isn't checking the hands, but rather acting on what is in the hands. So if there is something in the main hand it will act on that.

 

So I expect you'll only see main hand, off hand, or nothing at all depending on what is being held in each hand.

 

Note too that it depends on the type of thing in each hand, if I recall. So if you're holding something in the main hand that doesn't interact with blocks I think it may go to off hand.

 

Everything I just said is pretty easy to check in code or test.

  • Like 1

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

On 1/13/2018 at 1:12 PM, jabelar said:

if you're holding something in the main hand that doesn't interact with blocks I think it may go to off hand

Da, try your test again with sword in main and torch in off-hand. See what gets printed.

 

To really see how it does this, get into the debugger and step through (and into) it. You'll see the decision(s) being made.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

On 1/14/2018 at 6:41 PM, jeffryfisher said:

Da, try your test again with sword in main and torch in off-hand. See what gets printed.

 

To really see how it does this, get into the debugger and step through (and into) it. You'll see the decision(s) being made.

That combination, will make the code on the torch to run and react.

What I'm looking for is "onBlockActivated" on the Block class to react to the off-hand (And I mean, if something happened and I return true, the swing animation to take place on the off hand and not on main)

But apparently that's not possible, at least no with the normal methods, as onBlockActivated get called only once.

Link to comment
Share on other sites

Block#onBlockActivated will only get called with EnumHand.OFF_HAND if Block#onBlockActivated returns false when using EnumHand.MAIN_HAND.

 

Return false when the hand used is EnumHand.MAIN_HAND, and you'll get the desired effect.

  • Like 1

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

On 1/18/2018 at 10:20 PM, larsgerrits said:

Block#onBlockActivated will only get called with EnumHand.OFF_HAND if Block#onBlockActivated returns false when using EnumHand.MAIN_HAND.

 

Return false when the hand used is EnumHand.MAIN_HAND, and you'll get the desired effect.

Ahhh thanks, gonna give it a try ;)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
    • Remove Instant Massive Structures Mod from your server     Add new crash-reports with sites like https://paste.ee/  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.