Jump to content

[SOLVED] Brewing Stand Recipe


VengeanceSoldier

Recommended Posts

Im trying to create a custom brewing stand recipe (Yes I know this has been asked a lot of times so far), but im trying to use it to create a potion with a CUSTOM potion effect. The calculation Damage Value of Potion -> List of Potion Effects gets Handeled in the PotionHelper class.

 

 public static List getPotionEffects(int par0, boolean par1){
        ArrayList var2 = null;
        Potion[] var3 = Potion.potionTypes;
        int var4 = var3.length;

        for (int var5 = 0; var5 < var4; ++var5)
        {
            Potion var6 = var3[var5];

            if (var6 != null && (!var6.isUsable() || par1))
            {
                String var7 = (String)potionRequirements.get(Integer.valueOf(var6.getId()));

                if (var7 != null)
                { (.... more stuff)

 

It gets a String of the HashMap potionRequirements. Although my potion effect would be called, it doesnt have a entry in potionRequirements, so (var7 != null) would return false and it wouldnt work. I cant add a value to potionRequirements because its set to private. Is there a way around this wthout editing base files?

 

This is the only way i found, Brewing Stands can only output a potion (with a damage value wich it gets from the potion ingredient).

Link to comment
Share on other sites

I'd use reflection to access the HashMap and insert my values. Something similar to this maybe:

Field f = PotionHelper.class.getDeclaredField("potionRequirements");
f.setAccessible(true);
HashMap myPotionRequirements = (HashMap) f.get(null);
//add stuff to myPotionRequirements variable

mnn.getNativeLang() != English

If I helped you please click on the "thank you" button.

Link to comment
Share on other sites

Ive been racking my brain trying to figure out adding new potions myself.  Im not a very experienced coder, so if someone could help me understand the code for this that would be great.  From what I see this is the general code here:

 

potionRequirements.put(Integer.valueOf(Potion.regeneration.getId()), "0 & !1 & !2 & !3 & 0+6");
        sugarEffect = "-0+1-2-3&4-4+13";

 

Just not exactly sure what any of this is actually saying :) I'm looking to add a custom item that uses the Potion.jump effect.  Also not sure how exactly to utilize reflection, where would that reflection code be placed, and could someone explain how that code actually works?  Much appreciated.

Link to comment
Share on other sites

Also not sure how exactly to utilize reflection, where would that reflection code be placed, and could someone explain how that code actually works?  Much appreciated.

code posted by me just changes access modifier of the field from private to public, you can read more about reflection there - http://docs.oracle.com/javase/tutorial/reflect/. when the field is accessible you can add your recipes into it (it's similar to adding any other recipe in the load phase). if you don't have much experience with java i would not recommend using reflection. there are some things you need to take care of (like that the minecraft code will be obfuscated, so in that enviroment you'd have to use different name of the field, or utilize the new runtime deobfuscation).

mnn.getNativeLang() != English

If I helped you please click on the "thank you" button.

Link to comment
Share on other sites

I got the jump potion enabled through reflection, but can you explain the thing about the fields?

 

For those interested, I added this code to my main mod file in FMLInitialization

Item.itemsList[item.potion.itemID] = null;
	try {
		potion = (ItemPotion)(new NewItemPotion(117)).setIconCoord(13, .setItemName("potion");
	} catch (NoSuchFieldException e) {
		// TODO Auto-generated catch block
		e.printStackTrace();
	} catch (SecurityException e) {
		// TODO Auto-generated catch block
		e.printStackTrace();
	} catch (IllegalArgumentException e) {
		// TODO Auto-generated catch block
		e.printStackTrace();
	} catch (IllegalAccessException e) {
		// TODO Auto-generated catch block
		e.printStackTrace();
	}

 

 

Then in the NewItemPotion

 

public class NewItemPotion extends ItemPotion
{

    public NewItemPotion(int par1) throws NoSuchFieldException, SecurityException, IllegalArgumentException, IllegalAccessException
    {
        super(par1);
        this.setMaxStackSize(1);
        this.setHasSubtypes(true);
        this.setMaxDamage(0);
        this.setCreativeTab(CreativeTabs.tabBrewing);
        
        Class PHelper = PotionHelper.class;
    
        Field f = PHelper.getDeclaredField("potionRequirements");
        f.setAccessible(true);
     
          HashMap myPotionRequirements = (HashMap) f.get(null);
          myPotionRequirements.put(Integer.valueOf(Potion.jump.getId()), "0 & 1 & !2 & 3 & 0+6");
          
    }
    }

 

What do I have to worry about when the code is obfuscated?

Link to comment
Share on other sites

PotionHelper.class.getDeclaredField("potionRequirements");

the string "potionRequirements" is a name of the static field in PotionHelper, when running in obfuscated mc it won't be the same.

 

the runtime deobfuscation is pretty new feature in FML for 1.5 (I haven't even try it yet), this topic might help you:

http://www.minecraftforge.net/forum/index.php/topic,6430.0.html

mnn.getNativeLang() != English

If I helped you please click on the "thank you" button.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.