[1.10.2 / 1.12.2] Machines no longer accepting items/fluid/energy after a block type change

[turbodiesel4598 0]

Hi there,

I have a simple issue which is that my machines stop being able to accept items/fluids/energy (or indeed have them taken out) after the block undergoes an update. I should note that for whatever reason, this issue only appears with certain conduits/ducts such as those of Thermal Dynamics and Integrated Tunnels, but since other machines from other mods don't appear to have the issue, I think the error must be on my end.

The machines will undergo a block update whenever the machine turns on or off, and this happens if it can run or can't run. All of my machines effectively follow the same recipe, so the solution for one of them should almost certainly be the same for the others, but for the purpose of showing the source code, I'll pick one of them:

Tile Entity class (and superclasses if required):

Processors.java
TileEnergyItemProcessor.java

TileEnergySidedInventory.java

TileEnergyInventory.java

TileEnergy.java

NCTile.java

 

Block class (and superclasses if required):

BlockManufactory.java

BlockProcessor.java

BlockSidedInventoryGui.java

BlockSidedInventory.java

BlockInventory.java

Thanks in advance

Edited December 8, 2017 by turbodiesel4598

[Matryoshika 116]

If the update changes IBlockStates, then by default, the TileEntity is removed.

Does this issue still happen after overriding TileEntity::shouldRefresh to return oldState .getBlock() != newState.getBlock()?

[turbodiesel4598 0]

I did not know changing the block removes the tile entity. Unfortunately your suggestion does not fix the issue, and I imagine that would be because the idle and inactive blocks are indeed different blocks.

I realise now that I should have been more clear - the machine doesn't have its block's state change - the block type changes, e.g. blockMachineIdle -> blockMachineActive.

In fact, setting the method to return flat out true or false doesn't solve the issue in either case, so I don't think the issue is there.

Edited December 8, 2017 by turbodiesel4598

[diesieben07 6687]

For one, that is a bad idea, why are you doing that? There is no point using two blocks for that.

If you must though, you can still adjust the shouldRefresh method so that it does not remove the TE when the block changes between those two.

[turbodiesel4598 0]

The only reason is probably because the tutorials that I originally watched when first learning how to mod set up their 'custom furnaces' or whatever in that way. When I updated to 1.10.2 and above I guess I didn't know enough about what block states were to realise how I could just use one block. Perhaps I will do that some day, if you recommend doing so.

Anyway, this doesn't fix the problem either.
After a bit more testing, I noticed something a little peculiar. If the machine is off, and then is switched on by, say, adding an item to the input slot, the machine turns on and runs correctly - the energy buffer is kept full and the output is removed as expected. If the machine is then turned off, the output is no longer taken out, and if turned back on again, energy is no longer accepted either. Also, if an adjacent duct undergoes an update (for example, using the crescent hammer on an adjacent duct), then the input/output through that duct alone starts to work again.

[Draco18s 2093]

I have a feeling most of your issues stem from the fact that you're using two blocks.

[turbodiesel4598 0]

I think you are right about that - it just seems that, by some happy accident, some mods' pipes/cables/conduits are built with the possibility of a machine using two blocks in mind. I'm almost certain at this point that these issues would disappear if I changed that up.

Thank you all for the help

Edited December 8, 2017 by turbodiesel4598