Jump to content

Forge CraftingHelper improvements


R3DKn16h7

Recommended Posts

I have a few suggestion to improve the quality of the "CraftingHelper" class:

- "register" should be private, as it doesn't work for custom registrations even if you want.

- what about adding some extra custom conditions? E.g.


public class ForgeHasOreConditionFactory implements IConditionFactory {
    @Override
    public BooleanSupplier parse(JsonContext context, JsonObject json) {
        String ore = JsonUtils.getString(json, "ore");
        return () -> OreDictionary.doesOreNameExist(ore);
    }
}

- would somebody be interested if I write a section on 1.12 recipes to add https://mcforge.readthedocs.io/en/latest/ ?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.