Jump to content

[SOLVED] Event for Items dropped by Dispenser?


Rurido

Recommended Posts

Hi.

I searched for an event that is triggered when a dispenser throws an item. I got the following, but it is not quite what I wanted, because here I can't prevent the item from being dispensed:

@Mod.EventBusSubscriber
public class EventHandler {
	/*some stuff*/
	@SubscribeEvent
	public static void onBlock(BlockEvent ev) {
		World world = ev.getWorld();
		BlockPos blockPos = ev.getPos();
		IBlockState iBlockState = world.getBlockState(blockPos);
      
		if(iBlockState.getBlock() instanceof BlockDispenser){
			if(iBlockState.getValue(BlockDispenser.TRIGGERED)){
				ChatHelper.sendChatMsgToAllPlayers(ev.getWorld().getMinecraftServer(), "Dispenser fired!");
				/*prevent drop | hook own routine*/
			}
		}
	}
}


Any Idea how to stop the item from being dropped / which event to use instead? This all has to happen @ server side...

Thanks in advance, Rurido.

Edited by Rurido

If my answer helped you out, you may give that answer a like. ^-^
Funny but true JavaScript statements: 

null != 0  null !<0  null !> 0    null <= 0  null >= 0  Number(null) == 0

Link to comment
Share on other sites

The dispenser does not fire any event, of any kind, when it dispenses items. The BlockEvent class (and its subclasses) are for events like crops growing, blocks being placed, blocks being broken, etc. They are very specific (I do not believe that BlockEvent is used in any context except via its subclasses). Also, if you look at BlockDispenser and the dispense method, you'll see that no events are posted.

 

If you want to change how the dispenser dispenses items, you can do that by adding and removing entries to the DISPENSE_BEHAVIOR_REGISTRY

Edited by Draco18s
  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

1 hour ago, Draco18s said:

The dispenser does not fire any event, of any kind, when it dispenses items. [...]

 

If you want to change how the dispenser dispenses items, you can do that by adding and removing entries to the DISPENSE_BEHAVIOR_REGISTRY

Thanks for the advice. It works now!

Just to be sure, is everything as it should be?

@Mod(modid = Main.MODID, version = Main.VERSION)
public class Main {
  	/*init stuff*/
	@EventHandler
	public static void postInit(FMLPostInitializationEvent event){
		RecipeManager.initDispenserBehavior();
	}
}

public class RecipeManager {
  	/*some stuff*/
	public void initDispenserBehavior(){
		BlockDispenser.DISPENSE_BEHAVIOR_REGISTRY.putObject(Items.WHEAT_SEEDS, new BehaviorPlaceBlock(Blocks.WHEAT, 1, 4));
		/*more stuff*/
	}
}

public class BehaviorPlaceBlock implements IBehaviorDispenseItem {
	
	protected final IBlockState iBlockState;
	protected int offset = 1;
	protected int maxRange = 1;

	public BehaviorPlaceBlock(Block blockToPlace, int offset, int maxRange){
		iBlockState = blockToPlace.getDefaultState();
		this.offset = offset;
		this.maxRange = maxRange;
	}

	@Override
	public ItemStack dispense(IBlockSource source, ItemStack stack) {
		/*do some stuff*/
	}
}

 

Edited by Rurido

If my answer helped you out, you may give that answer a like. ^-^
Funny but true JavaScript statements: 

null != 0  null !<0  null !> 0    null <= 0  null >= 0  Number(null) == 0

Link to comment
Share on other sites

I think so.

You're also removing any existing behavior for items you're adding behaviors for, yes? (If applicable)

(Aside from the default "toss").

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

As far as I know, my behaviors use items with no behavior in (vanilla) Minecraft, so no, I don't remove any behaviors.

Should I remove a behavior provisionally before I add it to make sure it is compatible with other mods?

If my answer helped you out, you may give that answer a like. ^-^
Funny but true JavaScript statements: 

null != 0  null !<0  null !> 0    null <= 0  null >= 0  Number(null) == 0

Link to comment
Share on other sites

You should be fine, it's just that if you wanted to override a behavior (e.g. making water buckets do something different) you'd have to remove the existing behavior.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Good to know, but that was nothing I wanted to do. Like my little piece of code showed I simply added some placement rules for seeds in dispensers.

But anyways, thank you! :D

PS: Do threads get closed here? I think this would be the right point to do so ^^

Edited by Rurido

If my answer helped you out, you may give that answer a like. ^-^
Funny but true JavaScript statements: 

null != 0  null !<0  null !> 0    null <= 0  null >= 0  Number(null) == 0

Link to comment
Share on other sites

17 hours ago, Rurido said:

PS: Do threads get closed here? I think this would be the right point to do so ^^

Some people change the title of the first post to contain [SOLVED].

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

18 hours ago, larsgerrits said:

Some people change the title of the first post to contain [SOLVED].

Good to know. I did so now.

If my answer helped you out, you may give that answer a like. ^-^
Funny but true JavaScript statements: 

null != 0  null !<0  null !> 0    null <= 0  null >= 0  Number(null) == 0

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.