Jump to content

Make CriteriaTriggers an IForgeRegistry


Draco18s

Recommended Posts

Title is not entirely accurate, but the point is that currently the CriteriaTriggers for advancements has a private REGISTRY and register() method.  Without being able to register a new ICriterionTrigger object with this registry, modders cannot create new advacement triggers (this includes recipes that award on something other than the vanilla triggers).  For example, I want to create a trigger that will test true when any one of a list of items is picked up (the vanilla InventoryChanged trigger does take a list, but it needs all of them to be acquired before being true) as I have six flower blocks that are all basically the "same" block (limits on metadata based state information) and I want to award an advancement if any one of those six blocks is acquired (technically possible with vanilla triggers, if I smashed all six ItemBlocks into a single Item--yuck). I then have another advancement I want to trigger when the player uses bonemeal and grows any one of these flowers (which not possible with vanilla triggers).

 

I have no idea how things need to be set up to fire registry events and so forth, otherwise I would do it myself as a PR. Presumably these would need to be registered before recipes and advancements but after item models.

 

 

(The ICriterionTrigger classes are also insanely complicated, involving two static child classes and most of the one I have was pieced together from existing vanilla versions).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.