[SOLVED] [1.10.2] Blockstate change not rendering

[MCHellspawn]

Hello,

 

  New to modding.. Been following several modding tutorials but attempting to make a furnace block in my mod.. I'm just getting to the point of adding a TileEntity to the block.. The TE gets created fine, I have an onblockactived function on the block that updates the TE's "active" property when I right click the block, starting simple.. I also have it start a 200 tick count down.. When I activate the block I want the render of the block to change, much like with the vanilla furnace when it starts cooking.. It's weird because I can see from messages I have writing to the console that the TE is getting updated and is counting down however the block render doesn't get updated.. If I right click the block repeatedly it does update sometimes.. To be honest I can't figure out why it does it sometimes and not others.. Would someone be willing to look at my code and tell me what I am doing wrong?? Any help is greatly appreciated..

 

https://github.com/MCHellspawn/CompressedFurnace

Edited April 28, 2017 by MCHellspawn

[jeffryfisher]

Try rewriting the block's active / not active manipulation without getting any data from your TE. The blockstate at pos should have all the data you need. The only thing you might need to do to the TE is tell it what the new state is, and you might not even need that (depending on how your TE is ticking).

Edited April 27, 2017 by jeffryfisher

[MCHellspawn]

2 hours ago, jeffryfisher said:

Try rewriting the block's active / not active manipulation without getting any data from your TE. The blockstate at pos should have all the data you need. The only thing you might need to do to the TE is tell it what the new state is, and you might not even need that (depending on how your TE is ticking).

First, Thank you for the reply..

 

Second.. I'm a bit confused.. I thought I was handling all of the active manipulation in the block.. I'm setting it in the onblockactivated function, and then in there setting the active property in the TE.. I'm really only doing the TE so I can hold more info about the block later... Are you saying I should do a block state change in there too?

[Draco18s]

You either:

a) need to set a block state (make sure to override shouldRefresh in your TE to return false if the block remains the same).

b) need to override getActualState in order to get the state property from TE data.

[MCHellspawn]

2 minutes ago, Draco18s said:

You either:

a) need to set a block state (make sure to override shouldRefresh in your TE to return false if the block remains the same).

b) need to override getActualState in order to get the state property from TE data.

 Ok... I think I am doing both of those.. setting a blockstate in the onblockactivated, and I've overridden getActualState...

[Choonster]

You need to call World#notifyBlockUpdate from the TileEntity whenever a value used by Block#getActualState changes. This tells the server to send the TileEntity's update packet to any nearby clients as well as telling them to re-draw the chunk containing the block, using the new actual state to select the model.

 

You also need to call World#notifyBlockUpdate from TileEntity#onDataPacket so that the client re-draws the chunk whenever it receives the TileEntity's update packet.

 

You can see an example of a block that uses TileEntity data in Block#getActualState here: BlockColoredRotatable, TileEntityColoredRotatable

[MCHellspawn]

OMG!!! Choonster you are awesome!!! That was it.. I added the code to call notifyBlockUpdate as shown in your examples and it works perfectly every time!! On to GUI tutorials now!! Thank you so much!!

[jeffryfisher]

21 hours ago, MCHellspawn said:

I thought I was handling all of the active manipulation in the block.

At the time I looked at your block's code, it was fetching the TE to get the value of "active". It shouldn't need to do that. In fact, the TE might not need to hold onto that either. It knows its own pos and should fetch its co-located blockstate to find out (and to verify that the block in place is still the furnace that it belongs with).

 

The block should be able to know it's active by using its own bs / metadata. At most, it should be telling the TE about changes (and Choonster pointed at a useful method).

 

Look at your code where the block decides whether to become active / inactive. Pretend that the TE isn't there to help you (unless the block actually needs TE data about inventory or smelting progress -- but I didn't see any such factor in the decision).

 

Do you see it now? I don't think you need to fetch a TE to tell you that you're active when your own metadata should know that much.

[MCHellspawn]

Ok.. I know it's been a bit since this one started but continuing the adventure..

 

Before moving on to container and GUI I wanted to work on your suggestions.. I've made some changes to the block and TE to get it more towards the block setting the TE values via it's own blockstate.. I think I understand what you are saying but I seem to be having a hard time getting the TE to set the block state.. Strange thing is I get it to update the render as though the block state is changing but when I activate the block after the TE does it's count down (and deactivates the block) the block still thinks it's active..

 

The point of the whole mod is to build a furnace type block. Mostly doing it so I can learn the modding concepts.. Eventually there will be a lot more cooking logic built into the furnace's TE..

 

So I seem to be stuck now on getting the TE to set the ACTIVE property of the block... Am I doing that correctly??

[Draco18s]

On 4/27/2017 at 5:48 PM, Draco18s said:

b) you need to override getActualState in order to get the state property from TE data.

And sync the data to the client, of course.

Edited May 9, 2017 by Draco18s