Jump to content

Client Side events


AscendedKitten

Recommended Posts

Hey! I've recently returned to developing Forge applications for version 1.9, but got stuck with some basic stuff.

The mod I am trying to create is client-side only, and therefore the events working in Singleplayer are not triggered.

 

Currently I list all items dropped when a mob dies (which was killed by the player) in the chat, but the LivingDropsEvent used in this case is (as expected) not triggering when used on a server without the mod. I am aware of the fact that it can't work the way I am trying, and would be delighted if someone could point me into the right direction. As this is a very basic scenario, I do not think it is neccessary to provide the code.

Link to comment
Share on other sites

Every in-game change should be done server, which means the drops should be changed on the server side.

So, are you planning to make a SSP-only mod?

I. Stellarium for Minecraft: Configurable Universe for Minecraft! (WIP)

II. Stellar Sky, Better Star Rendering&Sky Utility mod, had separated from Stellarium.

Link to comment
Share on other sites

Yeah, there is no way to do that on the client. The client does not know if it hit an entity and the entity therefor dies or if the entity was killed because of whatever. The client simply gets told "yeah, Entity X is now dead".

I guess limiting it to a range is the only possiblity then?

Still, I am not certain how I'd do that

Link to comment
Share on other sites

You could use

EntityJoinWorldEvent

to detect when new item entities are spawned, but that's the best you can do purely on the client. The client does not know why these are spawned or where they are coming from.

How comes I've seen it happend? This is a screenshot from a similiar mod, on the same server, purely clientsided

http://puu.sh/q8nfq.jpg

Link to comment
Share on other sites

Yes, but it shows all item entities (within radius). That is of course fully possible.

Thanks! Final question: I assume I could get a list of all entities in a specific radius using the EntityJoinWorldEvent and check if they are instance of xyz entity? If so, is it also possible to get their data, e.g lore?

Link to comment
Share on other sites

Yes, but it shows all item entities (within radius). That is of course fully possible.

Thanks! Final question: I assume I could get a list of all entities in a specific radius using the EntityJoinWorldEvent and check if they are instance of xyz entity? If so, is it also possible to get their data, e.g lore?

 

if(event.entity instanceof EntityItem) { ... }

and

entityItem.getEntityItem();//returns the itemstack, which you can then request lore from

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Since you are on the client the player is always

Minecraft.getMinecraft().thePlayer

.

While the code is now working perfectly in Singleplayer, the item is always "Stone" in multiplayer. Is this due to the Server not passing on information about the item?

 

Currently using

@SubscribeEvent
public void onSpawn(EntityJoinWorldEvent e) {

	if (e.getEntity() != null && Minecraft.getMinecraft().thePlayer != null) {

		if (e.getEntity().getDistanceToEntity(Minecraft.getMinecraft().thePlayer) <= 10) {

			if (e.getEntity() instanceof EntityItem) {

				EntityItem item = (EntityItem) e.getEntity();

				Util.chat(Minecraft.getMinecraft().thePlayer, "Item: " + item.getEntityItem().getDisplayName(),
						TextFormatting.GREEN);

			}

		}

	}

}

 

Link to comment
Share on other sites

Nevermind, used the wrong timer :P

For everyone still seeking a solution, this one works for me!

	@SubscribeEvent
public void onSpawn(final EntityJoinWorldEvent e) {

	new java.util.Timer().schedule(new java.util.TimerTask() {
		@Override
		public void run() {

			if (e.getEntity() != null && Minecraft.getMinecraft().thePlayer != null) {

				if (e.getEntity().getDistanceToEntity(Minecraft.getMinecraft().thePlayer) <= 10) {

					EntityItem item = (EntityItem) e.getEntity();

					Util.chat(Minecraft.getMinecraft().thePlayer, "Item: " + item.getEntityItem().getDisplayName(),
							TextFormatting.GREEN);

				}

			}

		}
	}, 100);

}

Link to comment
Share on other sites

Oh hell no, don't do that!

java.util.Timer spawns a new thread, but you can only interact with the world from the main thread. You need to listen for tick events and count.

Sorry! To be honest, I never quite touched timers :P

 

I know there is the update methode called once per tick, but how would I implement it in this case? Wouldn't it have to be "counted" within the EntityJoinWorldEvent?

Link to comment
Share on other sites

Wouldn't vanilla's

IThreadListener

system work for this purpose?

No, since it first checks if you are already calling from the correct thread and in that case immediately executes the task.

 

Ah, I didn't realise that.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

This solution now works for me, I do hope I did it right this time :P

package at.skyblok.client;

import java.util.LinkedList;
import java.util.Queue;

import net.minecraft.client.Minecraft;
import net.minecraft.entity.Entity;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.util.text.TextFormatting;
import net.minecraftforge.event.entity.EntityJoinWorldEvent;
import net.minecraftforge.event.entity.living.LivingEvent.LivingUpdateEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class WynncraftEvents {

Queue<Runnable> queue;

public WynncraftEvents() {

	queue = new LinkedList<Runnable>();

}

void addTask(Runnable r) {
	queue.add(r);
}

@SubscribeEvent
public void onPlayerUpdate(LivingUpdateEvent e) {

	if (e.getEntity() != null && Minecraft.getMinecraft().thePlayer != null) {

		if (e.getEntity().getDistanceToEntity(Minecraft.getMinecraft().thePlayer) <= 10) {

			while (!queue.isEmpty()) {
				queue.remove().run();

			}

		}
	}

}

@SubscribeEvent
public void onSpawn(final EntityJoinWorldEvent e) {

	if (e.getEntity() != null && Minecraft.getMinecraft().thePlayer != null) {

		if (e.getEntity().getDistanceToEntity(Minecraft.getMinecraft().thePlayer) <= 10) {

			if (e.getEntity() instanceof EntityItem) {

				addTask(new Runnable() {

					@Override
					public void run() {

						readItem(e.getEntity());

					}
				});
			}

		}

	}

}

private void readItem(Entity en) {

	EntityItem item = (EntityItem) en;
	Util.chat(Minecraft.getMinecraft().thePlayer, "Item: " + item.getEntityItem().getDisplayName(),
			TextFormatting.GREEN);

}

}

Link to comment
Share on other sites

http://mcforge.readthedocs.org/en/latest/concepts/sides/

 

Few things:

 

1. If your mod will be client only - mark it with clientSideOnly="true".

* This way pretty much there is no way it can be loaded by dedicated server and you don't have to worry about using client-only stuff ever (thus @SideOnly will not be needed anywhere in mod).

 

2. If your mod is sided:

* I recommend separating code in packages such as "common", "client", "server" (where server will be almost never used unless you are writing private and/or server mods).

* Mark all classes in given packages with @SideOnly(Side#side) to honor given side.

 

3. Why am I mentioning above? Aside from using @SidedProxy, you should make sure everything works as you want it to - here @SideOnly ensures you actually are not using stuff that doesn't belong in given place (because it will crash otherwise).

 

Other:

4. Null-checks are pointless for pretty much any event (regarding entities, not e.g: BreakBlock). Note: "Minecraft.getMinecraft().thePlayer != null" is valid.

5. Please rename your method "onPlayerUpdate" - false, it fires for all entities (I recommend naming method "on"+eventName).

6. $readItem should take EntityItem, and casting should be made by method caller.

 

Aside from that:

* I don't see any damn logic in your approach so I will interpret it as code for testing. If that is not - tell your goal so maybe we could give better solution.

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

http://mcforge.readthedocs.org/en/latest/concepts/sides/

 

Few things:

 

1. If your mod will be client only - mark it with clientSideOnly="true".

* This way pretty much there is no way it can be loaded by dedicated server and you don't have to worry about using client-only stuff ever (thus @SideOnly will not be needed anywhere in mod).

 

2. If your mod is sided:

* I recommend separating code in packages such as "common", "client", "server" (where server will be almost never used unless you are writing private and/or server mods).

* Mark all classes in given packages with @SideOnly(Side#side) to honor given side.

 

3. Why am I mentioning above? Aside from using @SidedProxy, you should make sure everything works as you want it to - here @SideOnly ensures you actually are not using stuff that doesn't belong in given place (because it will crash otherwise).

 

Other:

4. Null-checks are pointless for pretty much any event (regarding entities, not e.g: BreakBlock). Note: "Minecraft.getMinecraft().thePlayer != null" is valid.

5. Please rename your method "onPlayerUpdate" - false, it fires for all entities (I recommend naming method "on"+eventName).

6. $readItem should take EntityItem, and casting should be made by method caller.

 

Aside from that:

* I don't see any damn logic in your approach so I will interpret it as code for testing. If that is not - tell your goal so maybe we could give better solution.

Thanks for the advice!

The mod was written for a "RPG" server, where items dropped are unidentified, and there is no way to know which item you'll get unless you take it to a npc and so on, therefore this code is quite helpful for reading out the name of anything that's dropped nearby, to stop unecessary collecting of items.

Link to comment
Share on other sites

The mod was written for a "RPG" server, where items dropped are unidentified, and there is no way to know which item you'll get unless you take it to a npc and so on, therefore this code is quite helpful for reading out the name of anything that's dropped nearby, to stop unecessary collecting of items.

In other words, you're writing a client-side mod to defeat the purpose and rules of a server (i.e. cheating). I think we're done here.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

The mod was written for a "RPG" server, where items dropped are unidentified, and there is no way to know which item you'll get unless you take it to a npc and so on, therefore this code is quite helpful for reading out the name of anything that's dropped nearby, to stop unecessary collecting of items.

In other words, you're writing a client-side mod to defeat the purpose and rules of a server (i.e. cheating). I think we're done here.

You shouldn't try to judge before you know the whole story.

It was more of an experiment at first, and after I was done I asked for allowance, which was given to me.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
    • Remove Instant Massive Structures Mod from your server     Add new crash-reports with sites like https://paste.ee/  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.