Jump to content
  • Home
  • Files
  • Docs
  • Merch
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [1.10.2] registerServerCommand Not Working
1.13 Update Notes for Mod Creators
Sign in to follow this  
Followers 1
ViewtifulDom

[1.10.2] registerServerCommand Not Working

By ViewtifulDom, July 17, 2016 in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

ViewtifulDom    0

ViewtifulDom

ViewtifulDom    0

  • Tree Puncher
  • ViewtifulDom
  • Members
  • 0
  • 5 posts
Posted July 17, 2016

I've just started practicing with Forge modding, and I'm trying to create a simple command that prints "It works!" to the server chat, just so I can prove that it does, in fact, work.

 

It doesn't, of course.  I can't seem to use registerServerCommand() in the code below:

 

Main.java

import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.Mod.Instance;
import net.minecraftforge.fml.common.event.FMLServerStartingEvent;

@Mod(modid = Main.MODID, name = Main.MODNAME, version = Main.VERSION)
public class Main {

    public static final String MODID = "testmod";
    public static final String MODNAME = "Domo's Test Mod";
    public static final String VERSION = "1.0";
        
    @Instance
    public static Main instance = new Main();
        
    @EventHandler
    public void load(FMLServerStartingEvent event) {
event.registerServerCommand(new TestCommand());
    }
}

 

TestCommand.java

import java.util.ArrayList;
import java.util.List;

import net.minecraft.command.CommandException;
import net.minecraft.command.ICommand;
import net.minecraft.command.ICommandSender;
import net.minecraft.server.MinecraftServer;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.text.TextComponentString;

public class TestCommand implements ICommand
{
private final List aliases;

public TestCommand() 
    { 
        aliases = new ArrayList(); 
        aliases.add("testcommand"); 
        aliases.add("tc"); 
    }

@Override
public int compareTo(ICommand arg0) {
	return 0;
}

@Override
public String getCommandName()
{
	return "testcommand"; 
}

@Override
public String getCommandUsage(ICommandSender sender)
{
	return "testcommand"; 
}

@Override
public List<String> getCommandAliases()
{
	return this.aliases;
}

@Override
public void execute(MinecraftServer server, ICommandSender sender, String[] args) throws CommandException
{
	sender.addChatMessage(new TextComponentString("It works!"));
}

@Override
public boolean checkPermission(MinecraftServer server, ICommandSender sender) {
	return false;
}

@Override
public List<String> getTabCompletionOptions(MinecraftServer server, ICommandSender sender, String[] args,
		BlockPos pos) {
	return null;
}

@Override
public boolean isUsernameIndex(String[] args, int index) {
	return false;
} 
}

 

I'll be honest - I'm not good at this, there are significant holes in my understanding of Java and Forge's whole structure.  I've been using Minecraft modding as practice, and it's helped me immensely in becoming a better programmer, but I still run into obstacles I can't handle.  Point being - I can't solve this, although I have a feeling it's a REALLY easy fix that I'm not seeing.  Can anyone shed some light on this?

  • Quote

Share this post


Link to post
Share on other sites

Draco18s    2096

Draco18s

Draco18s    2096

  • Reality Controller
  • Draco18s
  • Members
  • 2096
  • 14031 posts
Posted July 17, 2016
@Instance
public static Main instance = new Main();

 

Do not instantiate your own main class, the @Instance annotation does it for you as Forge loads your mod.

  • Quote

Share this post


Link to post
Share on other sites

ViewtifulDom    0

ViewtifulDom

ViewtifulDom    0

  • Tree Puncher
  • ViewtifulDom
  • Members
  • 0
  • 5 posts
Posted July 17, 2016

Do not instantiate your own main class, the @Instance annotation does it for you as Forge loads your mod.

 

I took out that whole line, all that's left is '@Instance', and it's giving me an error:

 

The annotation @Mod.Instance is disallowed for this location

I had that line in the first place after following this advice from a tutorial:

 

The next thing we need in your main class is an instance of it. Forge uses this instance to have a reference to your mod in order to communicate with it. If we don't create the instance on our own, Forge creates one for us. The problem of this method is that we have no access on the instance anymore, so I would recommend to create the instance manually.

  • Quote

Share this post


Link to post
Share on other sites

Ernio    598

Ernio

Ernio    598

  • Reality Controller
  • Ernio
  • Forge Modder
  • 598
  • 2638 posts
Posted July 17, 2016

1. You shouldn't implement ICommand (unless needed). Use (extend) CommandBase.

 

2.

Do not instantiate your own main class, the @Instance annotation does it for you as Forge loads your mod.

I took out that whole line, all that's left is '@Instance', and it's giving me an error:

 

Learn what "instantiate" means. Annotation has to be assigned to something and that is field declaration.

  • Quote

Share this post


Link to post
Share on other sites

ViewtifulDom    0

ViewtifulDom

ViewtifulDom    0

  • Tree Puncher
  • ViewtifulDom
  • Members
  • 0
  • 5 posts
Posted July 17, 2016

1. You shouldn't implement ICommand (unless needed). Use (extend) CommandBase.

 

Extending CommandBase hasn't fixed the error, it's still telling me the same thing.

 

I'd like to ignore any issues with my mod instance, as it is not causing me any immediate problems.  Thank you for your suggestions, though.

  • Quote

Share this post


Link to post
Share on other sites

shadowfacts    100

shadowfacts

shadowfacts    100

  • Dragon Slayer
  • shadowfacts
  • Forge Modder
  • 100
  • 588 posts
Posted July 17, 2016

Maybe it's because you're returning

false

no matter what from

checkPermission

. If you had extended

CommandBase

and not overridden all these methods, you wouldn't have this issue.

  • Quote

Share this post


Link to post
Share on other sites

ViewtifulDom    0

ViewtifulDom

ViewtifulDom    0

  • Tree Puncher
  • ViewtifulDom
  • Members
  • 0
  • 5 posts
Posted July 17, 2016

Maybe it's because you're returning

false

no matter what from

checkPermission

. If you had extended

CommandBase

and not overridden all these methods, you wouldn't have this issue.

 

Alright, this is what it looks like now, as per your suggestion:

 

TestCommand.java

import net.minecraft.command.CommandBase;
import net.minecraft.command.CommandException;
import net.minecraft.command.ICommandSender;
import net.minecraft.server.MinecraftServer;
import net.minecraft.util.text.TextComponentString;

public class TestCommand extends CommandBase
{

@Override
public String getCommandName() {
	return "testcommand";
}

@Override
public String getCommandUsage(ICommandSender sender) {

	return "testcommand";
}

@Override
public void execute(MinecraftServer server, ICommandSender sender, String[] args) throws CommandException
{
	sender.addChatMessage(new TextComponentString("It works!"));
}

}

 

I realized I never posted the error I was getting from registerServerCommand:

The method registerServerCommand(l) in the type FMLServerStartingEvent is not applicable for the arguments (TestCommand)

Main.java

import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.Mod.Instance;
import net.minecraftforge.fml.common.event.FMLServerStartingEvent;

@Mod(modid = Main.MODID, name = Main.MODNAME, version = Main.VERSION)
public class Main {

    public static final String MODID = "testmod";
    public static final String MODNAME = "Domo's Test Mod";
    public static final String VERSION = "1.0";
        
    @Instance
    public static Main instance;
        
    @EventHandler
public void load(FMLServerStartingEvent event) {
	event.registerServerCommand(new TestCommand());
}
}

  • Quote

Share this post


Link to post
Share on other sites

ViewtifulDom    0

ViewtifulDom

ViewtifulDom    0

  • Tree Puncher
  • ViewtifulDom
  • Members
  • 0
  • 5 posts
Posted July 18, 2016

In case it wasn't clear, even after making these changes, it still does not work.  Does anyone know why that method can't be found, or why it suggests casting TestCommand as an 'l' type?

  • Quote

Share this post


Link to post
Share on other sites

Botjoe    1

Botjoe

Botjoe    1

  • Tree Puncher
  • Botjoe
  • Members
  • 1
  • 34 posts
Posted July 20, 2016

Hi,

Quick notes.

 

1) First you have no packages in the java source. (e.g package com.mymods.testcommandmod; )

 

2) I do the register in server start.

 

@EventHandler
public void serverStart(FMLServerStartingEvent event) {

	MinecraftServer server = event.getServer();
	ICommandManager command = server.getCommandManager();
	ServerCommandManager manager = (ServerCommandManager) command;
	ICommand cmd;
	if (strFiles == null) {
		cmd = new ExecuteFile(server);

		manager.registerCommand(cmd);
	} else {
// This sends the directory list of files to the command for tabcompletion of file names. strFiles is loaded in the server once. 
		cmd = new ExecuteFile(server, mydirProperty.getString(), strFiles);
		manager.registerCommand(cmd);
	}

}

 

3) By the Way : Do the recommended housekeeping

 

I set up the apache logger and set accepted versions, et al.

public static final Logger logger = LogManager.getLogger(MODID);

 

And in the @MOD annotation, I added the maven formatted acceptedVersions; and required-after

e.g.

public static final String REQUIRED_AFTER = "required-after:Forge@[12.16.0.1887,]";

 

 

 

  • Quote

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

  • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 1
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • AdieCraft
      Japanese Style Temple Base

      By AdieCraft · Posted 18 minutes ago

      Hello there!   Check out my latest tutorial in my Japanese Builds series, building a Japanese Temple base.   Make sure to Subscribe, so you don't miss any future videos.   Thanks   Adie   Japanese Style Temple Base    
    • DaemonUmbra
      Forge crashes on start

      By DaemonUmbra · Posted 58 minutes ago

      Forge for 1.13+ requires Java 8-10 Forge for 1.12.2- requires Java 8
    • GttiqwT
      [1.12.2] Multiple Structure Generation

      By GttiqwT · Posted 1 hour ago

      Yeah I get where you're coming from. I also watched harry talk's tutorial and at first it worked but then I got the problem that it wont spawn more than one structure otherwise it'll overlap and only spawn the latest one added. I tried to follow this tutorial again and it just didnt seem to work at all now. When I get more time ill have to do it again and then afterwards try and fix the issues with spawning more than one structure. I'm currently trying to fix the issue where it causes cascading gen lag but I dont know how to fix that quite yet either.
    • Draco18s
      Distinguish singleplayer vs. multiplayer

      By Draco18s · Posted 1 hour ago

      No. Your client code is sending information to make the server do things. Your server code is telling the server to do those same things (again).
    • solitone
      Distinguish singleplayer vs. multiplayer

      By solitone · Posted 2 hours ago

      This isn’t an issue but normal behaviour, is it?
  • Topics

    • AdieCraft
      0
      Japanese Style Temple Base

      By AdieCraft
      Started 18 minutes ago

    • bitman
      1
      Forge crashes on start

      By bitman
      Started 2 hours ago

    • Merthew
      7
      [1.12.2] Multiple Structure Generation

      By Merthew
      Started November 7, 2018

    • solitone
      24
      Distinguish singleplayer vs. multiplayer

      By solitone
      Started December 5

    • TheGreenSquarez
      5
      Forge 28.1.10 won't show on launcher + 28.1.0 fails to work

      By TheGreenSquarez
      Started Wednesday at 11:21 AM

  • Who's Online (See full list)

    • Mango106
    • Creeperslayercc
    • Gamercraft99
    • Alpvax
    • thinkverse
    • AdieCraft
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [1.10.2] registerServerCommand Not Working
  • Theme
  • Contact Us
  • Discord

Copyright © 2019 ForgeDevelopment LLC · Ads by Curse Powered by Invision Community