Jump to content

Invert boolean value when a key is pressed


American2050

Recommended Posts

This is kinda off topic to ask on the Modder Support Forum, so I ask here.

 

I have an item that runs a code while player holds right click on it.

 

I want to change the state of a boolean when the player presses Control key. The problem I have if that checking with something like this:

 

if (Keyboard.isKeyDown(Keyboard.KEY_LCONTROL))
    {
		this.isLocked = !this.isLocked;
    }

 

Will make the boolean isLocked to switch from true to false constantly while the key is pressed. Is there a way to make it switch just once until the next time Control is pressed?

 

Thanks.

Link to comment
Share on other sites

Don't use Keyboard.isKeyDown.

Subscribe to

KeyInputEvent

. In there check

Keyboard.getEventKey

if it's the key you want and

Keyboard.getEventKeyState

to check if it was pressed or released (true for pressed, false for released).

 

And this fits perfectly fine in Modder Support.

When you say "Subscribe" to KeyInputEvent, you mean like subscribing a Forge Event?

Link to comment
Share on other sites

Ohh ok. And do I have to declare a Key on the Controls also, to give the players the ability to change the key that triggers this?

 

I guess it would be a good practice, as default it would be Control, that, as we all know, it's assigned to Sprint. I don't want to cause a Key Conflict :P

Link to comment
Share on other sites

Tried that way, but it keeps triggering until another key is pressed.

 

    		if(Keyboard.getEventKey() == MyKeyBindings.toggleWater.getKeyCodeDefault() && MyKeyBindings.toggleWater.getKeyModifier().isActive()){

    			isLocked = !isLocked;
    			
    		}

 

I found a fix from my KeyMonitor:

 

	       if(Keyboard.isKeyDown(Keyboard.KEY_LCONTROL)){
    	   
    	   WateringDongle.isLocked = !WateringDongle.isLocked;
     
       }

 

And this method doesn't trigger to fast, so unless the player keeps holding the key for a long time, it will toggle false/true really well.

Link to comment
Share on other sites

The first version is fine, you just did not check

getEventKeyState

like I told you.

Oh, and also don't use

getKeyCodeDefault

, use

getKeyCode

.

getKeyCodeDefault

is the default value, not the one the user set.

Ohh I see. Thanks.

 

I switched to Default as one was returning 29 and the other 34 I believe, but maybe it is because I was checking against the wrong on ;) Gonna give it a try again.

 

However from the KeyMonitor it's nice, as I can now check against Left Control, and it doesn't matter if the Key is assigned to sprint also, so it doesn't cause a key conflict.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
    • Remove Instant Massive Structures Mod from your server     Add new crash-reports with sites like https://paste.ee/  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.