Jump to content

Removing the exact amount of an item from the inventory of the player


madcrazydrumma

Recommended Posts

Hey guys!

 

So I basically have an itemstack of say size 4 input into this method..

 

Now I want to remove this from the player's inventory, even if he/she doesn't have the exact amount in one itemstack. So there could be two itemstacks of size 2 that make up my input itemstack.

 

I've got this previously (but it doesn't work for obvious reasons):

 

public static void removeItem(EntityPlayer player, ItemStack is, int amount) {
	if(is == null)
		return;

	int removed = 0;

	for(ItemStack stack : player.inventory.mainInventory) {
		if(stack != null && removed <= amount) {
			if(areItemStacksEqual(stack, is)) {
				stack.stackSize--;
				removed++;
			}
		}
	}
}

 

This is my areItemStacksEqual implementation

 

public static boolean areItemStacksEqual(ItemStack stack1, ItemStack stack2) {
	if(stack1 == null || stack2 == null)
		return stack1 == stack2;

	return stack1.isItemEqual(stack2) && ItemStack.areItemStackTagsEqual(stack1, stack2);
}

 

I think I have to, instead of incrementing removed by one, I have to increment it by the amount of the stack?

 

Help is much appreciated! Thanks

Link to comment
Share on other sites

Don't forget to check metadata.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

areItemStacksEqual checks if the stacks have the same stacksize, which is not what you want.

 

change ur method to take an Item as param instead of an ItemStack, and then check stack.getItem()==myPassedItem

 

Don't forget to check metadata.

 

I've got the implementation already myself. Check the updated OP.

Link to comment
Share on other sites

[me=Draco18s]facepalm.[/me]

 

		if(stack1 == null || stack2 == null)
		return stack1 == stack2;

 

You should just return false here.  Passing two null stacks and getting a true is misleading (would you EVER want to do anything with two null stacks?), where as a single null stack and a not-null stack will always return false.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Passing two null stacks and getting a true is misleading

I think having equals(null, null) return false is even more misleading.

 

...Fair. I was probably tired and not thinking.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.