Jump to content

[1.9] Corner upside stairs rendering problem


JimiIT92

Recommended Posts

311c8b676c.png

No it doesn't, You're using the wrong model for your blockstate. If you notice your 'corner' is in the wrong spot.

The engine THINKS it is where it supposed to be so it culls some of the faces in the neighbors block.

This is how the engine works, if you use a invalidly shaped model for any other block this will be the same result.

 

Fix your model.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites

Stair rendering does have some problems. I get this as well:

 

Left: Forge 1.9-12.16.0.1863, Right: Vanilla 1.9

stairrenders.jpg

 

These are custom stair models so they are revealing the problem a bit differently. In 1.8.9 stairs would cull adjacent blocks to some sides. In 1.9 stairs do not cause any render culling (maybe of slabs, slabs have their own thing here), they are treated like a true transparent block. But, with Forge, stairs are culling adjacent blocks.

 

I checked the 1.8.9 stairs blockstates and they aren't really different from 1.9 (like fences are because of multiparts).

 

JimiIT92, if you'd like me to go over your blockstates or model code I can do that for ya. If in doubt, I generally recommend pasting in the original vanilla code first, especially for blockstates.

 

I wasn't sure if I should make my own thread, if there's a set of stair problems ;)

Link to comment
Share on other sites

Yes those stairs are abusing a bug in vanillas culling system that forge fixes.

Blocks need to be the basic shapes that vanilla blocks are. Solid sides need to be solid, simple as that.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites

  • 1 month later...

I had the same problem as shown in the first post. I'm using the latest recommended Forge: forge-1.9-12.16.1.1887-mdk

 

Vanilla Blocks just work fine in 1.8 and 1.9, my stais worked fine in 1.8, but in 1.9 my upper corner (inner and outer) stairs didn't rotate properly. The lower stairs were ok. Im using the vanilla models.

 

 

The solution for me was to change the blockstates and rotate the blocks there. I changed the "y"-Value in the lower half by either adding or substracting 90 degrees (outer_right +90, outer_left -90, inner_right +90, inner_left -90)

 

Code:

assets/roxastonestairs/blockstates/stoneStair.json for 1.8

{
    "variants": {
        "facing=east,half=bottom,shape=straight":    { "model": "RoxaStoneStairs:stoneStair" },
        "facing=west,half=bottom,shape=straight":    { "model": "RoxaStoneStairs:stoneStair", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=straight":   { "model": "RoxaStoneStairs:stoneStair", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=straight":   { "model": "RoxaStoneStairs:stoneStair", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_right": { "model": "RoxaStoneStairs:stoneStair_outer_stairs" },
        "facing=west,half=bottom,shape=outer_right": { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=outer_right":{ "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=outer_right":{ "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_left":  { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=outer_left":  { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=outer_left": { "model": "RoxaStoneStairs:stoneStair_outer_stairs" },
        "facing=north,half=bottom,shape=outer_left": { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 180, "uvlock": true },
        "facing=east,half=bottom,shape=inner_right": { "model": "RoxaStoneStairs:stoneStair_inner_stairs" },
        "facing=west,half=bottom,shape=inner_right": { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=inner_right":{ "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=inner_right":{ "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=inner_left":  { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=inner_left":  { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=inner_left": { "model": "RoxaStoneStairs:stoneStair_inner_stairs" },
        "facing=north,half=bottom,shape=inner_left": { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 180, "uvlock": true },
        "facing=east,half=top,shape=straight":       { "model": "RoxaStoneStairs:stoneStair", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=straight":       { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=straight":      { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=straight":      { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=outer_right":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=west,half=top,shape=outer_right":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=outer_right":   { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=north,half=top,shape=outer_right":   { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=outer_left":     { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=west,half=top,shape=outer_left":     { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=outer_left":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=outer_left":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=east,half=top,shape=inner_right":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=west,half=top,shape=inner_right":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=inner_right":   { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=north,half=top,shape=inner_right":   { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=inner_left":     { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=west,half=top,shape=inner_left":     { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=inner_left":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=inner_left":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":   0, "uvlock": true }
    }
}

 

assets/roxastonestairs/blockstates/stoneStair.json for 1.9

{
    "variants": {
        "facing=east,half=bottom,shape=straight":    { "model": "RoxaStoneStairs:stoneStair" },
        "facing=west,half=bottom,shape=straight":    { "model": "RoxaStoneStairs:stoneStair", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=straight":   { "model": "RoxaStoneStairs:stoneStair", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=straight":   { "model": "RoxaStoneStairs:stoneStair", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_right": { "model": "RoxaStoneStairs:stoneStair_outer_stairs" },
        "facing=west,half=bottom,shape=outer_right": { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=outer_right":{ "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=outer_right":{ "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_left":  { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=outer_left":  { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=outer_left": { "model": "RoxaStoneStairs:stoneStair_outer_stairs" },
        "facing=north,half=bottom,shape=outer_left": { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 180, "uvlock": true },
        "facing=east,half=bottom,shape=inner_right": { "model": "RoxaStoneStairs:stoneStair_inner_stairs" },
        "facing=west,half=bottom,shape=inner_right": { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=inner_right":{ "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=inner_right":{ "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=inner_left":  { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=inner_left":  { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=inner_left": { "model": "RoxaStoneStairs:stoneStair_inner_stairs" },
        "facing=north,half=bottom,shape=inner_left": { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 180, "uvlock": true },
        "facing=east,half=top,shape=straight":       { "model": "RoxaStoneStairs:stoneStair", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=straight":       { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=straight":      { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=straight":      { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=outer_right":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=west,half=top,shape=outer_right":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=outer_right":   { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=outer_right":   { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=east,half=top,shape=outer_left":     { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=west,half=top,shape=outer_left":     { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=outer_left":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=north,half=top,shape=outer_left":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=inner_right":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=west,half=top,shape=inner_right":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=inner_right":   { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=inner_right":   { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=east,half=top,shape=inner_left":     { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=west,half=top,shape=inner_left":     { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=inner_left":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=north,half=top,shape=inner_left":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 270, "uvlock": true }
    }
}

Link to comment
Share on other sites

I don't know if this will help, but this are all my json files

 

blockstate

{
    "variants": {
        "facing=east,half=bottom,shape=straight":  { "model": "mw:aluminium_stairs" },
        "facing=west,half=bottom,shape=straight":  { "model": "mw:aluminium_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=straight": { "model": "mw:aluminium_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=straight": { "model": "mw:aluminium_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_right":  { "model": "mw:aluminium_outer_stairs" },
        "facing=west,half=bottom,shape=outer_right":  { "model": "mw:aluminium_outer_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=outer_right": { "model": "mw:aluminium_outer_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=outer_right": { "model": "mw:aluminium_outer_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_left":  { "model": "mw:aluminium_outer_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=outer_left":  { "model": "mw:aluminium_outer_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=outer_left": { "model": "mw:aluminium_outer_stairs" },
        "facing=north,half=bottom,shape=outer_left": { "model": "mw:aluminium_outer_stairs", "y": 180, "uvlock": true },
        "facing=east,half=bottom,shape=inner_right":  { "model": "mw:aluminium_inner_stairs" },
        "facing=west,half=bottom,shape=inner_right":  { "model": "mw:aluminium_inner_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=inner_right": { "model": "mw:aluminium_inner_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=inner_right": { "model": "mw:aluminium_inner_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=inner_left":  { "model": "mw:aluminium_inner_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=inner_left":  { "model": "mw:aluminium_inner_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=inner_left": { "model": "mw:aluminium_inner_stairs" },
        "facing=north,half=bottom,shape=inner_left": { "model": "mw:aluminium_inner_stairs", "y": 180, "uvlock": true },
        "facing=east,half=top,shape=straight":  { "model": "mw:aluminium_stairs", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=straight":  { "model": "mw:aluminium_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=straight": { "model": "mw:aluminium_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=straight": { "model": "mw:aluminium_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=outer_right":  { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=west,half=top,shape=outer_right":  { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=outer_right": { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=outer_right": { "model": "mw:aluminium_outer_stairs", "x": 180, "uvlock": true },
        "facing=east,half=top,shape=outer_left":  { "model": "mw:aluminium_outer_stairs", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=outer_left":  { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=outer_left": { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=outer_left": { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=inner_right":  { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=west,half=top,shape=inner_right":  { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=inner_right": { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=inner_right": { "model": "mw:aluminium_inner_stairs", "x": 180, "uvlock": true },
        "facing=east,half=top,shape=inner_left":  { "model": "mw:aluminium_inner_stairs", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=inner_left":  { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=inner_left": { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=inner_left": { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 270, "uvlock": true }
    }
}

 

Item

{
    "parent": "mw:block/aluminium_stairs"
}

 

Block models

normal

{
    "parent": "block/stairs",
    "textures": {
        "bottom": "mw:blocks/aluminium_block",
        "top": "mw:blocks/aluminium_block",
        "side": "mw:blocks/aluminium_block"
    }
}

 

inner

{
    "parent": "block/inner_stairs",
    "textures": {
        "bottom": "mw:blocks/aluminium_block",
        "top": "mw:blocks/aluminium_block",
        "side": "mw:blocks/aluminium_block"
    }
}

 

outer

{
    "parent": "block/outer_stairs",
    "textures": {
        "bottom": "mw:blocks/aluminium_block",
        "top": "mw:blocks/aluminium_block",
        "side": "mw:blocks/aluminium_block"
    }
}

 

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.